Re: making update/delete of inheritance trees scale better

2020-05-13 Thread Amit Langote
On Thu, May 14, 2020 at 7:55 AM David Rowley wrote: > On Wed, 13 May 2020 at 19:02, Amit Langote wrote: > > > As for which ResultRelInfos to initialize, couldn't we just have the > > > planner generate an OidList of all the ones that we could need. > > > Basically, all the non-pruned partitions.

Re: pg13: xlogreader API adjust

2020-05-13 Thread Kyotaro Horiguchi
At Thu, 14 May 2020 01:03:48 +, "Bossart, Nathan" wrote in > I think I've discovered a problem with 850196b6. The following steps > can be used to trigger a segfault: > > # wal_level = logical > psql postgres -c "create database testdb;" > psql testdb -c "select pg_

Re: MultiXact\SLRU buffers configuration

2020-05-13 Thread Andrey M. Borodin
> 14 мая 2020 г., в 06:25, Kyotaro Horiguchi > написал(а): > > At Wed, 13 May 2020 23:08:37 +0500, "Andrey M. Borodin" > wrote in >> >> >>> 11 мая 2020 г., в 16:17, Andrey M. Borodin >>> написал(а): >>> >>> I've went ahead and created 3 patches: >>> 1. Configurable SLRU buffer sizes f

Re: PG 13 release notes, first draft

2020-05-13 Thread Fabien COELHO
Hello Bruce, * 34a0a81bfb We already have: Reformat tables containing function information for better clarity (Tom Lane) so it seems it is covered as part of this. AFAICR this one is not by the same author, and although the point was about better clarity, it was not abou

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

2020-05-13 Thread Amit Kapila
On Wed, May 13, 2020 at 9:16 PM Dilip Kumar wrote: > > On Wed, May 13, 2020 at 4:50 PM Amit Kapila wrote: > > > > > > > > 4. > > > > +static void > > > > +stream_start_cb_wrapper(ReorderBuffer *cache, ReorderBufferTXN *txn) > > > > +{ > > > > + LogicalDecodingContext *ctx = cache->private_data; >

Re: pendingOps table is not cleared with fsync=off

2020-05-13 Thread Heikki Linnakangas
On 09/05/2020 02:53, Thomas Munro wrote: On Sat, May 9, 2020 at 9:21 AM Heikki Linnakangas wrote: I noticed that commit 3eb77eba5a changed the logic in ProcessSyncRequests() (formerly mdsync()) so that if you have fsync=off, the entries are not removed from the pendingOps hash table. I don't th

Re: Parallel copy

2020-05-13 Thread Amit Kapila
On Thu, May 14, 2020 at 12:39 AM Robert Haas wrote: > > On Tue, May 12, 2020 at 1:01 AM Amit Kapila wrote: > > I don't understand why we need to do something special for combo CIDs > > if they are not generated during this operation? > > Hmm. Well I guess if they're not being generated then we do

Re: PG 13 release notes, first draft

2020-05-13 Thread Kyotaro Horiguchi
At Wed, 13 May 2020 22:40:52 -0400, Bruce Momjian wrote in > On Thu, May 14, 2020 at 09:51:41AM +0900, Kyotaro Horiguchi wrote: > > At Wed, 13 May 2020 11:15:18 -0400, Bruce Momjian wrote > > in > > > On Wed, May 13, 2020 at 11:56:33AM +0900, Kyotaro Horiguchi wrote: > > It is just an more acc

Re: MultiXact\SLRU buffers configuration

2020-05-13 Thread Kyotaro Horiguchi
At Thu, 14 May 2020 10:19:42 +0500, "Andrey M. Borodin" wrote in > >> I'm looking more at MultiXact and it seems to me that we have a race > >> condition there. > >> > >> When we create a new MultiXact we do: > >> 1. Generate new MultiXactId under MultiXactGenLock > >> 2. Record new mxid with

Re: SLRU statistics

2020-05-13 Thread Fujii Masao
On 2020/05/07 13:47, Fujii Masao wrote: On 2020/05/03 1:59, Tomas Vondra wrote: On Sat, May 02, 2020 at 12:55:00PM +0200, Tomas Vondra wrote: On Sat, May 02, 2020 at 03:56:07PM +0900, Fujii Masao wrote: ... Another thing I found is; pgstat_send_slru() should be called also by other pr

Re: MultiXact\SLRU buffers configuration

2020-05-13 Thread Andrey M. Borodin
> 14 мая 2020 г., в 11:16, Kyotaro Horiguchi > написал(а): > > At Thu, 14 May 2020 10:19:42 +0500, "Andrey M. Borodin" > wrote in I'm looking more at MultiXact and it seems to me that we have a race condition there. When we create a new MultiXact we do: 1. Genera

Re: Parallel copy

2020-05-13 Thread Dilip Kumar
On Thu, May 14, 2020 at 11:48 AM Amit Kapila wrote: > > On Thu, May 14, 2020 at 12:39 AM Robert Haas wrote: > > > > On Tue, May 12, 2020 at 1:01 AM Amit Kapila wrote: > > > I don't understand why we need to do something special for combo CIDs > > > if they are not generated during this operation

<    1   2