Re: Subplan result caching

2020-04-26 Thread Andy Fan
On Sun, Apr 26, 2020 at 2:11 PM David Rowley wrote: > On 23 May 2018 at 21:31, Heikki Linnakangas wrote: > > I've been working on a patch to add a little cache to SubPlans, to speed > up > > queries with correlated subqueries, where the same subquery is currently > > executed multiple times with

Re: [Proposal] Global temporary tables

2020-04-26 Thread 曾文旌
> 2020年4月23日 下午3:43,Pavel Stehule 写道: > > > > čt 23. 4. 2020 v 9:10 odesílatel 曾文旌 > napsal: > > >> 2020年4月22日 下午10:50,Pavel Stehule > > 写道: >> >> >> >> st 22. 4. 2020 v 16:38 odesílatel Prabhat Sahu >> mailto:prabhat.

Re: WIP: Aggregation push-down

2020-04-26 Thread Andy Fan
On Fri, Apr 24, 2020 at 8:10 PM Antonin Houska wrote: > Andy Fan wrote: > > > The more tests on your patch, the more powerful I feel it is! > > Thanks for the appreciation. Given the poor progress it's increasingly hard > for me to find motivation to work on it. I'll try to be more professional

Re: Subplan result caching

2020-04-26 Thread David Rowley
On Sun, 26 Apr 2020 at 19:08, Andy Fan wrote: > If we want to handle this case as well, one of the changes would > be it needs to cache multi records for one input parameter, or return > one row each time but return mutli times for one input parameter, > Tuplestore may be a good option for this ca

Re: Setting min/max TLS protocol in clientside libpq

2020-04-26 Thread Peter Eisentraut
On 2020-04-24 14:03, Daniel Gustafsson wrote: On 24 Apr 2020, at 12:56, Peter Eisentraut wrote: Can we reconsider whether we really want to name the new settings like "sslminprotocolversion", or whether we could add some underscores, both for readability and for consistency with the server-s

Re: Subplan result caching

2020-04-26 Thread Andy Fan
On Sun, Apr 26, 2020 at 5:49 PM David Rowley wrote: > On Sun, 26 Apr 2020 at 19:08, Andy Fan wrote: > > If we want to handle this case as well, one of the changes would > > be it needs to cache multi records for one input parameter, or return > > one row each time but return mutli times for one

Re: doc review for v13

2020-04-26 Thread Justin Pryzby
On Tue, Apr 14, 2020 at 02:47:54PM +0900, Michael Paquier wrote: > On Sun, Apr 12, 2020 at 04:35:45PM -0500, Justin Pryzby wrote: > > Added a few more. > > And rebased on top of dbc60c5593f26dc777a3be032bff4fb4eab1ddd1 > > Thanks for the patch set, I have applied the most obvious parts (more > or

Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly

2020-04-26 Thread Justin Pryzby
On Sat, Apr 11, 2020 at 08:33:52PM -0500, Justin Pryzby wrote: > > That's the last known issue with the patch. I doubt anyone will elect to > > pick > > it up in the next 8 hours, but I think it's in very good shape for v14 :) > > I tweaked some comments and docs and plan to mark this RfC. Reba

Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays

2020-04-26 Thread James Coleman
On Sat, Apr 25, 2020 at 8:31 PM Tomas Vondra wrote: > > On Sat, Apr 25, 2020 at 06:47:41PM -0400, James Coleman wrote: > >On Sat, Apr 25, 2020 at 5:41 PM David Rowley wrote: > >> > >> On Sun, 26 Apr 2020 at 00:40, Tomas Vondra > >> wrote: > >> > This reminds me our attempts to add bloom filters

Re: Poll: are people okay with function/operator table redesign?

2020-04-26 Thread Jonathan S. Katz
On 4/26/20 1:40 PM, Tom Lane wrote: > I wrote: >> Alvaro Herrera writes: > There is a small problem with getting this to work in the webstyle > HTML: somebody decided it would be a great idea to have a global > override on paragraph margin-bottom settings. For the purposes of > this test I just

Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays

2020-04-26 Thread Tomas Vondra
On Sun, Apr 26, 2020 at 02:46:19PM -0400, James Coleman wrote: On Sat, Apr 25, 2020 at 8:31 PM Tomas Vondra wrote: On Sat, Apr 25, 2020 at 06:47:41PM -0400, James Coleman wrote: >On Sat, Apr 25, 2020 at 5:41 PM David Rowley wrote: >> >> On Sun, 26 Apr 2020 at 00:40, Tomas Vondra wrote: >> >

Re: Setting min/max TLS protocol in clientside libpq

2020-04-26 Thread Daniel Gustafsson
> On 26 Apr 2020, at 14:01, Peter Eisentraut > wrote: > > On 2020-04-24 14:03, Daniel Gustafsson wrote: >>> On 24 Apr 2020, at 12:56, Peter Eisentraut >>> wrote: >>> >>> Can we reconsider whether we really want to name the new settings like >>> "sslminprotocolversion", or whether we could ad

Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays

2020-04-26 Thread James Coleman
On Sun, Apr 26, 2020 at 4:49 PM Tomas Vondra wrote: > > On Sun, Apr 26, 2020 at 02:46:19PM -0400, James Coleman wrote: > >On Sat, Apr 25, 2020 at 8:31 PM Tomas Vondra > > wrote: > >> > >> On Sat, Apr 25, 2020 at 06:47:41PM -0400, James Coleman wrote: > >> >On Sat, Apr 25, 2020 at 5:41 PM David Row

Re: doc review for v13

2020-04-26 Thread James Coleman
On Sun, Apr 26, 2020 at 12:13 PM Justin Pryzby wrote: > > On Tue, Apr 14, 2020 at 02:47:54PM +0900, Michael Paquier wrote: > > On Sun, Apr 12, 2020 at 04:35:45PM -0500, Justin Pryzby wrote: > > > Added a few more. > > > And rebased on top of dbc60c5593f26dc777a3be032bff4fb4eab1ddd1 > > > > Thanks

Re: doc review for v13

2020-04-26 Thread Tom Lane
James Coleman writes: > On Sun, Apr 26, 2020 at 12:13 PM Justin Pryzby wrote: >> I think my text is correct. This would *also* be correct: >> | If any CHECK constraint on the table being >> | attached is marked NO INHERIT, the command will >> fail; >> But not the hybrid: "If any OF

Re: Poll: are people okay with function/operator table redesign?

2020-04-26 Thread Jonathan S. Katz
On 4/26/20 3:21 PM, Jonathan S. Katz wrote: > On 4/26/20 1:40 PM, Tom Lane wrote: >> I wrote: >>> Alvaro Herrera writes: > >> There is a small problem with getting this to work in the webstyle >> HTML: somebody decided it would be a great idea to have a global >> override on paragraph margin-bott

Re: +(pg_lsn, int8) and -(pg_lsn, int8) operators

2020-04-26 Thread Kyotaro Horiguchi
At Fri, 24 Apr 2020 12:15:26 +0200, Jehan-Guillaume de Rorthais wrote in > On Fri, 24 Apr 2020 16:24:14 +0900 > Michael Paquier wrote: > > > On Thu, Apr 23, 2020 at 08:09:22AM -0400, Robert Haas wrote: > > > For anyone who missed it, this idea was popular on Twitter: > > > > > > https://twitt

Re: Poll: are people okay with function/operator table redesign?

2020-04-26 Thread Tom Lane
"Jonathan S. Katz" writes: > Can you try > #docContent p { > - margin-bottom: 1rem !important; > + margin-bottom: 1rem; > } > and see how it looks? In some desultory looking around, I couldn't find anyplace in the existing text that that changes at all. And it does make the revised table m

Re: proposal - plpgsql - all plpgsql auto variables should be constant

2020-04-26 Thread Kyotaro Horiguchi
At Fri, 24 Apr 2020 16:47:28 +0200, Pavel Stehule wrote in > pá 24. 4. 2020 v 16:07 odesílatel Tom Lane napsal: > > > Ashutosh Bapat writes: > > > On Fri, Apr 24, 2020 at 12:24 PM Pavel Stehule > > wrote: > > >> plpgsql generate lot of auto variables - FOUND, SQLERRM, cycle's > > control var

Re: WAL usage calculation patch

2020-04-26 Thread Amit Kapila
On Thu, Apr 23, 2020 at 2:35 PM Amit Kapila wrote: > > On Thu, Apr 23, 2020 at 12:16 PM Peter Eisentraut > wrote: > > > The internal symbol for the WAL record is > > XLOG_FPI and xlogdesc.c prints it as "FPI". > > > > That is just one way/reason we log the page. There are others as > well. I t

Binary search in ScalarArrayOpExpr for OR'd constant arrays

2020-04-26 Thread James Coleman
On Sun, Apr 26, 2020 at 7:41 PM James Coleman wrote: > > On Sun, Apr 26, 2020 at 4:49 PM Tomas Vondra > wrote: > > > > On Sun, Apr 26, 2020 at 02:46:19PM -0400, James Coleman wrote: > > >On Sat, Apr 25, 2020 at 8:31 PM Tomas Vondra > > > wrote: > > >> > > >> On Sat, Apr 25, 2020 at 06:47:41PM -04

Re: Why are wait events not reported even though it reads/writes a timeline history file?

2020-04-26 Thread Fujii Masao
On 2020/04/24 11:29, Masahiro Ikeda wrote: Hi, There are two unexpected codes for me about wait events for timeline history file. Please let me know your thoughts whether if we need to change. 1. readTimeLineHistory() function in timeline.c The readTimeLineHistory() reads a timeline histo

Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays

2020-04-26 Thread David Rowley
On Mon, 27 Apr 2020 at 15:12, James Coleman wrote: > While working on this I noticed that dynahash.c line 499 has this assertion: > > Assert(info->entrysize >= info->keysize); > > Do you by any chance know why the entry would need to be larger than the key? Larger or equal. They'd be equal if you

Re: proposal - plpgsql - all plpgsql auto variables should be constant

2020-04-26 Thread Pavel Stehule
po 27. 4. 2020 v 5:02 odesílatel Kyotaro Horiguchi napsal: > At Fri, 24 Apr 2020 16:47:28 +0200, Pavel Stehule > wrote in > > pá 24. 4. 2020 v 16:07 odesílatel Tom Lane napsal: > > > > > Ashutosh Bapat writes: > > > > On Fri, Apr 24, 2020 at 12:24 PM Pavel Stehule < > pavel.steh...@gmail.com>

Re: 2pc leaks fds

2020-04-26 Thread Kyotaro Horiguchi
At Fri, 24 Apr 2020 11:48:46 -0400, Alvaro Herrera wrote in > On 2020-Apr-24, Kyotaro Horiguchi wrote: > > > At Thu, 23 Apr 2020 19:16:03 -0400, Alvaro Herrera > > wrote in > > > > Here's a first attempt at that. The segment_open/close callbacks are > > > now given at XLogReaderAllocate ti

Re: Setting min/max TLS protocol in clientside libpq

2020-04-26 Thread Michael Paquier
On Sun, Apr 26, 2020 at 11:20:01PM +0200, Daniel Gustafsson wrote: > That was the preferred name by Michael too elsewhere in the thread, so went > ahead and made it so. Thanks Daniel. >> I would, however, prefer to also rename the internal symbols. > > Done in the attached v2. What you have her

Re: doc review for v13

2020-04-26 Thread Michael Paquier
On Sun, Apr 26, 2020 at 08:59:05PM -0400, Tom Lane wrote: > James Coleman writes: >> On Sun, Apr 26, 2020 at 12:13 PM Justin Pryzby wrote: >>> I think my text is correct. This would *also* be correct: >>> | If any CHECK constraint on the table being >>> | attached is marked NO INHERI

Re: WAL usage calculation patch

2020-04-26 Thread Michael Paquier
On Mon, Apr 27, 2020 at 08:35:51AM +0530, Amit Kapila wrote: > On Thu, Apr 23, 2020 at 2:35 PM Amit Kapila wrote: >> On Thu, Apr 23, 2020 at 12:16 PM Peter Eisentraut >> wrote: >>> The internal symbol for the WAL record is >>> XLOG_FPI and xlogdesc.c prints it as "FPI". > > Julien, Peter, othe

Re: Fix compilation failure against LLVM 11

2020-04-26 Thread Michael Paquier
On Sat, Apr 25, 2020 at 09:41:20PM -0700, Jesse Zhang wrote: > I searched my inbox and the archive, strange that nobody else is seeing > this. > > Turns out that LLVM has recently removed "llvm/IR/CallSite.h" in > (unreleased) version 11 [1][2]. To fix the build I tried conditionally > (on LLVM_VE