On Fri, Feb 28, 2020 at 11:35 PM Tom Lane wrote:
> Richard Guo writes:
> > On Fri, Feb 28, 2020 at 3:02 PM Andy Fan
> wrote:
> >> Glad to see this. I think the hard part is this transform is not
> *always*
> >> good. for example foo.a only has 1 rows, but bar has a lot of rows, if
> >> so th
On 2020/02/26 23:18, Fujii Masao wrote:
On 2020/02/18 21:31, Fujii Masao wrote:
On 2020/02/18 16:53, Amit Langote wrote:
On Tue, Feb 18, 2020 at 4:42 PM Fujii Masao wrote:
On 2020/02/18 16:02, Amit Langote wrote:
I noticed that there is missing tag in the documentation changes:
Coul
On Sun, Mar 1, 2020 at 3:55 PM legrand legrand
wrote:
>
> >> I like the idea of adding a check for a non-zero queryId in the new
> >> pgss_planner_hook() (zero queryid shouldn't be reserved for
> >> utility_statements ?).
>
> > Some assert hit later, I can say that it's not always true. For
> > i
On Mon, Mar 2, 2020 at 7:48 AM Michael Paquier wrote:
>
> On top of that, and that's a separate issue, I have noticed that we
> have exactly zero documentation about PG_COLORS (the plural flavor,
> not the singular), but we have code for it in common/logging.c..
>
Yeah, there is nothing about i
On Sun, Mar 1, 2020 at 11:25 PM Tom Lane wrote:
>
> > Barring objections, this seems
> > committable to me.
>
> Going once, going twice ...
>
You have moved this to better place, so none from me, and thank you.
Regards,
Juan José Santamaría Flecha
On Mon, Mar 2, 2020 at 1:27 PM Peter Eisentraut
wrote:
>
> On 2019-10-26 10:36, vignesh C wrote:
> > One of the function apply_typmod in numeric.c file present within #if 0.
> > This is like this for many years.
> > I felt this can be removed.
> > Attached patch contains the changes to handle remo
Hello
I reviewed a recently published patch. Looks good for me.
One small note: the values for the new definitions in progress.h seems not to
be aligned vertically. However, pgindent doesn't objects.
regards, Sergei
On Mon, Mar 2, 2020 at 9:39 AM Amit Langote wrote:
>
>
> > My (very limited) understanding is that partition
> > "constraints" are entirely contained within pg_class.relpartbound of the
> > partition.
>
> That is correct.
>
> > Are you suggesting that the table name go into the constraint name fie
On Mon, Mar 2, 2020 at 9:01 AM Dilip Kumar wrote:
>
> On Sat, Nov 9, 2019 at 7:29 AM Euler Taveira wrote:
> >
> > Em seg., 21 de out. de 2019 às 21:20, Jeff Janes
> > escreveu:
> > >
> > > After setting up logical replication of a slowly changing table using the
> > > built in pub/sub facility,
On 2020/02/28 12:13, Kyotaro Horiguchi wrote:
At Thu, 27 Feb 2020 20:04:41 +0900, Fujii Masao
wrote in
On 2020/02/27 17:05, Kyotaro Horiguchi wrote:
Thank you for the comment.
At Thu, 27 Feb 2020 16:23:44 +0900, Fujii Masao
wrote in
On 2020/02/27 15:23, Kyotaro Horiguchi wrote:
I fail
The patch to improve color support on Windows has been commited [1], and I
would like to share some of the discussion there that might affect this
patch.
- The documentation/comments could make a better job of explaining the case
of PG_COLOR equals 'always', explicitly saying that no checks are do
Julien Rouhaud wrote
> On Sun, Mar 1, 2020 at 3:55 PM legrand legrand
> <
> legrand_legrand@
> > wrote:
>>
>> >> I like the idea of adding a check for a non-zero queryId in the new
>> >> pgss_planner_hook() (zero queryid shouldn't be reserved for
>> >> utility_statements ?).
>>
>> > Some assert h
On Mon, Mar 2, 2020 at 1:01 PM legrand legrand
wrote:
>
> Julien Rouhaud wrote
> > On Sun, Mar 1, 2020 at 3:55 PM legrand legrand
> > <
>
> > legrand_legrand@
>
> > > wrote:
> >>
> >> >> I like the idea of adding a check for a non-zero queryId in the new
> >> >> pgss_planner_hook() (zero queryid s
Fujita-san,
> Unfortunately, I didn't have time to work on that (and won't in the
> development cycle for PG13.)
>
> > Indeed, it is not an ideal query plan to execute for each updated rows...
> >
> > postgres=# explain select * from rtable_parent where tableoid = 126397
> > and ctid = '(0,11)'::t
> On 11 Feb 2020, at 17:54, Alvaro Herrera wrote:
>
> On 2019-Dec-06, Joe Nelson wrote:
>
>> I see this patch has been moved to the next commitfest. What's the next
>> step, does it need another review?
>
> This patch doesn't currently apply; it has conflicts with at least
> 01368e5d9da7 and 7e
Here is the v2 of the same patch after rebasing it and running it through
pgindent. There are no other code changes.
On Wed, Feb 19, 2020 at 8:04 PM Hamid Akhtar wrote:
> All,
>
> Attached is version 1 of POC patch for notifying of orphaned
> prepared transactions via warnings emitted to a clie
On 2020/02/29 0:46, Hamid Akhtar wrote:
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
First of all, this seems like fi
Starting with Python 3.9, the Python headers contain inline functions
that fall afoul of our -Wdeclaration-after-statement coding style. In
order to silence those warnings, I've added some GCC-specific
contortions to disable that warning for Python.h only. Clang doesn't
appear to warn about t
Hi Alexander,
On 1/21/20 5:37 PM, Alvaro Herrera wrote:
On 2020-Jan-21, Alvaro Herrera wrote:
c) it would be damn handy if \dAf (maybe \dAf+) lists the datatypes that
each opfamily has opclasses for. Maybe make the output an array, like
{int4,int8,numeric,...} Something like [*] but
On 1/30/20 6:54 AM, Amit Kapila wrote:
On Wed, Jan 29, 2020 at 9:10 PM Peter Eisentraut
wrote:
On 2020-01-20 06:30, Justin Pryzby wrote:
Rebased against 40d964ec997f64227bc0ff5e058dc4a5770a70a9
I'm not sure that description of parallel vacuum in the middle of
non-full vs. full vacuum is act
On Tue, 2020-01-07 at 19:05 +0100, Tomas Vondra wrote:
> This patch is currently in "needs review" state, but that seems quite
> wrong - there's been a lot of discussions about how we might improve
> behavior for append-only-tables, but IMO there's no clear consensus nor
> a patch that we might rev
Hi Dilip,
On 2/18/20 7:30 PM, David Zhang wrote:
After manually applied the patch, a diff regenerated is attached.
David's updated patch applies but all logical decoding regression tests
are failing on cfbot.
Do you know when you will be able to supply an updated patch?
Regards,
--
-David
On 2/27/20 9:43 AM, 曾文旌(义从) wrote:
_-- Scenario 2:_
Here I am getting the same error message in both the below cases.
We may add a "global" keyword with GTT related error message.
postgres=# create global temporary table gtt1 (c1 int unique);
CREATE TABLE
postgres=# create temporary table tmp1 (
On Sat, Feb 29, 2020 at 9:51 PM Mike Palmiotto
wrote:
>
> On Sat, Nov 30, 2019 at 9:15 PM Michael Paquier wrote:
> >
> > On Thu, Oct 03, 2019 at 11:39:37AM -0700, Andres Freund wrote:
> > > Color me unconvinced.
> >
> > The latest comments of the thread have not been addressed yet. so I am
> > ma
On Fri, Feb 21, 2020 at 8:15 PM Palamadai, Eka wrote:
Please, do not top post on this list.
Thanks a lot for the feedback. Please let me know if you have any further
> comments. Meanwhile, I have also added this patch to "Commitfest 2020-03"
> at https://commitfest.postgresql.org/27/2464.
>
App
On 2020-Feb-29, Mark Dilger wrote:
> You may want to think about the embedding of InvalidOid into the EndCommand
> output differently from how you think about the embedding of the rowcount
> into the EndCommand output, but my preference is to treat these issues the
> same and make a strong dist
> On Mar 2, 2020, at 8:12 AM, Alvaro Herrera wrote:
>
> On 2020-Feb-29, Mark Dilger wrote:
>
>> You may want to think about the embedding of InvalidOid into the EndCommand
>> output differently from how you think about the embedding of the rowcount
>> into the EndCommand output, but my pref
On 2020-Mar-02, Mark Dilger wrote:
> > I don't
> > understand your point of pg_stats_sql having to deal with this in a
> > particular way. How is that patch obtaining the command tags? I would
> > hope it calls GetCommandTagName() rather than call CommandEnd, but maybe
> > I misunderstand where
Here's the patch I propose for commit. I also rewrote the commit
message.
There are further refinements that can be done, but they don't need to
be in the first patch. Notably, the event trigger code can surely do a
lot better now by translating the tag list to a bitmapset earlier.
--
Álvaro H
On 2020-Mar-02, Alvaro Herrera wrote:
> Here's the patch I propose for commit. I also rewrote the commit
> message.
BTW I wonder if we should really change the definition of
EventTriggerData. ISTM that it would be sensible to keep it the same
for now ...
--
Álvaro Herrerahttps
> On Mar 2, 2020, at 9:08 AM, Alvaro Herrera wrote:
>
> On 2020-Mar-02, Alvaro Herrera wrote:
>
>> Here's the patch I propose for commit. I also rewrote the commit
>> message.
>
> BTW I wonder if we should really change the definition of
> EventTriggerData. ISTM that it would be sensible t
Thank you Tom for the review!
On Mon, Mar 2, 2020 at 4:46 AM Tom Lane wrote:
> Andy Fan writes:
> > Please see if you have any comments. Thanks
>
> The cfbot isn't at all happy with this. Its linux build is complaining
> about a possibly-uninitialized variable, and then giving up:
>
> https:
On 2020-03-02 07:53, Michael Paquier wrote:
+ * For fixed-size files, the caller may pass the expected size as an
+ * additional crosscheck on successful recovery. If the file size is
not
+ * known, set expectedSize = 0.
+ */
+int
+RestoreArchivedWALFile(const char *path, const char *xlogfn
Hi
I found a document bug about client authentication using TLS certificate. When
clientcert authentication is enabled in pg_hba.conf, libpq does not verify that
the common name in certificate matches database username like it is described
in the documentation before allowing client connectio
I started to look at this patch with fresh eyes after reading the patch
for adding binary I/O for ltree,
https://www.postgresql.org/message-id/flat/CANmj9Vxx50jOo1L7iSRxd142NyTz6Bdcgg7u9P3Z8o0=hgk...@mail.gmail.com
and realizing that the only reasonable way to tackle that problem is to
provide an
On Tue, Mar 3, 2020 at 1:24 AM Andy Fan wrote:
> Thank you Tom for the review!
>
> On Mon, Mar 2, 2020 at 4:46 AM Tom Lane wrote:
>
>> Andy Fan writes:
>> > Please see if you have any comments. Thanks
>>
>> The cfbot isn't at all happy with this. Its linux build is complaining
>> about a pos
Hi David,
On Wed, Feb 26, 2020 at 9:56 PM David Fetter wrote:
>
> On Wed, Feb 26, 2020 at 09:12:24AM +0100, David Fetter wrote:
> > On Fri, Jan 31, 2020 at 04:59:18PM +0100, David Fetter wrote:
> > > On Wed, Jan 15, 2020 at 03:45:12PM -0800, Jesse Zhang wrote:
> > > > On Tue, Jan 14, 2020 at 2:09
On Tue, Dec 3, 2019 at 3:00 AM Alexander Korotkov
wrote:
> On Mon, Sep 9, 2019 at 11:28 PM Alexander Korotkov
> wrote:
> > On Sun, Sep 8, 2019 at 11:35 PM Alexander Korotkov
> > wrote:
> > > I'm going to push 0001 changing "attno >= 1" to assert.
> >
> > Pushed. Rebased patchset is attached. I
On 2020-Mar-02, Mark Dilger wrote:
> I think it is more natural to change event trigger code to reason
> natively about CommandTags rather than continuing to reason about
> strings. The conversion back-and-forth between the enum and the
> string representation serves no useful purpose that I can
On Mon, Mar 02, 2020 at 02:11:10PM -0500, Tom Lane wrote:
I started to look at this patch with fresh eyes after reading the patch
for adding binary I/O for ltree,
https://www.postgresql.org/message-id/flat/CANmj9Vxx50jOo1L7iSRxd142NyTz6Bdcgg7u9P3Z8o0=hgk...@mail.gmail.com
and realizing that the
> On Mar 2, 2020, at 1:57 PM, Alvaro Herrera wrote:
>
> On 2020-Mar-02, Mark Dilger wrote:
>
>> I think it is more natural to change event trigger code to reason
>> natively about CommandTags rather than continuing to reason about
>> strings. The conversion back-and-forth between the enum an
While looking at Tomas' ALTER TYPE patch, I got annoyed by the fact
that all of the backend writes constants of type alignment and type
storage values as literal characters, such as 'i' and 'x'. This is
not our style for most other "poor man's enum" catalog columns, and
it makes it really hard to
On 2020-03-02 23:33, Nikita Glukhov wrote:
Attached 42th version of the patches.
v1-0001-Add-jsonpath-pg-modifier-for-enabling-extensions.patch
v1-0002-Add-raw-jbvArray-and-jbvObject-support-to-jsonpat.patch
v1-0003-Add-jsonpath-sequence-constructors.patch
v1-0004-Add-jsonpath-array-constructo
Hi,
On 2020-03-01 00:36:01 -0800, Andres Freund wrote:
> Here are some numbers for the submitted patch series. I'd to cull some
> further improvements to make it more manageable, but I think the numbers
> still are quite convincing.
>
> The workload is a pgbench readonly, with pgbench -M prepared
Hi Masahiko
Please see below my comments regarding kms_v4.patch that you have shared
earlier.
(1)
There is a discrepancy between the documentation and the actual function
definition. For example in func.sgml, it states pg_wrap_key takes argument in
text data type but in pg_proc.dat and kmgr.c,
Hi Alexander,
Apologies for the delayed response. I was a little tired from the
deduplication project.
On Mon, Feb 24, 2020 at 2:54 PM Alexander Korotkov
wrote:
> Thank you for your review. The revised version is attached.
This has bitrot, because of the deduplication patch. Shouldn't be hard
Dear Dean,
On 2020-03-01 20:47, Dean Rasheed wrote:
On Fri, 28 Feb 2020 at 08:15, Dean Rasheed
wrote:
It's possible that there are further gains to be had in the sqrt()
algorithm on platforms that support 128-bit integers, but I haven't
had a chance to investigate that yet.
Rebased patch a
At Mon, 2 Mar 2020 17:29:30 +0900, Fujii Masao
wrote in
> > Attached is the updated version of the patch.
> > The previous patch used only pgstat_progress_update_param()
> > even when updating multiple values. Since those updates are
> > not atomic, this can cause readers of the values to see
>
On Mon, Mar 02, 2020 at 12:28:18PM +0900, Michael Paquier wrote:
> This test should check after indisclustered. Except that, the patch
> is fine so I'll apply it if there are no objections.
I got a second look at this one, and applied it down to 12 after some
small modifications in the new test a
On Sun, Mar 1, 2020 at 12:15 PM Floris Van Nee wrote:
> Minor conflict with that patch indeed. Attached is rebased version. I'm
> running some tests now - will post the results here when finished.
Thanks.
We're going to have to go back to my original approach to inlining. At
least, it seemed to
On Mon, Mar 02, 2020 at 12:28:18PM +0900, Michael Paquier wrote:
> > +SELECT indexrelid::regclass FROM pg_index WHERE
> > indrelid='concur_clustered'::regclass;
>
> This test should check after indisclustered. Except that, the patch
> is fine so I'll apply it if there are no objections.
Oops -
On 2020-Mar-02, Tom Lane wrote:
> While looking at Tomas' ALTER TYPE patch, I got annoyed by the fact
> that all of the backend writes constants of type alignment and type
> storage values as literal characters, such as 'i' and 'x'. This is
> not our style for most other "poor man's enum" catalog
@cfbot: resending with only Amit's 0001, since Michael pushed a variation on
0002.
--
Justin
>From 865fc2713ad29d0f8c0f63609a7c15c83cfa5cfe Mon Sep 17 00:00:00 2001
From: Amit Langote
Date: Thu, 6 Feb 2020 18:14:16 +0900
Subject: [PATCH v5] ALTER tbl rewrite loses CLUSTER ON index
---
src/back
On 2020-03-03 00:24, Nikita Glukhov wrote:
On 03.03.2020 2:12, Erik Rijkers wrote:
On 2020-03-02 23:33, Nikita Glukhov wrote:
Attached 42th version of the patches.
20200302/0001-Jsonpath-support-for-json-v42.patch +
20200302/0002-Add-common-SQL_JSON-clauses-v42.patch+
20200302/0003-Add
On Fri, Feb 28, 2020 at 12:38:55PM -0800, Jeff Davis wrote:
> On Fri, 2020-02-28 at 14:16 +0800, Adam Lee wrote:
> > I noticed another difference, I was using palloc0(), which could be
> > one of the
> > reason, but not sure.
>
> I changed the palloc0()'s in your code to plain palloc(), and it did
On 2020/03/02 19:27, Sergei Kornilov wrote:
Hello
I reviewed a recently published patch. Looks good for me.
Thanks for the review! I pushed the patch.
One small note: the values for the new definitions in progress.h seems not to
be aligned vertically. However, pgindent doesn't objects.
On 2020/03/03 9:27, Kyotaro Horiguchi wrote:
At Mon, 2 Mar 2020 17:29:30 +0900, Fujii Masao
wrote in
Attached is the updated version of the patch.
The previous patch used only pgstat_progress_update_param()
even when updating multiple values. Since those updates are
not atomic, this can cau
On Mon, Mar 2, 2020 at 7:27 PM David Steele wrote:
>
> Hi Dilip,
>
> On 2/18/20 7:30 PM, David Zhang wrote:
> > After manually applied the patch, a diff regenerated is attached.
>
> David's updated patch applies but all logical decoding regression tests
> are failing on cfbot.
>
> Do you know when
Alvaro Herrera writes:
> On 2020-Mar-02, Tom Lane wrote:
>> One thing that I'm not totally happy about, as this stands, is that
>> we have to #include "catalog/pg_type.h" in various places we did
>> not need to before (although only a fraction of the files I touched
>> need that).
> If we think t
Hi, Cary.
On 3/2/20 1:06 PM, Cary Huang wrote:
Hi
I found a document bug about client authentication using TLS
certificate. When clientcert authentication is enabled in pg_hba.conf,
libpq does not verify that the *common name*in certificate
matches*database username*like it is described in t
On 2020/02/19 5:26, David Zhang wrote:
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation:tested, passed
The issue has been verified u
On Mon, Mar 2, 2020 at 4:56 PM Amit Kapila wrote:
>
> On Mon, Mar 2, 2020 at 9:01 AM Dilip Kumar wrote:
> >
> > On Sat, Nov 9, 2019 at 7:29 AM Euler Taveira wrote:
> > >
> > > Em seg., 21 de out. de 2019 às 21:20, Jeff Janes
> > > escreveu:
> > > >
> > > > After setting up logical replication o
On 3/1/20 10:09 PM, Amit Langote wrote:
Hi Chris,
On Mon, Mar 2, 2020 at 8:51 AM Chris Bandy wrote:
On 3/1/20 5:14 AM, Amit Kapila wrote:
On Sun, Mar 1, 2020 at 10:10 AM Amit Langote wrote:
There are couple more instances in src/backend/command/tablecmds.c
where partition constraint is che
On Tue, Mar 3, 2020 at 8:42 AM Dilip Kumar wrote:
>
> On Mon, Mar 2, 2020 at 7:27 PM David Steele wrote:
> >
> > Hi Dilip,
> >
> > On 2/18/20 7:30 PM, David Zhang wrote:
> > > After manually applied the patch, a diff regenerated is attached.
> >
> > David's updated patch applies but all logical d
On Wed, Feb 19, 2020 at 6:00 AM David Zhang wrote:
>
> After manually applied the patch, a diff regenerated is attached.
>
> On 2020-02-18 4:16 p.m., David Zhang wrote:
> > 1. Tried to apply the patch to PG 12.2 commit
> > 45b88269a353ad93744772791feb6d01bc7e1e42 (HEAD -> REL_12_2, tag: REL_12_2)
On Mon, Mar 02, 2020 at 01:00:44PM +0100, Juan José Santamaría Flecha wrote:
> - The new entry in the documentation, specially as the PG_COLORS parameter
> seems to be currently undocumented. The programs that can use PG_COLOR
> would benefit from getting a link to it.
The actual problem here is t
Hi,
Thank you for developing good features.
The attached patch is a small fix to the committed documentation. This patch
fixes the description literal for the backup_streamed column.
Regards,
Noriyoshi Shinoda
-Original Message-
From: Fujii Masao [mailto:masao.fu...@oss.nttdata.com]
S
On Wed, Feb 26, 2020 at 4:24 PM Amit Kapila wrote:
>
> On Tue, Feb 25, 2020 at 9:30 PM Tomas Vondra
> wrote:
> >
> > On Sun, Feb 23, 2020 at 05:09:51PM -0800, Andres Freund wrote:
> > >Hi,
> > >
> > >> The one piece of information I'm missing here is at least a very
rough
> > >> quantification of
On 2020/03/03 14:37, Shinoda, Noriyoshi (PN Japan A&PS Delivery) wrote:
Hi,
Thank you for developing good features.
The attached patch is a small fix to the committed documentation. This patch
fixes the description literal for the backup_streamed column.
Thanks for the report and patch! Pu
On Wed, Feb 26, 2020 at 8:47 PM Ants Aasma wrote:
>
> On Tue, 25 Feb 2020 at 18:00, Tomas Vondra
wrote:
> > Perhaps. I guess it'll depend on the CSV file (number of fields, ...),
> > so I still think we need to do some measurements first. I'm willing to
> > do that, but (a) I doubt I'll have time
70 matches
Mail list logo
