Re: [HACKERS] Block level parallel vacuum

2019-10-05 Thread Dilip Kumar
On Fri, Oct 4, 2019 at 3:35 PM Dilip Kumar wrote: > > On Fri, Oct 4, 2019 at 11:01 AM Amit Kapila wrote: > > > > On Fri, Oct 4, 2019 at 10:28 AM Masahiko Sawada > > wrote: > >> > Some more comments.. > 1. > + for (idx = 0; idx < nindexes; idx++) > + { > + if (!for_cleanup) > + lazy_vacuum_index

Re: The flinfo->fn_extra question, from me this time.

2019-10-05 Thread Dent John
On 22 Sep 2019, at 16:01, Tom Lane wrote:Hi Tom,I don't know of anybody working on it.Okay. I had a look at this. I tried to apply Andre’s patch [1] from some time ago, but that turned out not so easy. I guess the code has moved on since. So I’ve attempted to re-invent the same

Re: [HACKERS] Block level parallel vacuum

2019-10-05 Thread Amit Kapila
On Fri, Oct 4, 2019 at 7:57 PM Masahiko Sawada wrote: > On Fri, Oct 4, 2019 at 2:31 PM Amit Kapila > wrote: > >> > > > > Do we really need to log all those messages? The other places where we > launch parallel workers doesn't seem to be using such messages. Why do you > think it is important t

Non-null values of recovery functions after promote or crash of primary

2019-10-05 Thread Martín Marqués
Hi, Yesterday we (that's me and my colleague Ricardo Gomez) were working on an issue where a monitoring script was returning increasing lag information on a primary instead of a NULL value. The query used involved the following functions (the function was amended to work-around the issue I'm repo

Re: [PATCH] Do not use StdRdOptions in Access Methods

2019-10-05 Thread Nikolay Shaplov
В Fri, 27 Sep 2019 17:24:49 +0900 Michael Paquier пишет: > > Looks like some good actionable feedback. I've moved this patch to > > September, and set it to "Waiting on Author". > > The patch is in this state for two months now, so I have switched it > to "returned with feedback". The latest pa

Re: [HACKERS] Deadlock in XLogInsert at AIX

2019-10-05 Thread Noah Misch
On Sat, Aug 31, 2019 at 03:30:26PM -0700, Noah Misch wrote: > On Sat, Aug 31, 2019 at 02:27:55PM -0400, Tom Lane wrote: > > Noah Misch writes: > > > Done. fetch-add-variable-test-v1.patch just adds tests for non-constant > > > addends and 16-bit edge cases. Today's implementation handles those,

expressive test macros (was: Report test_atomic_ops() failures consistently, via macros)

2019-10-05 Thread Andres Freund
Hi, On 2019-10-05 17:08:38 +, Noah Misch wrote: > Report test_atomic_ops() failures consistently, via macros. > > This prints the unexpected value in more failure cases, and it removes > forty-eight hand-maintained error messages. Back-patch to 9.5, which > introduced these tests. Thanks fo

Re: Transparent Data Encryption (TDE) and encrypted files

2019-10-05 Thread Tomas Vondra
On Fri, Oct 04, 2019 at 08:14:44PM -0400, Bruce Momjian wrote: On Sat, Oct 5, 2019 at 12:54:35AM +0200, Tomas Vondra wrote: On Fri, Oct 04, 2019 at 06:06:10PM -0400, Bruce Momjian wrote: > For full-cluster TDE with AES-NI-enabled, the performance impact is > usually ~4%, so doing anything more

Re: How to install login_hook in Postgres 10.5

2019-10-05 Thread legrand legrand
pavan95 wrote > Hello Community, > > While I was searching for logon trigger in postgres similar to that of > Oracle, I came across "login_hook", which can be installed as a Postgres > database extension to mimic a logon trigger. > > But I tried to install but failed. Error is that it could not

[PATCH] Add some useful asserts into View Options macroses

2019-10-05 Thread Nikolay Shaplov
This thread is a follow up to the thread https://www.postgresql.org/message-id/2620882.s52SJui4ql@x200m where I've been trying to remove StdRdOptions structure and replace it with unique structure for each relation kind. I've decided to split that patch into smaller parts. This part adds some

Re: New "-b slim" option in 2019b zic: should we turn that on?

2019-10-05 Thread Andrew Dunstan
On 7/17/19 6:42 PM, Tom Lane wrote: > > Despite the marginal payoff, I'm strongly tempted to enable this > switch. The only reason I can think of not to do it is if somebody > is using a Postgres installation's share/timezone tree as tzdata > for some other program with not-up-to-date timezone l

Re: New "-b slim" option in 2019b zic: should we turn that on?

2019-10-05 Thread Tom Lane
Andrew Dunstan writes: > I've just run into an issue with this (commit a1207910968). The makefile > now assumes that zic has this switch. But I was attempting to get around > an issue on msys2 by using its zic, (ZIC=/usr/bin/zic configure ...). It > crashes on the floor because it doesn't know abo

Re: expressive test macros (was: Report test_atomic_ops() failures consistently, via macros)

2019-10-05 Thread Noah Misch
On Sat, Oct 05, 2019 at 12:07:29PM -0700, Andres Freund wrote: > +#define EXPECT_EQ_U32(result_expr, expected_expr) \ > + do { \ > + uint32 result = (result_expr); \ > + uint32 expected = (expected_expr); \ > + if (result != expected) \ > + elog(ERROR, \ > +

Re: New "-b slim" option in 2019b zic: should we turn that on?

2019-10-05 Thread Andrew Dunstan
On 10/5/19 6:33 PM, Tom Lane wrote: > Andrew Dunstan writes: >> I've just run into an issue with this (commit a1207910968). The makefile >> now assumes that zic has this switch. But I was attempting to get around >> an issue on msys2 by using its zic, (ZIC=/usr/bin/zic configure ...). It >> cras

Re: New "-b slim" option in 2019b zic: should we turn that on?

2019-10-05 Thread Tom Lane
Andrew Dunstan writes: > On 10/5/19 6:33 PM, Tom Lane wrote: >> I had contemplated injecting the -b switch via >> -ZIC_OPTIONS = >> +ZIC_OPTIONS = -b slim > I don't think that's going to work very well with a buildfarm member, > where there's no convenient way to set it. Can't you set that from

Non-Active links being referred in our source code

2019-10-05 Thread vignesh C
Hi, There are few links present in our source files for which the web links are no more active. Details for the same is given below: Sl No Link Referred File 1 http://h21007.www2.hp.com/portal/download/files/unprot/Itanium/inline_assem_ERS.pdf