Re: Batch insert in CTAS/MatView code

2019-09-26 Thread Paul Guo
On Thu, Sep 26, 2019 at 9:43 PM Alvaro Herrera wrote: > On 2019-Sep-25, Asim R P wrote: > > > I reviewed your patch today. It looks good overall. My concern is that > > the ExecFetchSlotHeapTuple call does not seem appropriate. In a generic > > place such as createas.c, we should be using gene

Re: Hooks for session start and end, take two

2019-09-26 Thread Michael Paquier
On Thu, Sep 26, 2019 at 09:57:57AM -0700, legrand legrand wrote: > Does that mean that all processes seen in pg_stat_activity like > - autovacuum launcher > - logical replication launcher > - background writer > - checkpointer > - walwriter > ... > - Parallel worker > are available with that hook

Re: pg_wal/RECOVERYHISTORY file remains after archive recovery

2019-09-26 Thread Masahiko Sawada
On Thu, Sep 26, 2019 at 6:23 PM Fujii Masao wrote: > > On Thu, Sep 26, 2019 at 5:15 PM Masahiko Sawada wrote: > > > > Hi, > > > > When we do archive recovery from the database cluster of which > > timeline ID is more than 2 pg_wal/RECOVERYHISTORY is remained even > > after archive recovery comple

Re: Add comments for a postgres program in bootstrap mode

2019-09-26 Thread Amit Langote
On Fri, Sep 27, 2019 at 12:52 PM Youki Shiraishi wrote: > On Fri, Sep 27, 2019 at 12:10 AM Amit Langote wrote: > > On Thu, Sep 26, 2019 at 6:32 PM Youki Shiraishi > > wrote: > > > On Thu, Sep 26, 2019 at 5:38 PM Amit Langote > > > wrote: > > > > + /* Bootstrap mode for initdb */ > > > > if

Re: Add comments for a postgres program in bootstrap mode

2019-09-26 Thread Youki Shiraishi
Hello folks, On Fri, Sep 27, 2019 at 1:59 PM Amit Langote wrote: > > On Fri, Sep 27, 2019 at 12:52 PM Youki Shiraishi > wrote: > > On Fri, Sep 27, 2019 at 12:10 AM Amit Langote > > wrote: > > > On Thu, Sep 26, 2019 at 6:32 PM Youki Shiraishi > > > wrote: > > > > On Thu, Sep 26, 2019 at 5:38

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

2019-09-26 Thread Amit Kapila
On Fri, Sep 27, 2019 at 12:06 AM Tomas Vondra wrote: > > On Thu, Sep 26, 2019 at 06:58:17PM +0530, Amit Kapila wrote: > > >3. > >+ * Find the largest transaction (toplevel or subxact) to evict (spill to > >disk). > >+ * > >+ * XXX With many subtransactions this might be quite slow, because we'll

Re: PATCH: standby crashed when replay block which truncated in standby but failed to truncate in master node

2019-09-26 Thread Michael Paquier
On Thu, Sep 26, 2019 at 01:13:56AM +0900, Fujii Masao wrote: > On Tue, Sep 24, 2019 at 10:41 AM Michael Paquier wrote: >> This also points out that there are other things to worry about than >> interruptions, as for example DropRelFileNodeLocalBuffers() could lead >> to an ERROR, and this happens

<    1   2