Re: [HACKERS] Deadlock in XLogInsert at AIX

2019-08-31 Thread Noah Misch
On Wed, Jan 17, 2018 at 12:36:31AM -0800, Noah Misch wrote: > On Tue, Jan 16, 2018 at 08:50:24AM -0800, Andres Freund wrote: > > On 2018-01-16 16:12:11 +0900, Michael Paquier wrote: > > > On Fri, Feb 03, 2017 at 12:26:50AM +, Noah Misch wrote: > > > > Since this emits double syncs with older xl

Re: [HACKERS] Help required to debug pg_repack breaking logical replication

2019-08-31 Thread Oleksii Kliukin
Hello, Petr Jelinek wrote: > On 08/10/17 15:21, Craig Ringer wrote: >> On 8 October 2017 at 02:37, Daniele Varrazzo >> wrote: >>> Hello, >>> >>> we have been reported, and I have experienced a couple of times, >>> pg_repack breaking logical replication. >>> >>> - https://github.com/reorg/pg_

Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.

2019-08-31 Thread Peter Geoghegan
On Thu, Aug 29, 2019 at 10:10 PM Peter Geoghegan wrote: > I see some Valgrind errors on v9, all of which look like the following > two sample errors I go into below. I've found a fix for these Valgrind issues. It's a matter of making sure that _bt_truncate() sizes new pivot tuples properly, which

Re: range bug in resolve_generic_type?

2019-08-31 Thread Paul A Jungwirth
On Tue, Aug 27, 2019 at 8:52 AM Paul A Jungwirth wrote: > > On Tue, Aug 27, 2019 at 8:23 AM Tom Lane wrote: > > I seem to recall that we discussed this exact point during development > > of the range feature, and concluded that this was the behavior we > > wanted, ie, treat anyrange like a scalar

Re: [HACKERS] Deadlock in XLogInsert at AIX

2019-08-31 Thread Tom Lane
Noah Misch writes: > Done. fetch-add-variable-test-v1.patch just adds tests for non-constant > addends and 16-bit edge cases. Today's implementation handles those, > PostgreSQL doesn't use them, and I might easily have broken them. > fetch-add-xlc-asm-v1.patch moves xlc builds from the __fetch_a

Re: block-level incremental backup

2019-08-31 Thread Ibrar Ahmed
On Sat, Aug 31, 2019 at 7:59 AM Robert Haas wrote: > On Thu, Aug 29, 2019 at 10:41 AM Jeevan Ladhe > wrote: > > Due to the inherent nature of pg_basebackup, the incremental backup also > > allows taking backup in tar and compressed format. But, pg_combinebackup > > does not understand how to res

Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly

2019-08-31 Thread a . kondratov
Hi hackers, On 2018-12-27 04:57, Michael Paquier wrote: On Wed, Dec 26, 2018 at 03:19:06PM -0300, Alvaro Herrera wrote: As for REINDEX, I think it's valuable to move tablespace together with the reindexing. You can already do it with the CREATE INDEX CONCURRENTLY recipe we recommend, of course

SIGQUIT on archiver child processes maybe not such a hot idea?

2019-08-31 Thread Tom Lane
My buildfarm animal dromedary ran out of disk space yesterday, which I found rather surprising because the last time I'd looked it had tens of GB to spare. On investigation, the problem was lots and lots of core images in /cores, which is where macOS drops them (by default at least). It looked li

Re: [HACKERS] Deadlock in XLogInsert at AIX

2019-08-31 Thread Noah Misch
On Sat, Aug 31, 2019 at 02:27:55PM -0400, Tom Lane wrote: > Noah Misch writes: > > Done. fetch-add-variable-test-v1.patch just adds tests for non-constant > > addends and 16-bit edge cases. Today's implementation handles those, > > PostgreSQL doesn't use them, and I might easily have broken them

Re: row filtering for logical replication

2019-08-31 Thread Euler Taveira
Em dom, 3 de fev de 2019 às 07:14, Andres Freund escreveu: > > As far as I can tell, the patch has not been refreshed since. So I'm > marking this as returned with feedback for now. Please resubmit once > ready. > I fix all of the bugs pointed in this thread. I decide to disallow UDFs in filters (

Re: row filtering for logical replication

2019-08-31 Thread Euler Taveira
Em ter, 27 de ago de 2019 às 18:10, escreveu: > > Do you have any plans for continuing working on this patch and > submitting it again on the closest September commitfest? There are only > a few days left. Anyway, I will be glad to review the patch if you do > submit it, though I didn't yet dig de

Re: [DOC] Document auto vacuum interruption

2019-08-31 Thread Amit Kapila
On Fri, Jul 26, 2019 at 1:45 AM James Coleman wrote: > > We've discussed this internally many times, but today finally decided > to write up a doc patch. > Thanks, I think something on the lines of what you have written can help some users to understand the behavior in this area and there doesn't

Re: doc: update PL/pgSQL sample loop function

2019-08-31 Thread Amit Kapila
On Thu, Aug 29, 2019 at 10:07 AM Pavel Stehule wrote: > > Hi > > čt 29. 8. 2019 v 5:03 odesílatel Ian Barwick > napsal: >> >> Hi >> >> Here: >> >> >> https://www.postgresql.org/docs/current/plpgsql-control-structures.html#PLPGSQL-RECORDS-ITERATING >> >> we have a sample PL/PgSQL function (da

Re: refactoring - share str2*int64 functions

2019-08-31 Thread Michael Paquier
On Fri, Aug 30, 2019 at 04:50:21PM +0200, Fabien COELHO wrote: > Given the overheads of the SQL interpreter, I'm unsure about what you would > measure at the SQL level. You could just write a small standalone C program > to test perf and accuracy. Maybe this is what you have in mind. After a certa

Commit fest 2019-09

2019-08-31 Thread Michael Paquier
Hi all, Based on the current clock we are going to be the 1st of September anywhere on Earth in approximately 7 hours: https://www.timeanddate.com/time/zones/aoe Once this happens, I will switch the commit fest as in progress and it will not be possible to add any new patches. I am not sure if s

Re: row filtering for logical replication

2019-08-31 Thread Alexey Zagarin
I think that I also have found one shortcoming when using the setup described by Alexey Kondratov. The problem that I face is that if both (cloud and remote) tables already have data the moment I add the subscription, then the whole table is copied in both directions initially. Which leads to du

Re: Should we add xid_current() or a int8->xid cast?

2019-08-31 Thread Thomas Munro
On Fri, Aug 2, 2019 at 10:42 PM Thomas Munro wrote: > On Thu, Jul 25, 2019 at 1:11 PM Thomas Munro wrote: > > On Thu, Jul 25, 2019 at 12:42 PM Tom Lane wrote: > > > Andres Freund writes: > > > > On 2019-07-24 20:34:39 -0400, Tom Lane wrote: > > > >> Yeah, I would absolutely NOT recommend that y