Re: Add parallelism and glibc dependent only options to reindexdb

2019-07-11 Thread Julien Rouhaud
On Fri, Jul 12, 2019 at 3:20 AM Michael Paquier wrote: > > On Thu, Jul 11, 2019 at 06:22:25PM +0200, Julien Rouhaud wrote: > > I think t hat it makes the code quite cleaner to have the selection > > outside ConsumeIdleSlot. > > Actually, you have an issue with ConsumeIdleSlot() if there is only >

Re: Unknown type name bool

2019-07-11 Thread Igal Sapir
On Thu, Jul 11, 2019 at 10:27 PM Michael Paquier wrote: > On Thu, Jul 11, 2019 at 10:21:06PM -0700, Igal Sapir wrote: > > Any thoughts? (disclaimer: I have much more experience with Java than C) > > We don't support cmake directly. Here is the documentation about how > to build the beast: > htt

Re: Add parallelism and glibc dependent only options to reindexdb

2019-07-11 Thread Michael Paquier
On Fri, Jul 12, 2019 at 07:49:13AM +0200, Julien Rouhaud wrote: > It shouldn't be a problem, I reused the same infrastructure as for > vacuumdb. so run_reindex_command has a new "async" parameter, so when > there's no parallelism it's using executeMaintenanceCommand (instead > of PQsendQuery) whic

Re: [RFC] [PATCH] Flexible "partition pruning" hook

2019-07-11 Thread Kyotaro Horiguchi
Hello. I'm on Peter's side. Unlike other similar hooks, this hook is provided just to introduce arbitrary inconsistency in partition pruning. # By the way, InvokePartitionPruningHook seems useless if the # reason for it is to avoid duplicate if()'s . Adding check constraint on children works as

Re: Unknown type name bool

2019-07-11 Thread Gavin Flower
On 12/07/2019 17:54, Igal Sapir wrote: On Thu, Jul 11, 2019 at 10:27 PM Michael Paquier > wrote: On Thu, Jul 11, 2019 at 10:21:06PM -0700, Igal Sapir wrote: > Any thoughts?  (disclaimer: I have much more experience with Java than C) We don't support c

Re: Unknown type name bool

2019-07-11 Thread Michael Paquier
On Thu, Jul 11, 2019 at 10:54:53PM -0700, Igal Sapir wrote: > Thank you, Michael, but my goal is not to just build from source, but to > run Postgres in an IDE. I tried CLion because it's modern and cross > platform, but I am open to other IDEs. > > What IDEs do Postgres hackers use (other than vi

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-07-11 Thread Masahiko Sawada
Thank you for summarizing the discussion, it's really helpful. I'll update the wiki page based on the summary. On Fri, Jul 12, 2019 at 10:05 AM Bruce Momjian wrote: > > The keys themselves should be in an file which is encrypted by a master > > key. Obtaining the master key should be pattern it a

Re: Unknown type name bool

2019-07-11 Thread Igal Sapir
On Thu, Jul 11, 2019 at 11:14 PM Michael Paquier wrote: > On Thu, Jul 11, 2019 at 10:54:53PM -0700, Igal Sapir wrote: > > Thank you, Michael, but my goal is not to just build from source, but to > > run Postgres in an IDE. I tried CLion because it's modern and cross > > platform, but I am open t

Re: Comment fix of config_default.pl

2019-07-11 Thread Kyotaro Horiguchi
Thanks. At Fri, 12 Jul 2019 13:01:13 +0900, Michael Paquier wrote in <20190712040113.gd2...@paquier.xyz> > On Fri, Jul 12, 2019 at 12:15:29PM +0900, Kyotaro Horiguchi wrote: > > In src/tools/msvc/config_default.pl, parameter "perl" requires a > > path string, not a bool differently from that of

Check-out mutable functions in check constraints

2019-07-11 Thread Kyotaro Horiguchi
Hello. As mentioned in the following message: https://www.postgresql.org/message-id/20190712.150527.145133646.horikyota.ntt%40gmail.com Mutable function are allowed in check constraint expressions but it is not right. The attached is a proposed fix for it including regression test. Other "const

Re: Check-out mutable functions in check constraints

2019-07-11 Thread Pavel Stehule
Hi pá 12. 7. 2019 v 8:45 odesílatel Kyotaro Horiguchi napsal: > Hello. > > As mentioned in the following message: > > > https://www.postgresql.org/message-id/20190712.150527.145133646.horikyota.ntt%40gmail.com > > Mutable function are allowed in check constraint expressions but > it is not right

<    1   2