Re: Remove page-read callback from XLogReaderState.

2019-05-23 Thread Kyotaro HORIGUCHI
Thank you for looking this, Antonin. At Wed, 22 May 2019 13:53:23 +0200, Antonin Houska wrote in <25494.1558526...@spoje.net> > Kyotaro HORIGUCHI wrote: > > > Hello. Thank you for looking this. > > ... > > Yeah, I'll register this, maybe the week after next week. > > I've checked the new vers

Re: Should we warn against using too many partitions?

2019-05-23 Thread David Rowley
On Fri, 24 May 2019 at 14:04, Amit Langote wrote: > The latest patch on the thread linked from this CF entry (a modified > version of your patch sent by Justin Pryzby) looks good to me. Why not > post it on this thread and link this one to the CF entry? I'm not much of a fan of that patch: +

Re: Excessive memory usage in multi-statement queries w/ partitioning

2019-05-23 Thread Amit Langote
Hi, On 2019/05/23 4:15, Andreas Seltenreich wrote: > …but when doing it on the parent relation, even 100 statements are > enough to exceed the limit: > > , > | $ psql -c "$(yes update t set c=c where c=6 \; | head -n 100)" > | FEHLER: Speicher aufgebraucht > | DETAIL: Failed on request of s

Re: Should we warn against using too many partitions?

2019-05-23 Thread Amit Langote
On 2019/05/24 13:37, David Rowley wrote: > I've attached 3 patches of what I think should go into master, pg11, and pg10. Thanks for the updated patches. In pg11 and pg10 patches, I see this text: + Whether using table inheritance or native partitioning, hierarchies Maybe, it would better

Aggregate error message

2019-05-23 Thread Vik Fearing
With a sample query such as SELECT x, avg(x) FROM (VALUES (1), (2), (3)) AS v (x); We give the error message "column "v.x" must appear in the GROUP BY clause or be used in an aggregate function". This is correct but incomplete. Attached is a trivial patch to also suggest that the user might hav

<    1   2