Re: Bug in reindexdb's error reporting

2019-05-11 Thread Julien Rouhaud
On Sat, May 11, 2019 at 6:04 AM Michael Paquier wrote: > > On Fri, May 10, 2019 at 09:25:58PM -0400, Tom Lane wrote: > > Michael Paquier writes: > > > The refactoring bits are fine for HEAD. For back-branches I would > > > suggest using the simplest patch of upthread. > > > > Makes sense to me t

Re: Bug in reindexdb's error reporting

2019-05-11 Thread Michael Paquier
On Sat, May 11, 2019 at 10:28:43AM +0200, Julien Rouhaud wrote: > I attach the switch refactoring that applies on top of current HEAD, > and the reindex_system_catalogs() removal in a different patch in case > that's too much during feature freeze. Both Look fine to me at quick glance, but I have

Re: pg12 release notes

2019-05-11 Thread Bruce Momjian
On Sat, May 11, 2019 at 03:06:40AM +0100, Andrew Gierth wrote: > > "Bruce" == Bruce Momjian writes: > Bruce> Do I need more? > > That isn't quite how I'd have worded it, but I'm not sure what the best > wording is. Something like: > > * Output REAL and DOUBLE PRECISION values in shortest-e

Re: pg12 release notes

2019-05-11 Thread Bruce Momjian
On Fri, May 10, 2019 at 07:31:21PM -0700, Peter Geoghegan wrote: > On Fri, May 10, 2019 at 7:11 PM Bruce Momjian wrote: > > > Whether or not you include more details is not what I care about here > > > -- I *agree* that this is insignificant. > > > Well, we can move the entire item up to the inc

Re: pg12 release notes

2019-05-11 Thread Bruce Momjian
On Sat, May 11, 2019 at 10:36:13AM -0400, Bruce Momjian wrote: > On Fri, May 10, 2019 at 07:31:21PM -0700, Peter Geoghegan wrote: > > > I think I have understood the nuances, as listed above --- I just don't > > > agree with the solution. > > > > To be clear, I don't expect you to agree with the s

Re: Index Skip Scan

2019-05-11 Thread Dmitry Dolgov
> On Thu, Mar 28, 2019 at 11:01 AM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > Rebase after refactoring of nbtree insertion scankeys. But so far it's purely > mechanical, just to make it work - I guess I'll need to try to rewrite some > parts of the patch, that don't look natural now, accordin

Hello

2019-05-11 Thread Bhuvan Singla
Hello! Greetings for the day! I am an undergraduate student at the Indian Institute of Technology, Kanpur. I am very much interested in contributing to your organization in the Season of Docs. Please let me know how we can begin discussing the project. I will be delighted to be a part of your t

Re: pg12 release notes

2019-05-11 Thread Peter Geoghegan
On Sat, May 11, 2019 at 7:40 AM Bruce Momjian wrote: > > > > I think I have understood the nuances, as listed above --- I just don't > > > > agree with the solution. > > > > > > To be clear, I don't expect you to agree with the solution. > > > > > > Another thing that you missed from my patch is t

Re: pg12 release notes

2019-05-11 Thread Bruce Momjian
On Sat, May 11, 2019 at 10:28:08AM -0700, Peter Geoghegan wrote: > On Sat, May 11, 2019 at 7:40 AM Bruce Momjian wrote: > > > > > I think I have understood the nuances, as listed above --- I just > > > > > don't > > > > > agree with the solution. > > > > > > > > To be clear, I don't expect you to

Re: Bug in reindexdb's error reporting

2019-05-11 Thread Julien Rouhaud
On Sat, May 11, 2019 at 2:09 PM Michael Paquier wrote: > > On Sat, May 11, 2019 at 10:28:43AM +0200, Julien Rouhaud wrote: > > I attach the switch refactoring that applies on top of current HEAD, > > and the reindex_system_catalogs() removal in a different patch in case > > that's too much during

Re: pg12 release notes

2019-05-11 Thread Peter Geoghegan
On Sat, May 11, 2019 at 11:02 AM Bruce Momjian wrote: > OK, commit removed. You're mistaken -- nothing has been pushed to master in the last 3 hours. -- Peter Geoghegan

Re: Unexpected "shared memory block is still in use"

2019-05-11 Thread Noah Misch
On Fri, May 10, 2019 at 04:46:40PM -0400, Tom Lane wrote: > I wrote: > > Will go fix/backpatch in a minute. > > Done now, but while thinking more about the issue, I had an idea: why is > it that we base the shmem key on the postmaster's port number, and not > on the data directory's inode number?

Re: pg12 release notes

2019-05-11 Thread Bruce Momjian
On Sat, May 11, 2019 at 11:47:42AM -0700, Peter Geoghegan wrote: > On Sat, May 11, 2019 at 11:02 AM Bruce Momjian wrote: > > OK, commit removed. > > You're mistaken -- nothing has been pushed to master in the last 3 hours. I am not mistaken. I have removed it from my local copy, but have not pu

PG 12 draft release notes

2019-05-11 Thread Bruce Momjian
I have posted a draft copy of the PG 12 release notes here: http://momjian.us/pgsql_docs/release-12.html They are committed to git. It includes links to the main docs, where appropriate. Our official developer docs will rebuild in a few hours. -- Bruce Momjian http://momjia

Re: Bug in reindexdb's error reporting

2019-05-11 Thread Alvaro Herrera
On 2019-May-11, Julien Rouhaud wrote: > On Sat, May 11, 2019 at 2:09 PM Michael Paquier wrote: > > Also, as this thread's problem has been solved, perhaps it would be > > better to spawn a new thread, and to add a new entry in the CF app for > > the refactoring set so as it attracts the correct

Wrong dead return value in jsonb_utils.c

2019-05-11 Thread Rikard Falkeborn
Returning -1 from a function with bool as return value is the same as returning true. Now, the code is dead (since elog(ERROR, ...) does not return) so it doesn't matter to the compiler, but changing to false is less confusing for the programmer. Appologies if this is seen as unnecessary churn. Th

Re: Augment every test postgresql.conf

2019-05-11 Thread Noah Misch
On Sun, Apr 07, 2019 at 07:56:02AM -0400, Andrew Dunstan wrote: > On Sun, Apr 7, 2019 at 2:41 AM Noah Misch wrote: > > > > On Sun, Dec 30, 2018 at 10:32:31AM -0500, Andrew Dunstan wrote: > > > On 12/30/18 12:53 AM, Noah Misch wrote: > > > > 2. stats_temp_directory is incompatible with TAP suites t

Re: Augment every test postgresql.conf

2019-05-11 Thread Tom Lane
Noah Misch writes: > Pushed. This broke 010_dump_connstr.pl on bowerbird, introducing 'invalid > byte sequence for encoding "UTF8"' errors. That's because log_connections > renders this 010_dump_connstr.pl solution insufficient: Ugh. > 4. If GetMessageEncoding()==PG_SQL_ASCII, make pgwin32_mes

Re: POC: Cleaning up orphaned files using undo logs

2019-05-11 Thread Dilip Kumar
On Thu, May 9, 2019 at 12:04 PM Dilip Kumar wrote: > > On Mon, May 6, 2019 at 5:43 PM Dilip Kumar wrote: > > > > Just for tracking, open comments which still needs to be worked on. > > > > 1. Avoid special case in UndoRecordIsValid. > > > Can we instead eliminate the special case? It seems like