Re: Special role for subscriptions

2019-03-20 Thread Michael Paquier
On Wed, Mar 20, 2019 at 11:58:04PM +0800, Andrey Borodin wrote: >> 20 марта 2019 г., в 21:46, Robert Haas написал(а): >> I think we should view this permission as "you can create >> subscriptions, plain and simple". > > That sounds good. > From my POV, the purpose of the patch is to allow users t

Re: Psql patch to show access methods info

2019-03-20 Thread Nikita Glukhov
Hi. On 08.03.2019 7:52, Kyotaro HORIGUCHI wrote: Hello. At Mon, 10 Dec 2018 19:38:39 +0300, s.cherkas...@postgrespro.ru wrote in <70e94e339dd0fa2be5d3eebec68da...@postgrespro.ru> Here are some fixes. But I'm not sure that the renaming of columns for the '\dAp' command is sufficiently laconic

RE: Best way to keep track of a sliced TOAST

2019-03-20 Thread Bruno Hass
I would like to optimize the jsonb key access operations. I could not find the discussion you've mentioned, but I am giving some thought to the idea. Instead of storing lengths, could we dedicate the first chunk of the TOASTed jsonb to store where each key is located? Would it be a good idea? Y

Re: performance issue in remove_from_unowned_list()

2019-03-20 Thread Tomas Vondra
On 3/12/19 11:54 PM, Tomas Vondra wrote: > > > On 3/10/19 9:09 PM, Alvaro Herrera wrote: >> On 2019-Feb-07, Tomas Vondra wrote: >> >>> Attached is a WIP patch removing the optimization from DropRelationFiles >>> and adding it to smgrDoPendingDeletes. This resolves the issue, at least >>> in the c

Re: Special role for subscriptions

2019-03-20 Thread Andrey Borodin
> 21 марта 2019 г., в 8:56, Michael Paquier написал(а): > > On Wed, Mar 20, 2019 at 11:58:04PM +0800, Andrey Borodin wrote: >>> 20 марта 2019 г., в 21:46, Robert Haas написал(а): >>> I think we should view this permission as "you can create >>> subscriptions, plain and simple". >> >> That so

Re: MSVC Build support with visual studio 2019

2019-03-20 Thread Michael Paquier
On Thu, Mar 21, 2019 at 09:47:02AM +0900, Michael Paquier wrote: > When it comes to support newer versions of MSVC, we have come up > lately to backpatch that down to two stable versions but not further > down (see f2ab389 for v10 and v9.6), so it looks sensible to target > v11 and v10 as well if w

Re: PostgreSQL pollutes the file system

2019-03-20 Thread Tomas Vondra
On 3/21/19 1:49 AM, Michael Paquier wrote: > On Thu, Mar 21, 2019 at 08:41:32AM +0900, Tatsuo Ishii wrote: >>> Can someone describe a scenario where this (name of the binary not >>> clearly indicating it's related postgres) causes issues in practice? On >>> my system, there are ~1400 binaries in

Re: current_logfiles not following group access and instead follows log_file_mode permissions

2019-03-20 Thread Haribabu Kommi
On Wed, Mar 20, 2019 at 4:33 PM Michael Paquier wrote: > On Fri, Mar 15, 2019 at 06:51:37PM +1100, Haribabu Kommi wrote: > > IMO, this update is just a recommendation to the user, and sometimes it > is > > still possible that there may be strict permissions for the log file > > even the data dire

Re: MSVC Build support with visual studio 2019

2019-03-20 Thread Haribabu Kommi
On Thu, Mar 21, 2019 at 12:31 PM Michael Paquier wrote: > On Thu, Mar 21, 2019 at 09:47:02AM +0900, Michael Paquier wrote: > > When it comes to support newer versions of MSVC, we have come up > > lately to backpatch that down to two stable versions but not further > > down (see f2ab389 for v10 an

Re: current_logfiles not following group access and instead follows log_file_mode permissions

2019-03-20 Thread Haribabu Kommi
On Thu, Mar 21, 2019 at 12:41 PM Haribabu Kommi wrote: > > On Wed, Mar 20, 2019 at 4:33 PM Michael Paquier > wrote: > >> And actually it seems to me that you have a race condition in that >> stuff. I think that you had better use umask(), then fopen, and then >> once again umask() to put back t

Re: DNS SRV support for LDAP authentication

2019-03-20 Thread Thomas Munro
On Tue, Mar 19, 2019 at 9:01 PM Thomas Munro wrote: > I'd like to commit this soon. Done, after some more comment adjustments. Thanks Daniel and Graham for your feedback! -- Thomas Munro https://enterprisedb.com

Re: PostgreSQL pollutes the file system

2019-03-20 Thread Tom Lane
Tomas Vondra writes: > On 3/21/19 1:49 AM, Michael Paquier wrote: >> On Thu, Mar 21, 2019 at 08:41:32AM +0900, Tatsuo Ishii wrote: >>> Can someone describe a scenario where this (name of the binary not >>> clearly indicating it's related postgres) causes issues in practice? >> Naming conflict bec

Re: Determine if FOR UPDATE or FOR SHARE was used?

2019-03-20 Thread Chapman Flack
On 03/18/19 00:45, Tom Lane wrote: > I think it would help to take two steps back and ask why you want > to know this, and what exactly is it that you want to know, anyhow. > What does it matter if there's FOR SHARE in the query? Does it I was looking at an old design decision in PL/Java, which i

Re: MacPorts support for "extra" tests

2019-03-20 Thread Tom Lane
Thomas Munro writes: > Peter E added some nice tests for LDAP and Kerberos, but they assume > you have Homebrew when testing on a Mac. Here's a patch to make them > work with MacPorts too (a competing open source port/package > distribution that happens to be the one that I use). The third > "ex

Re: PostgreSQL pollutes the file system

2019-03-20 Thread Abhijit Menon-Sen
At 2019-03-20 23:22:44 +0100, tomas.von...@2ndquadrant.com wrote: > > I don't really understand what issue are we trying to solve here. > > Can someone describe a scenario where this (name of the binary not > clearly indicating it's related postgres) causes issues in practice? > On my system, ther

Re: Pluggable Storage - Andres's take

2019-03-20 Thread Haribabu Kommi
On Sat, Mar 16, 2019 at 5:43 PM Haribabu Kommi wrote: > > > On Sat, Mar 9, 2019 at 2:13 PM Andres Freund wrote: > >> Hi, >> >> While 0001 is pretty bulky, the interesting bits concentrate on a >> comparatively small area. I'd appreciate if somebody could give the >> comments added in tableam.h a

Re: Pluggable Storage - Andres's take

2019-03-20 Thread Haribabu Kommi
Hi, The psql \dA commands currently doesn't show the type of the access methods of type 'Table'. postgres=# \dA heap List of access methods Name | Type --+--- heap | (1 row) Attached a simple patch that fixes the problem and outputs as follows. postgres=# \dA heap List of access metho

Re: [HACKERS] WAL logging problem in 9.4.3?

2019-03-20 Thread Noah Misch
On Wed, Mar 20, 2019 at 05:17:54PM +0900, Kyotaro HORIGUCHI wrote: > At Sun, 10 Mar 2019 19:27:08 -0700, Noah Misch wrote in > <20190311022708.ga2189...@rfd.leadboat.com> > > On Mon, Mar 04, 2019 at 12:24:48PM +0900, Kyotaro HORIGUCHI wrote: > > > +/* > > > + * Sync to disk any relations that we

Re: PostgreSQL pollutes the file system

2019-03-20 Thread Andreas Karlsson
On 3/20/19 8:19 PM, Andres Freund wrote: On 2019-03-20 15:15:02 -0400, Jonathan S. Katz wrote: If we are evaluating this whole symlink / renaming thing, there could be arguments for a "pgsql" alias to psql (or vice versa), but I don't think "pg_sql" makes any sense and could be fairly confusing.

Re: PostgreSQL pollutes the file system

2019-03-20 Thread Chris Travers
On Thu, Mar 21, 2019 at 1:49 AM Michael Paquier wrote: > On Thu, Mar 21, 2019 at 08:41:32AM +0900, Tatsuo Ishii wrote: > >> Can someone describe a scenario where this (name of the binary not > >> clearly indicating it's related postgres) causes issues in practice? On > >> my system, there are ~14

Re: Transaction commits VS Transaction commits (with parallel) VS query mean time

2019-03-20 Thread Haribabu Kommi
On Wed, Mar 20, 2019 at 7:38 PM Amit Kapila wrote: > On Sun, Feb 10, 2019 at 10:54 AM Haribabu Kommi > wrote: > > On Sat, Feb 9, 2019 at 4:07 PM Amit Kapila > wrote: > >> > >> I don't think so. It seems to me that we should consider it as a > >> single transaction. Do you want to do the leg w

Re: Libpq support to connect to standby server as priority

2019-03-20 Thread Haribabu Kommi
On Wed, Mar 20, 2019 at 5:01 PM Tsunakawa, Takayuki < tsunakawa.ta...@jp.fujitsu.com> wrote: > From: Robert Haas [mailto:robertmh...@gmail.com] > > I really dislike having both target_sesion_attrs and > > target_server_type. It doesn't solve any actual problem. master, > > slave, prefer-save, or

<    1   2