Re: pgsql: Add support for hyperbolic functions, as well as log10().

On Tue, Mar 12, 2019 at 11:16:42PM -0400, Tom Lane wrote: > Yeah. I warned Laetitia about not testing corner cases, but > it hadn't occurred to me that zero might be a corner case :-( I was honestly expecting more failures than that when I saw the patch landing. This stuff is tricky :) > I'm in

Re: BUG #15668: Server crash in transformPartitionRangeBounds

On 2019/03/11 16:21, Michael Paquier wrote: > On Mon, Mar 11, 2019 at 03:44:39PM +0900, Amit Langote wrote: >> We could make the error message more meaningful depending on the context, >> but maybe it'd better be pursue it as a separate project. > > Yeah, I noticed that stuff when working on it th

Re: [HACKERS] Block level parallel vacuum

On Fri, Mar 8, 2019 at 12:22 AM Robert Haas wrote: > > On Wed, Mar 6, 2019 at 10:58 PM Masahiko Sawada wrote: > > > Why make it a Node? I mean I think a struct makes sense, but what's > > > the point of giving it a NodeTag? > > > > Well, the main point is consistency with other nodes and keep th

Re: [PATCH] remove repetitive characters in fdwhandler.sgml

(2019/03/13 14:02), Michael Paquier wrote: On Tue, Mar 12, 2019 at 01:37:04AM +, Zhang, Jie wrote: Here is a tiny patch removing repetitive characters [if] in fdwhandler.sgml. - This function should store the tuple into the provided, or clear it if if + This function should

Re: Timeout parameters

Hello Robert, wrote: The main purpose of this parameter is to avoid client's waiting for DB server infinitely, not reducing the server's burden. This results in not waiting end-user, which is most important. +1. If the server fails to detect that the client has gone away, that's the serv

Re: COPY FREEZE and setting PD_ALL_VISIBLE/visibility map bits

On Tue, Mar 12, 2019 at 4:54 PM Pavan Deolasee wrote: > > > On Mon, Mar 11, 2019 at 1:37 PM Masahiko Sawada wrote: >> >> >> >> I might be missing something but why do we need to recheck whether >> each pages is all-frozen after insertion? I wonder if we can set >> all-frozen without checking all

Re: BUG #15668: Server crash in transformPartitionRangeBounds

On 2019/03/13 14:15, Amit Langote wrote: > On 2019/03/11 16:21, Michael Paquier wrote: >> On Mon, Mar 11, 2019 at 03:44:39PM +0900, Amit Langote wrote: >>> We could make the error message more meaningful depending on the context, >>> but maybe it'd better be pursue it as a separate project. >> >> Y

Re: Offline enabling/disabling of data checksums

Bonjour Michaël, Yes, that would be nice, for now I have focused. For pg_resetwal yes we could do it easily. Would you like to send a patch? I probably can do that before next Monday. I'll prioritize reviewing the latest instance of this patch, though. This seem contradictory to me: you

Re: [PATCH] remove repetitive characters in fdwhandler.sgml

On 2019-03-13 14:55:59 +0900, Etsuro Fujita wrote: > (2019/03/13 14:02), Michael Paquier wrote: > > On Tue, Mar 12, 2019 at 01:37:04AM +, Zhang, Jie wrote: > > > Here is a tiny patch removing repetitive characters [if] in > > > fdwhandler.sgml. > > > > > > - This function should st

Re: Progress reporting for pg_verify_checksums

Hallo Michael, I would bother rounding down < 100% to 100, because then you would get 1560/1492 MB (100\%, X MB/s) which is kind of silly. No, we cap the total_size to current_size so you won't see that (but total_size will potentially gradually increase). pg_basebackup has the same beha

Re: [HACKERS] PATCH: multivariate histograms and MCV lists

On Wed, 13 Mar 2019 at 17:20, Kyotaro HORIGUCHI wrote: > bms_member_index seems working differently than maybe expected. > > bms_member_index((2, 4), 0) => 0, (I think) should be -1 > bms_member_index((2, 4), 1) => 0, should be -1 > bms_member_index((2, 4), 2) => 0, should be 0 > bms_member_in

<    1   2