Re: replace_text optimization (StringInfo to varlena)

2019-02-13 Thread Kyotaro HORIGUCHI
At Wed, 13 Feb 2019 16:38:50 +0100, "Daniel Verite" wrote in > Hi, > > replace_text() in varlena.c builds the result in a StringInfo buffer, > and finishes by copying it into a freshly allocated varlena structure > with cstring_to_text_with_len(), in the same memory context. > > It looks lik

Re: pg_basebackup ignores the existing data directory permissions

2019-02-13 Thread Haribabu Kommi
On Thu, Feb 14, 2019 at 3:04 PM Michael Paquier wrote: > On Wed, Feb 13, 2019 at 06:42:36PM +1100, Haribabu Kommi wrote: > > This should back-patch till 11 where the group access is introduced. > > Because of lack of complaints, I agree with you that there is no need of > > further back-patch. >

[Bug Fix] ECPG: could not use some CREATE TABLE AS syntax

2019-02-13 Thread Higuchi, Daisuke
Hi, I found some "CREATE TABLE ... AS ... " syntaxes could not be used in ECPG. [PROBLEM] First, ECPG command is failed when the source code (*.pgc) has "IF NOT EXISTS". --- EXEC SQL CREATE TABLE IF NOT EXISTS test_cta AS SELECT *

Re: Prevent extension creation in temporary schemas

2019-02-13 Thread Michael Paquier
On Wed, Feb 13, 2019 at 12:08:50PM +0100, Chris Travers wrote: > If the point is visibility in \dx it seems to me we want to fix the \dx > query. Yes, I got to think a bit more about that case, and there are cases where this actually works properly as this depends on the objects defined in the ext

<    1   2