Re: GiST VACUUM

On Wed, Mar 7, 2018 at 7:50 PM, Andrey Borodin wrote: > Here's new version of GiST VACUUM patch set aimed at CF 2018-09. Hi Andrey, FYI Windows doesn't like this patch[1]. + uint16_t flags; I think that needs to be uint16? [1] https://ci.appveyor.com/project/postgresql-cfbot/postgresql/bu

[GSoC] Question about returning bytea array

Hi Aleksander, I have the requirements to return a bytea array for some functions in pg_thrift plugin. What I did was similar to the following, bytea** ret = palloc(len * sizeof(bytea*)); for (int i = 0; i < len; i++) { // allocate space ret[i] = palloc(size); // fill in ret[i] ...

Re: Needless additional partition check in INSERT?

On 10 May 2018 at 21:56, David Rowley wrote: > On 10 May 2018 at 17:42, Simon Riggs wrote: >> Patch is good. >> >> The cause of this oversight is the lack of comments to explain the >> original coding, so we need to correct that in this patch, please. > > Thanks for looking. > > Yeah, the comment

Re: [GSoC] Question about returning bytea array

2018-05-17 7:03 GMT+02:00 Charles Cui : > Hi Aleksander, > >I have the requirements to return a bytea array for some functions in > pg_thrift plugin. > What I did was similar to the following, > > bytea** ret = palloc(len * sizeof(bytea*)); > for (int i = 0; i < len; i++) { >// allocate sp

Re: postgres_fdw: Oddity in pushing down inherited UPDATE/DELETE joins to remote servers

On 2018/05/17 12:30, Etsuro Fujita wrote: > (2018/05/17 1:16), Robert Haas wrote: >> Was it just good luck that this ever worked at all?  I mean: >> >> -    if (rti<  root->simple_rel_array_size&& >> -    root->simple_rel_array[rti] != NULL) >> +    if (rti<  subroot->simple_rel_arr

Re: Needless additional partition check in INSERT?

On 2018/05/17 14:15, David Rowley wrote: > On 10 May 2018 at 21:56, David Rowley wrote: >> On 10 May 2018 at 17:42, Simon Riggs wrote: >>> Patch is good. >>> >>> The cause of this oversight is the lack of comments to explain the >>> original coding, so we need to correct that in this patch, pleas

Re: PATCH: pgbench - option to build using ppoll() for larger connection counts

On Tue, Mar 27, 2018 at 9:23 AM, Rady, Doug wrote: > pgbench11-ppoll-v12.patch Hi Doug, FYI this patch is trying and failing to use ppoll() on Windows: https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.30 -- Thomas Munro http://www.enterprisedb.com

Re: postgres_fdw: Oddity in pushing down inherited UPDATE/DELETE joins to remote servers

On 2018/05/17 14:19, Amit Langote wrote: > Looking at this for a bit, I wondered if this crash wouldn't have occurred > if the "propagation" had also considered join relations in addition to > simple relations. For example, if I changed inheritance_planner like the > attached (not proposing that w

Re: [Patch] Checksums for SLRU files

Hi, Ivan! > 19 марта 2018 г., в 15:32, Andrey Borodin написал(а): > I was looking into this patch mainly because I was reviewing other checksums > patch in different thread. But the purpose of this patch seems viable for me. > After looking into the patch I'd like to propose some editorializatio

Re: GiST VACUUM

Hi, Thomas! > 17 мая 2018 г., в 9:40, Thomas Munro > написал(а): > > On Wed, Mar 7, 2018 at 7:50 PM, Andrey Borodin wrote: >> Here's new version of GiST VACUUM patch set aimed at CF 2018-09. > > Hi Andrey, > > FYI Windows doesn't like this patch[1]. > > + uint16_t flags; > > I think th

Re: Problem while updating a foreign table pointing to a partitioned table on foreign server

On Wed, May 16, 2018 at 11:31 PM, Robert Haas wrote: > On Mon, Apr 16, 2018 at 7:35 AM, Ashutosh Bapat > wrote: >> It does fix the problem. But the patch as is interferes with the way >> we handle tableoid currently. That can be seen from the regression >> diffs that the patch causes. RIght now,

<    1   2