On 4/11/18 17:19, Keith Fiske wrote:
> To me the current behavior is even more unintuitive. You tell it to put
> the parent table in a specific tablespace and it completely ignores the
> option and puts it in the default. Then when you go create children
> without specifying a tablespace, you don't
On Wed, Apr 11, 2018 at 2:29 PM, Peter Eisentraut
wrote:
> But in this case it doesn't even do equality comparison, it just returns
> the value.
That's the idea that I tried to express. The point is that we need to
tell the user that there is no need to worry about it, rather than
that they're wr
> On Apr 11, 2018, at 4:58 PM, Peter Eisentraut
> wrote:
>
> On 4/11/18 10:53, Tom Lane wrote:
>> It's not that much work to move the items rather than remove them,
>
> Well, toward the end of the cycle, when the list of closed items is
> quite long, then it does become a bit of a burden to ca
On Thu, Apr 12, 2018 at 12:01:29AM +0300, Heikki Linnakangas wrote:
> Thanks for the debugging and the patch, Edmund!
Thanks for the commit, Heikki.
--
Michael
signature.asc
Description: PGP signature
On 4/11/18 17:38, Peter Geoghegan wrote:
> On Wed, Apr 11, 2018 at 2:29 PM, Peter Eisentraut
> wrote:
>> But in this case it doesn't even do equality comparison, it just returns
>> the value.
>
> That's the idea that I tried to express. The point is that we need to
> tell the user that there is n
Peter Geoghegan wrote:
On Wed, Apr 11, 2018 at 2:29 PM, Peter Eisentraut
wrote:
But in this case it doesn't even do equality comparison, it just returns
the value.
That's the idea that I tried to express. The point is that we need to
tell the user that there is no need to worry about it, ra
That's the idea that I tried to express. The point is that we need to
tell the user that there is no need to worry about it, rather than
that they're wrong to ask about it. Though we should probably actually
just throw an error.
Or maybe it should be the collation of the underlying table columns
On Wed, Apr 11, 2018 at 04:28:33PM -0400, Tom Lane wrote:
> I propose therefore that the right fix does not require an API change
> for GetNewOidWithIndex: we can just make it use SnapshotAny all the
> time.
I have not really checked this thread in details, but one thing that
strikes me is that it
On Wed, Apr 11, 2018 at 10:28:10PM +0100, Simon Riggs wrote:
> Requesting review so I don't cause multiple revert commits.
I have gone through the code tree with your patch applied for some time,
and it seems to me that there are no more traces of merge or any of its
infrastructure. Tests are als
Michael Paquier writes:
> I have not really checked this thread in details, but one thing that
> strikes me is that it would be rather easy to add a TAP test based on
> the initial script that Pavan has sent. Would that be worth testing
> cycles or not?
I doubt it --- that test is so specialized
On Wed, Apr 11, 2018 at 10:16:24AM -0400, Tom Lane wrote:
> That works for me:
>
> $ git clean -dfx
> $ ./configure ... --with-python and other stuff ...
> $ cd src/pl/plpython
> $ make all
> make -C ../../../src/backend generated-headers
> make[1]: Entering directory `/home/postgres/pgsql/src/bac
On 4/10/18 06:29, Pavan Deolasee wrote:
> One of our 2ndQuadrant support customers recently reported a sudden rush
> of TOAST errors post a crash recovery, nearly causing an outage. Most
> errors read like this:
>
> ERROR: unexpected chunk number 0 (expected 1) for toast value
While research
Hello. Thanks to Heikkit for picking this up and thanks for the
commnet to Michael.
# The attached is changed only in a comment, and rebased.
At Thu, 12 Apr 2018 05:24:14 +0900, Michael Paquier wrote
in <20180411202414.ga32...@paquier.xyz>
> On Wed, Apr 11, 2018 at 02:09:48PM +0300, Heikki Linn
On 12 April 2018 at 09:19, Keith Fiske wrote:
> To me the current behavior is even more unintuitive. You tell it to put the
> parent table in a specific tablespace and it completely ignores the option
> and puts it in the default. Then when you go create children without
> specifying a tablespace,
On 2018/04/11 21:35, Alvaro Herrera wrote:
> Here's an idea. Why don't we move the function/opclass creation lines
> to insert.sql, without the DROPs, and use the same functions/opclasses
> in the three tests insert.sql, alter_table.sql, hash_part.sql and
> partition_prune.sql, i.e. not recreate w
On Tue, Apr 10, 2018 at 5:45 PM, Peter Geoghegan wrote:
> I did find another problem, though. Looks like the idea to explicitly
> represent the number of attributes directly has paid off already:
>
> pg@~[3711]=# create table covering_bug (f1 int, f2 int, f3 text);
> create unique index cov_idx on
On 2018/04/12 5:33, Alvaro Herrera wrote:
> Amit Langote wrote:
>> Hi.
>>
>> I noticed that relispartition isn't set for index's partitions.
>
> This patch should fix it.
Thanks. I saw your commit 9e9befac4a22 and changes seem fine.
Regards,
Amit
Hello.
At Wed, 11 Apr 2018 09:43:37 -0400, "Jonathan S. Katz"
wrote in
> case EXPR_KIND_PARTITION_BOUNDS:
> ^~
..
> 2 errors generated.
>
> The attached patch fixes the error.
Sorry for the silly mistake.
> I ran the following cas
On 11 April 2018 at 09:32, Alvaro Herrera wrote:
> Robert Haas wrote:
>> On Mon, Apr 9, 2018 at 2:28 PM, Alvaro Herrera
>> wrote:
>
>> >> I don't get this. The executor surely had to (and did) open all of
>> >> the relations somewhere even before this patch.
>
>> > I was worried that this codin
On Thu, Apr 12, 2018 at 10:34:30AM +0900, Kyotaro HORIGUCHI wrote:
> Checkpointer never calls CreateCheckPoint while
> RecoveryInProgress() == true. In other words, checkpointer is not
> an updator of shared FPW at the time StartupXLOG calls
> CreateCheckPoint for fallback_promote.
I have been abl
On Thu, Apr 12, 2018 at 2:31 AM, Tom Lane wrote:
> Peter Eisentraut writes:
>> On 4/11/18 10:53, Tom Lane wrote:
>>> It's not that much work to move the items rather than remove them,
>
>> Well, toward the end of the cycle, when the list of closed items is
>> quite long, then it does become a bit
On Wed, Apr 11, 2018 at 10:33 PM, Magnus Hagander wrote:
> On Wed, Apr 11, 2018 at 6:57 PM, Andres Freund wrote:
>>
>> On 2018-04-11 13:54:34 -0300, Alvaro Herrera wrote:
>> > The other proposal was that we could have a simple web app to track open
>> > items. After all, we now know what we need
On Thu, Apr 12, 2018 at 11:46:33AM +0530, Ashutosh Bapat wrote:
> Usually there are threads associated with the open items, then there
> are patches to solve those and owners responsible in resolving them.
> We have all the infrastructure in the commitfest app to track those
> things, may be we cou
101 - 123 of 123 matches
Mail list logo
