Re: [HACKERS] Restrict concurrent update/delete with UPDATE of partition key

2018-04-04 Thread Amit Kapila
On Thu, Apr 5, 2018 at 7:14 AM, Andres Freund wrote: > > I've attached a noticeably editorialized patch: > > - I'm uncomfortable with the "moved" information not being crash-safe / > replicated. Thus I added a new flag to preserve it, and removed the > masking of the moved bit in the ctid from

Re: [HACKERS] Restrict concurrent update/delete with UPDATE of partition key

2018-04-04 Thread David G. Johnston
On Wednesday, April 4, 2018, Amit Kapila wrote: > On Thu, Apr 5, 2018 at 7:14 AM, Andres Freund wrote: > > > > > Questions: > > > > - I'm not perfectly happy with > > "tuple to be locked was already moved to another partition due to > concurrent update" > > as the error message. If somebody

Re: [HACKERS] GUC for cleanup indexes threshold.

2018-04-04 Thread Masahiko Sawada
On Thu, Apr 5, 2018 at 1:30 AM, Teodor Sigaev wrote: > Thanks for everyone, pushed with minor editorization > Thank you for committing! I found a typo in nbtpage.c and attached a patch fixes it. s/overritten/overwritten/ Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NT

Re: [HACKERS] MERGE SQL Statement for PG11

2018-04-04 Thread Pavan Deolasee
On Tue, Apr 3, 2018 at 7:48 AM, Andres Freund wrote: > > > @@ -3828,8 +3846,14 @@ struct AfterTriggersTableData > boolbefore_trig_done; /* did we already queue BS triggers? */ > boolafter_trig_done;/* did we already queue AS triggers? */ > AfterTriggerEventList a

Shared PostgreSQL libraries and symbol versioning

2018-04-04 Thread Pavel Raiskup
Hello, for the support of multiple versions of PostgreSQL RPM packages on one system, we are thinking about having only one libpq.so.5 (libecpg.so.6, libpgtype.so.3 respectively) supported and about building (linking) all the PostgreSQL package versions against that. The pattern would mean that we

Re: [HACKERS] Add support for tuple routing to foreign partitions

2018-04-04 Thread Etsuro Fujita
(2018/04/04 19:31), Etsuro Fujita wrote: Attached is an updated version of the patch set: * As before, patch foreign-routing-fdwapi-4.patch is created on top of patch postgres-fdw-refactoring-4.patch and the bug-fix patch [1]. I did a bit of cleanup and comment-rewording to patch foreign-routi

Re: [HACKERS] Restrict concurrent update/delete with UPDATE of partition key

2018-04-04 Thread Amit Kapila
On Thu, Apr 5, 2018 at 10:40 AM, David G. Johnston wrote: > On Wednesday, April 4, 2018, Amit Kapila wrote: >> >> On Thu, Apr 5, 2018 at 7:14 AM, Andres Freund wrote: >> > >> >> > Questions: >> > >> > - I'm not perfectly happy with >> > "tuple to be locked was already moved to another partitio

Re: [HACKERS] Add support for tuple routing to foreign partitions

2018-04-04 Thread Amit Langote
Fujita-san, On 2018/04/05 15:02, Etsuro Fujita wrote: > (2018/04/04 19:31), Etsuro Fujita wrote: >> Attached is an updated version of the patch set: >> * As before, patch foreign-routing-fdwapi-4.patch is created on top of >> patch postgres-fdw-refactoring-4.patch and the bug-fix patch [1]. > > I

Re: [HACKERS] GUC for cleanup indexes threshold.

2018-04-04 Thread Masahiko Sawada
On Thu, Apr 5, 2018 at 2:40 PM, Masahiko Sawada wrote: > On Thu, Apr 5, 2018 at 1:30 AM, Teodor Sigaev wrote: >> Thanks for everyone, pushed with minor editorization >> > > Thank you for committing! > I found a typo in nbtpage.c and attached a patch fixes it. > I also found an incorrect document

Re: [HACKERS] logical decoding of two-phase transactions

2018-04-04 Thread Nikhil Sontakke
Hi Tomas, > 1) There's a race condition in LogicalLockTransaction. The code does > roughly this: > > if (!BecomeDecodeGroupMember(...)) > ... bail out ... > > Assert(MyProc->decodeGroupLeader); > lwlock = LockHashPartitionLockByProc(MyProc->decodeGroupLeader); > ... > > but AFAICS the

Re: [HACKERS] Restrict concurrent update/delete with UPDATE of partition key

2018-04-04 Thread Pavan Deolasee
On Thu, Apr 5, 2018 at 7:14 AM, Andres Freund wrote: > > > I've attached a noticeably editorialized patch: > > + /* +* As long as we don't support an UPDATE of INSERT ON CONFLICT for +* a partitioned table we shouldn't reach to a case where tuple to +

Re: [HACKERS] Runtime Partition Pruning

2018-04-04 Thread David Rowley
On 5 April 2018 at 15:14, Amit Langote wrote: > On 2018/03/31 22:52, David Rowley wrote: >> Initialising >> Append/MergeAppend/ModifyTable nodes with fewer subnodes than were >> originally planned did require a small change in explain.c in some >> code that was assuming the subnode arrays were the

Re: PATCH: Configurable file mode mask

2018-04-04 Thread Michael Paquier
On Wed, Apr 04, 2018 at 08:03:54PM -0400, David Steele wrote: > On 4/2/18 2:28 AM, Michael Paquier wrote: >> The answer is no for me and likely the same for others, but I am raising >> the point for the archives. Should we relax >> check_ssl_key_file_permissions() for group permissions by the way

Re: [HACKERS] Add support for tuple routing to foreign partitions

2018-04-04 Thread Etsuro Fujita
(2018/04/05 15:37), Amit Langote wrote: On 2018/04/05 15:02, Etsuro Fujita wrote: (2018/04/04 19:31), Etsuro Fujita wrote: Attached is an updated version of the patch set: * As before, patch foreign-routing-fdwapi-4.patch is created on top of patch postgres-fdw-refactoring-4.patch and the bug-f

<    1   2