I wrote:
> I looked for rules with this bug by looking for comments that
> mention parser/Makefile. There may well be some more, but I have
> no good idea how to find them --- any thoughts?
I realized that grepping for line-ending semicolons in makefiles
would be a pretty efficient way to check t
Hi,
On 2018-03-22 16:09:51 +1300, Thomas Munro wrote:
> On Thu, Mar 22, 2018 at 1:36 PM, Thomas Munro
> wrote:
> > I've now run out of things to complain about for now. Nice work!
>
> I jumped on a POWER8 box. As expected, the same breakage occurs. So
> I hacked LLVM 6.0 thusly:
>
> diff --g
On Wed, Mar 07, 2018 at 05:06:59PM -0500, Robert Haas wrote:
> TBH I find that Homebrew example pretty odd. I would understand
> installing each major release in a version directory, but putting
> every point release in a different versioned directory seems like a
> bad plan.
That's a project po
On Wed, Mar 07, 2018 at 06:17:15PM -0500, Tom Lane wrote:
> I agree. My recollection is that we expended substantial sweat to make
> that type of setup work, and I do not think it was for idle reasons.
> The fact that the behavior is very old doesn't mean it was a bad choice.
> (Also, the fact tha
On 2018/03/20 21:41, David Rowley wrote:
> On 21 March 2018 at 00:07, Amit Langote wrote:
>> Attached is further revised version.
>
> In the 0004 patch I see:
>
> @@ -1439,6 +1441,10 @@ inheritance_planner(PlannerInfo *root)
> if (IS_DUMMY_PATH(subpath))
> continue;
>
> + /* Add the current
On Tue, Mar 20, 2018 at 10:09 AM, Amit Langote <
langote_amit...@lab.ntt.co.jp> wrote:
> On 2018/03/20 13:30, Amit Langote wrote:
> > I have incorporated your patch in the main patch after updating the
> > comments a bit. Also, now that ee49f49 is in [1], the transition
> > table related test
On Thu, Mar 22, 2018 at 3:26 AM, Robert Haas wrote:
>
> Is there a good reason not to use input_rel->relids as the input to
> fetch_upper_rel() in all cases, rather than just at subordinate
> levels?
>
That would simplify some code in these patches. We have set
upper_rel->relids to NULL for non-o
On 21 March 2018 at 16:29, Melanie Plageman wrote:
> For a small performance hit but an improvement in readability, the length
> check
> can be moved from the individual group by and distinct clause checks into the
> helper function
>
> if (list_length(parse->distinctClause) < 2)
>
On Thu, Mar 22, 2018 at 7:22 AM, Claudio Freire
wrote:
>
> If you're not planning on making any further changes, would you mind
> posting a coalesced patch?
>
> Notice that I removed the last offset thing only halfway, so it would
> need some cleanup.
>
Here is an updated patch. I removed the la
101 - 109 of 109 matches
Mail list logo
