RE: [bug fix] pg_rewind takes long time because it mistakenly copies data files

2018-02-27 Thread Tsunakawa, Takayuki
From: Michael Paquier [mailto:mich...@paquier.xyz] > So I would propose to just do that later. I have looked a second time at > your patch, attached is the set of tests I have run: Thanks so much, that has helped me a lot! > I have one small comment though. The comment block at the beginning of

Re: [HACKERS] Restrict concurrent update/delete with UPDATE of partition key

2018-02-27 Thread Rajkumar Raghuwanshi
On Wed, Feb 14, 2018 at 5:44 PM, Amit Kapila wrote: > +# Concurrency error from GetTupleForTrigger > +# Concurrency error from ExecLockRows > > I think you don't need to mention above sentences in spec files. > Apart from that, your patch looks good to me. I have marked it as > Ready For Committ

Re: PATCH: Configurable file mode mask

2018-02-27 Thread Michael Paquier
On Tue, Feb 27, 2018 at 03:52:32PM -0500, David Steele wrote: > On 1/30/18 3:01 AM, Michael Paquier wrote: > The purpose of this test to be ensure nothing else is in the directory. > As the tests get more complex I think keeping track of the state will be > important. In other words, this is reall

Re: Server won't start with fallback setting by initdb.

2018-02-27 Thread Michael Paquier
On Wed, Feb 14, 2018 at 10:08:06AM +0900, Kyotaro HORIGUCHI wrote: > Definitely. The another rationale for the value is that regtest > fails with the numbers less than 20. So it's not 11 but > 20. Currently regtest should succeed with that number of > connections as written in parallel_schedule and

<    1   2