Re: windows resource files, bugs and what do we actually want

2022-09-06 Thread Peter Eisentraut
On 30.08.22 00:13, Andres Freund wrote: 1) For make based builds, all libraries that are built with MODULES rather than MODULES_big have the wrong "FILETYPE", because Makefile.win32 checks $(shlib), which is only set for MODULES_big. This used to be even more widely wrong until recen

Re: windows resource files, bugs and what do we actually want

2022-09-02 Thread Magnus Hagander
On Fri, Sep 2, 2022 at 3:26 AM Andres Freund wrote: > Hi, > > On 2022-08-29 15:13:14 -0700, Andres Freund wrote: > > 1) For make based builds, all libraries that are built with MODULES > rather > >than MODULES_big have the wrong "FILETYPE", because Makefile.win32 > checks > >$(shlib), whi

Re: windows resource files, bugs and what do we actually want

2022-09-01 Thread Andres Freund
Hi, On 2022-08-29 15:13:14 -0700, Andres Freund wrote: > 1) For make based builds, all libraries that are built with MODULES rather >than MODULES_big have the wrong "FILETYPE", because Makefile.win32 checks >$(shlib), which is only set for MODULES_big. > >This used to be even more wid

Re: windows resource files, bugs and what do we actually want

2022-09-01 Thread Magnus Hagander
On Thu, Sep 1, 2022 at 11:22 PM Andres Freund wrote: > Hi, > > On 2022-09-01 22:34:07 +0200, Magnus Hagander wrote: > > 4) We include the date, excluding 0 for some mysterious reason, in the > > > version > > >number. This seems to unnecessarily contribute to making the build > not > > >r

Re: windows resource files, bugs and what do we actually want

2022-09-01 Thread Andres Freund
Hi, On 2022-09-01 22:34:07 +0200, Magnus Hagander wrote: > 4) We include the date, excluding 0 for some mysterious reason, in the > > version > >number. This seems to unnecessarily contribute to making the build not > >reproducible. Hails from long ago: > > > >commit 9af932075098bd3c14

Re: windows resource files, bugs and what do we actually want

2022-09-01 Thread Magnus Hagander
On Tue, Aug 30, 2022 at 12:13 AM Andres Freund wrote: > Hi, > > A few things about the windows resource files we generate > > 1) For make based builds, all libraries that are built with MODULES rather >than MODULES_big have the wrong "FILETYPE", because Makefile.win32 > checks >$(shlib),

windows resource files, bugs and what do we actually want

2022-08-29 Thread Andres Freund
Hi, A few things about the windows resource files we generate 1) For make based builds, all libraries that are built with MODULES rather than MODULES_big have the wrong "FILETYPE", because Makefile.win32 checks $(shlib), which is only set for MODULES_big. This used to be even more widel