On Sat, Feb 26, 2022 at 9:17 PM Melanie Plageman
wrote:
>
> On Fri, Feb 25, 2022 at 11:17 PM Amit Kapila wrote:
> >
> > On Sat, Feb 26, 2022 at 3:01 AM Melanie Plageman
> > wrote:
> > >
> > > Since _hash_alloc_buckets() WAL-logs the last page of the
> > > splitpoint, is it safe to skip the smgri
On Fri, Feb 25, 2022 at 11:17 PM Amit Kapila wrote:
>
> On Sat, Feb 26, 2022 at 3:01 AM Melanie Plageman
> wrote:
> >
> > Since _hash_alloc_buckets() WAL-logs the last page of the
> > splitpoint, is it safe to skip the smgrimmedsync()? What if the last
> > page of the splitpoint doesn't end up ha
On Sat, Feb 26, 2022 at 3:01 AM Melanie Plageman
wrote:
>
> Since _hash_alloc_buckets() WAL-logs the last page of the
> splitpoint, is it safe to skip the smgrimmedsync()? What if the last
> page of the splitpoint doesn't end up having any tuples added to it
> during the index build and the redo p
On Thu, Feb 24, 2022 at 10:24 PM Amit Kapila wrote:
>
> On Fri, Feb 25, 2022 at 4:41 AM Melanie Plageman
> wrote:
> >
> > I'm trying to understand why hash indexes are built primarily in shared
> > buffers except when allocating a new splitpoint's worth of bucket pages
> > -- which is done with s
On Fri, Feb 25, 2022 at 8:54 AM Amit Kapila wrote:
>
> On Fri, Feb 25, 2022 at 4:41 AM Melanie Plageman
> wrote:
> >
> > I'm trying to understand why hash indexes are built primarily in shared
> > buffers except when allocating a new splitpoint's worth of bucket pages
> > -- which is done with sm
On Fri, Feb 25, 2022 at 4:41 AM Melanie Plageman
wrote:
>
> I'm trying to understand why hash indexes are built primarily in shared
> buffers except when allocating a new splitpoint's worth of bucket pages
> -- which is done with smgrextend() directly in _hash_alloc_buckets().
>
> Is this just so
I'm trying to understand why hash indexes are built primarily in shared
buffers except when allocating a new splitpoint's worth of bucket pages
-- which is done with smgrextend() directly in _hash_alloc_buckets().
Is this just so that the value returned by smgrnblocks() includes the
new splitpoint
