Re: walmethods.c/h are doing some strange things

2022-09-19 Thread Robert Haas
On Thu, Sep 15, 2022 at 9:39 PM Kyotaro Horiguchi wrote: > At Fri, 2 Sep 2022 11:52:38 -0400, Robert Haas wrote > in > > that type that can ever exist, and the pointer to that object is > > stored in a global variable managed by walmethods.c. So whereas in > > other cases we give you the object

Re: walmethods.c/h are doing some strange things

2022-09-15 Thread Kyotaro Horiguchi
At Fri, 2 Sep 2022 11:52:38 -0400, Robert Haas wrote in > that type that can ever exist, and the pointer to that object is > stored in a global variable managed by walmethods.c. So whereas in > other cases we give you the object and then a way to get the > corresponding set of callbacks, here we

Re: walmethods.c/h are doing some strange things

2022-09-15 Thread velagandula sravan kumar
From: Robert Haas Date: Friday, 2 September 2022 at 9:23 PM To: pgsql-hack...@postgresql.org Subject: walmethods.c/h are doing some strange things Hi, We have a number of places in the system where we are using object-oriented design patterns. For example, a foreign data wrapper returns a

Re: walmethods.c/h are doing some strange things

2022-09-12 Thread Peter Eisentraut
On 02.09.22 17:52, Robert Haas wrote: Attached are a couple of hastily-written patches implementing this. There might be good arguments for more thoroughly renaming some of the things these patches touch, but I thought that doing any more renaming would make it less clear what the core of the cha

walmethods.c/h are doing some strange things

2022-09-02 Thread Robert Haas
Hi, We have a number of places in the system where we are using object-oriented design patterns. For example, a foreign data wrapper returns a table of function pointers which are basically methods for operating on a planner or executor node that corresponds to a foreign table that uses that forei