Re: wal_dump output on CREATE DATABASE

2018-11-20 Thread Jean-Christophe Arnu
Le mar. 20 nov. 2018 à 13:34, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> a écrit : > On 16/11/2018 17:28, Jean-Christophe Arnu wrote: > > On the other hand, there's a consensus not to go further than the > > initial patch. > > I have committed your original patch. > > Great, thank you Pe

Re: wal_dump output on CREATE DATABASE

2018-11-20 Thread Peter Eisentraut
On 16/11/2018 17:28, Jean-Christophe Arnu wrote: > On the other hand, there's a consensus not to go further than the > initial patch. I have committed your original patch. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Se

Re: wal_dump output on CREATE DATABASE

2018-11-16 Thread Jean-Christophe Arnu
Le ven. 16 nov. 2018 à 14:32, Tomas Vondra a écrit : > > > > appendStringInfo(buf, "xid %u (db/rel) %u/%u ", > > xlrec->locks[i].xid, xlrec->locks[i].dbOid, > > xlrec->locks[i].relOid); > > > > > > As I said, I don't know whether it's re

Re: wal_dump output on CREATE DATABASE

2018-11-16 Thread Tomas Vondra
On 11/16/18 12:05 PM, Jean-Christophe Arnu wrote: Le jeu. 15 nov. 2018 à 19:44, Robert Haas > a écrit : On Tue, Nov 13, 2018 at 3:40 PM Tomas Vondra mailto:tomas.von...@2ndquadrant.com>> wrote: > People reading pg_waldump output quickly learn

Re: wal_dump output on CREATE DATABASE

2018-11-16 Thread Michael Paquier
On Fri, Nov 16, 2018 at 12:05:00PM +0100, Jean-Christophe Arnu wrote: > As I said, I don't know whether it's relevant to perform these changes or > not. If the A/B/C notation is to be generalized, it would be worth document > it > in the SGML file. If not, the first patch provided should be enou

Re: wal_dump output on CREATE DATABASE

2018-11-16 Thread Jean-Christophe Arnu
Le jeu. 15 nov. 2018 à 19:44, Robert Haas a écrit : > On Tue, Nov 13, 2018 at 3:40 PM Tomas Vondra > wrote: > > People reading pg_waldump output quickly learn to read the A/B/C format > > and what those fields mean. Breaking that into ts=A db=B relfilenode=C > > does not make that particularly c

Re: wal_dump output on CREATE DATABASE

2018-11-15 Thread Robert Haas
On Tue, Nov 13, 2018 at 3:40 PM Tomas Vondra wrote: > People reading pg_waldump output quickly learn to read the A/B/C format > and what those fields mean. Breaking that into ts=A db=B relfilenode=C > does not make that particularly clearer or easier to read. I'd say it'd > also makes it harder to

Re: wal_dump output on CREATE DATABASE

2018-11-13 Thread Michael Paquier
On Tue, Nov 13, 2018 at 09:39:55PM +0100, Tomas Vondra wrote: > So -1 to this from me. I'd just swap the fields in the copy dir message > and call it a day. +1. Using the opposite order when what is actually a database path is kind of confusing.. -- Michael signature.asc Description: PGP signat

Re: wal_dump output on CREATE DATABASE

2018-11-13 Thread Tomas Vondra
On Tue, 2018-11-13 at 18:53 +0100, Jean-Christophe Arnu wrote: > Le lun. 5 nov. 2018 à 15:37, Jean-Christophe Arnu > a > écrit : > > > > > > > Le dim. 4 nov. 2018 à 18:01, Jean-Christophe Arnu > > a > > écrit : > > > > > Le ven. 2 nov. 2018 à 08:37, Peter Eisentraut < > > > peter.eisentr...@2

Re: wal_dump output on CREATE DATABASE

2018-11-13 Thread Tomas Vondra
On Tue, 2018-11-13 at 12:24 -0800, Andres Freund wrote: > Hi, > > On 2018-11-13 17:18:32 -0300, Alvaro Herrera wrote: > > On 2018-Nov-13, Peter Eisentraut wrote: > > > > > On 13/11/2018 18:53, Jean-Christophe Arnu wrote: > > > > May I request any update on my (not so important) proposal ? > > >

Re: wal_dump output on CREATE DATABASE

2018-11-13 Thread Andres Freund
Hi, On 2018-11-13 17:18:32 -0300, Alvaro Herrera wrote: > On 2018-Nov-13, Peter Eisentraut wrote: > > > On 13/11/2018 18:53, Jean-Christophe Arnu wrote: > > > May I request any update on my (not so important) proposal ? > > > > Other opinions out there perhaps? I think your proposals are good,

Re: wal_dump output on CREATE DATABASE

2018-11-13 Thread Alvaro Herrera
On 2018-Nov-13, Peter Eisentraut wrote: > On 13/11/2018 18:53, Jean-Christophe Arnu wrote: > > May I request any update on my (not so important) proposal ? > > Other opinions out there perhaps? I think your proposals are good, but > I'm not sure to what extent people are automatically parsing th

Re: wal_dump output on CREATE DATABASE

2018-11-13 Thread Peter Eisentraut
On 13/11/2018 18:53, Jean-Christophe Arnu wrote: > May I request any update on my (not so important) proposal ? Other opinions out there perhaps? I think your proposals are good, but I'm not sure to what extent people are automatically parsing the pg_waldump output and are relying on a particular

Re: wal_dump output on CREATE DATABASE

2018-11-13 Thread Jean-Christophe Arnu
Le lun. 5 nov. 2018 à 15:37, Jean-Christophe Arnu a écrit : > > > Le dim. 4 nov. 2018 à 18:01, Jean-Christophe Arnu a > écrit : > >> Le ven. 2 nov. 2018 à 08:37, Peter Eisentraut < >> peter.eisentr...@2ndquadrant.com> a écrit : >> >>> On 26/10/2018 15:53, Jean-Christophe Arnu wrote: >>> > Exempl

Re: wal_dump output on CREATE DATABASE

2018-11-05 Thread Jean-Christophe Arnu
Le dim. 4 nov. 2018 à 18:01, Jean-Christophe Arnu a écrit : > Le ven. 2 nov. 2018 à 08:37, Peter Eisentraut < > peter.eisentr...@2ndquadrant.com> a écrit : > >> On 26/10/2018 15:53, Jean-Christophe Arnu wrote: >> > Exemple on CREATE DATABASE (without defining a template database) : >> > rmgr: Dat

Re: wal_dump output on CREATE DATABASE

2018-11-04 Thread Jean-Christophe Arnu
Le ven. 2 nov. 2018 à 08:37, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> a écrit : > On 26/10/2018 15:53, Jean-Christophe Arnu wrote: > > Exemple on CREATE DATABASE (without defining a template database) : > > rmgr: Databaselen (rec/tot): 42/42, tx:568, lsn: > > 0/0186

Re: wal_dump output on CREATE DATABASE

2018-11-02 Thread Peter Eisentraut
On 26/10/2018 15:53, Jean-Christophe Arnu wrote: > Exemple on CREATE DATABASE (without defining a template database) : > rmgr: Database    len (rec/tot): 42/    42, tx:    568, lsn: > 0/01865790, prev 0/01865720, desc: CREATE copy dir 1/1663 to 16384/1663 > > It comes out (to me) it may be

wal_dump output on CREATE DATABASE

2018-10-26 Thread Jean-Christophe Arnu
Dear hackers, This is my first try to post on that list to propose a workaround on an issue I noticed while using pg_waldump. Each time an object is referenced by "oids" following output template : tablespace oid/database oid/relfilenodeid That template seems to be used for each operation but t