Re: valgrind issues on Fedora 28

2019-01-07 Thread Tomas Vondra
On 12/15/18 12:32 AM, Andrew Dunstan wrote: > > On 12/14/18 4:35 PM, Tomas Vondra wrote: >> On 12/14/18 4:58 PM, Tom Lane wrote: >>> ... >>> >>> In general, I'm not particularly on board with our valgrind.supp >>> carrying suppressions for code outside our own code base: I think >>> that's assumin

Re: valgrind issues on Fedora 28

2018-12-14 Thread Andrew Dunstan
On 12/14/18 4:35 PM, Tomas Vondra wrote: > On 12/14/18 4:58 PM, Tom Lane wrote: >> ... >> >> In general, I'm not particularly on board with our valgrind.supp >> carrying suppressions for code outside our own code base: I think >> that's assuming WAY too much about which version of what is install

Re: valgrind issues on Fedora 28

2018-12-14 Thread Tomas Vondra
On 12/14/18 4:58 PM, Tom Lane wrote: > ... > > In general, I'm not particularly on board with our valgrind.supp > carrying suppressions for code outside our own code base: I think > that's assuming WAY too much about which version of what is installed > on a particular box. > Fair point. > Ma

Re: valgrind issues on Fedora 28

2018-12-14 Thread Tom Lane
Tomas Vondra writes: > On 12/14/18 5:10 AM, Tom Lane wrote: >> So I just got around to trying to do some valgrind testing for the first >> time in a couple of months, and what I find is that this patch completely >> breaks valgrind for me ... >> This is valgrind 3.8.1 (RHEL6's version), so not ble

Re: valgrind issues on Fedora 28

2018-12-14 Thread Tomas Vondra
On 12/14/18 5:10 AM, Tom Lane wrote: > Tomas Vondra writes: >> On 11/8/18 1:07 PM, Tomas Vondra wrote: >>> Not sure what to do about this - maybe we should wildcard this first >>> frame, to accept all wcsnlen variants. Opinions? > >> I've committed this with the first frame wirldcarded, and backp

Re: valgrind issues on Fedora 28

2018-12-13 Thread Tom Lane
Tomas Vondra writes: > On 11/8/18 1:07 PM, Tomas Vondra wrote: >> Not sure what to do about this - maybe we should wildcard this first >> frame, to accept all wcsnlen variants. Opinions? > I've committed this with the first frame wirldcarded, and backpatched it > all the way back to 9.4. So I ju

Re: valgrind issues on Fedora 28

2018-11-17 Thread Tomas Vondra
On 11/8/18 1:07 PM, Tomas Vondra wrote: > On 11/6/18 6:51 PM, Tomas Vondra wrote: >> On 11/6/18 6:35 PM, Alvaro Herrera wrote: >>> On 2018-Nov-06, Tomas Vondra wrote: >>> Hi, I've recently updated to Fedora 28, and in that environment I get quite a few new valgrind issues (

Re: valgrind issues on Fedora 28

2018-11-08 Thread Tomas Vondra
On 11/6/18 6:51 PM, Tomas Vondra wrote: > On 11/6/18 6:35 PM, Alvaro Herrera wrote: >> On 2018-Nov-06, Tomas Vondra wrote: >> >>> Hi, >>> >>> I've recently updated to Fedora 28, and in that environment I get >>> quite a >>> few new valgrind issues (see the attached log). >> >> Hmm, related to >> ht

Re: valgrind issues on Fedora 28

2018-11-06 Thread Tomas Vondra
On 11/6/18 6:35 PM, Alvaro Herrera wrote: On 2018-Nov-06, Tomas Vondra wrote: Hi, I've recently updated to Fedora 28, and in that environment I get quite a few new valgrind issues (see the attached log). Hmm, related to https://postgr.es/m/20180220150838.GD18315@e733.localdomain ? Apparently

Re: valgrind issues on Fedora 28

2018-11-06 Thread Tomas Vondra
On 11/6/18 6:35 PM, Andres Freund wrote: On 2018-11-06 18:24:55 +0100, Tomas Vondra wrote: I've recently updated to Fedora 28, and in that environment I get quite a few new valgrind issues (see the attached log). Essentially, all the reports start with either ==5971== Invalid read of size 32 =

Re: valgrind issues on Fedora 28

2018-11-06 Thread Alvaro Herrera
On 2018-Nov-06, Tomas Vondra wrote: > Hi, > > I've recently updated to Fedora 28, and in that environment I get quite a > few new valgrind issues (see the attached log). Hmm, related to https://postgr.es/m/20180220150838.GD18315@e733.localdomain ? Apparently the right answer is to add local supp

Re: valgrind issues on Fedora 28

2018-11-06 Thread Andres Freund
On 2018-11-06 18:24:55 +0100, Tomas Vondra wrote: > I've recently updated to Fedora 28, and in that environment I get quite a > few new valgrind issues (see the attached log). > > Essentially, all the reports start with either > > ==5971== Invalid read of size 32 > ==5971==at 0x5957EB1: __wcs