Re: v13: CLUSTER segv with wal_level=minimal and parallel index creation

2020-09-10 Thread Kyotaro Horiguchi
At Wed, 09 Sep 2020 14:40:37 +0900 (JST), Kyotaro Horiguchi wrote in > Sure. relNode is filled with zeros so RelationInitPhysicalAddr() works > correctly for RelationBuildDesc(). > > Both changes look good to me. Thank you for committing this! regards. -- Kyotaro Horiguchi NTT Open Source So

Re: v13: CLUSTER segv with wal_level=minimal and parallel index creation

2020-09-08 Thread Kyotaro Horiguchi
Thank you for the checking. At Tue, 8 Sep 2020 21:05:43 -0700, Noah Misch wrote in > On Mon, Sep 07, 2020 at 07:47:09PM -0700, Noah Misch wrote: > After looking closer, I've moved the test to reindex_catalog.sql; see that > file's header comment for the reasons. One now needs this command: > >

Re: v13: CLUSTER segv with wal_level=minimal and parallel index creation

2020-09-08 Thread Noah Misch
On Mon, Sep 07, 2020 at 07:47:09PM -0700, Noah Misch wrote: > On Tue, Sep 08, 2020 at 10:43:32AM +0900, Kyotaro Horiguchi wrote: > > At Tue, 08 Sep 2020 09:13:53 +0900 (JST), Kyotaro Horiguchi > > wrote in > > > At Mon, 7 Sep 2020 02:32:55 -0700, Noah Misch wrote > > > in > > > > As a PoC, th

Re: v13: CLUSTER segv with wal_level=minimal and parallel index creation

2020-09-07 Thread Noah Misch
On Tue, Sep 08, 2020 at 10:43:32AM +0900, Kyotaro Horiguchi wrote: > At Tue, 08 Sep 2020 09:13:53 +0900 (JST), Kyotaro Horiguchi > wrote in > > At Mon, 7 Sep 2020 02:32:55 -0700, Noah Misch wrote in > > > As a PoC, this looks promising. Thanks. Would you add a test case such > > > that > >

Re: v13: CLUSTER segv with wal_level=minimal and parallel index creation

2020-09-07 Thread Kyotaro Horiguchi
At Tue, 08 Sep 2020 09:13:53 +0900 (JST), Kyotaro Horiguchi wrote in > At Mon, 7 Sep 2020 02:32:55 -0700, Noah Misch wrote in > > As a PoC, this looks promising. Thanks. Would you add a test case such > > that > > the following demonstrates the bug in the absence of your PoC? > > > > pri

Re: v13: CLUSTER segv with wal_level=minimal and parallel index creation

2020-09-07 Thread Kyotaro Horiguchi
At Mon, 7 Sep 2020 02:32:55 -0700, Noah Misch wrote in > On Mon, Sep 07, 2020 at 05:40:36PM +0900, Kyotaro Horiguchi wrote: > > At Mon, 07 Sep 2020 13:45:28 +0900 (JST), Kyotaro Horiguchi > > wrote in > > > The cause is that the worker had received pending-sync entry correctly > > > but not ne

Re: v13: CLUSTER segv with wal_level=minimal and parallel index creation

2020-09-07 Thread Noah Misch
On Mon, Sep 07, 2020 at 05:40:36PM +0900, Kyotaro Horiguchi wrote: > At Mon, 07 Sep 2020 13:45:28 +0900 (JST), Kyotaro Horiguchi > wrote in > > The cause is that the worker had received pending-sync entry correctly > > but not never created a relcache entry for the relation using > > RelationBui

Re: v13: CLUSTER segv with wal_level=minimal and parallel index creation

2020-09-07 Thread Kyotaro Horiguchi
At Mon, 07 Sep 2020 13:45:28 +0900 (JST), Kyotaro Horiguchi wrote in > The cause is that the worker had received pending-sync entry correctly > but not never created a relcache entry for the relation using > RelationBuildDesc. So the rd_firstRelfilenodeSubid is not correctly > set. > > I'm inve

Re: v13: CLUSTER segv with wal_level=minimal and parallel index creation

2020-09-06 Thread Kyotaro Horiguchi
At Mon, 07 Sep 2020 00:33:03 -0400, Tom Lane wrote in > Justin Pryzby writes: > > This is easily reproduced, at least on pg_attribute Thanks for the repro. > Yeah, duplicated here. The assertion (not SIGSEGV) is in code > added by c6b92041d, so it seems clearly an open issue for v13. > > I d

Re: v13: CLUSTER segv with wal_level=minimal and parallel index creation

2020-09-06 Thread Tom Lane
Justin Pryzby writes: > This is easily reproduced, at least on pg_attribute Yeah, duplicated here. The assertion (not SIGSEGV) is in code added by c6b92041d, so it seems clearly an open issue for v13. I did not check to see what happens in a non-assert build. regards, t

Re: v13: CLUSTER segv with wal_level=minimal and parallel index creation

2020-09-06 Thread Justin Pryzby
This is easily reproduced, at least on pg_attribute [pryzbyj@localhost ~]$ /usr/pgsql-13/bin/initdb -D pgsql13.dat [pryzbyj@localhost ~]$ /usr/pgsql-13/bin/postgres -D pgsql13.dat -c logging_collector=off -c port=5678 -c unix_socket_directories=/tmp -c wal-level=minimal -c max_wal_senders=0& [pr

v13: CLUSTER segv with wal_level=minimal and parallel index creation

2020-09-06 Thread Justin Pryzby
Following a bulk load, a CLUSTER command run by a maintenance script crashed. This is currently reproducible on that instance, so please suggest if I can provide more info. < 2020-09-06 15:44:16.369 MDT >LOG: background worker "parallel worker" (PID 2576) was terminated by signal 6: Aborted < 2