Re: table_tuple_lock's snapshot argument

2025-03-11 Thread Heikki Linnakangas
On 10/03/2025 18:20, Ranier Vilela wrote: Just for curiosity. *RelationFindReplTupleSeq* on the same source, does not suffer from the same issue? PushActiveSnapshot(GetLatestSnapshot()); res = table_tuple_lock(rel, &(outslot->tts_tid), GetLatestSnapshot(), :facepalm: yep, it sure does, and Fi

Re: table_tuple_lock's snapshot argument

2025-03-11 Thread Ranier Vilela
Em seg., 10 de mar. de 2025 às 12:22, Heikki Linnakangas escreveu: > On 21/01/2025 12:05, Alexander Korotkov wrote: > > On Tue, Jan 21, 2025 at 12:03 PM Alexander Korotkov > > wrote: > >> On Sun, Dec 29, 2024 at 3:59 PM Heikki Linnakangas > wrote: > >>> However, I think GetLatestSnapshot() is w

Re: table_tuple_lock's snapshot argument

2025-03-11 Thread Ranier Vilela
Em seg., 10 de mar. de 2025 às 13:52, Heikki Linnakangas escreveu: > On 10/03/2025 18:20, Ranier Vilela wrote: > > Just for curiosity. > > *RelationFindReplTupleSeq* on the same source, does not suffer > > from the same issue? > > > > PushActiveSnapshot(GetLatestSnapshot()); > > > > res = table_t

Re: table_tuple_lock's snapshot argument

2025-03-10 Thread Heikki Linnakangas
On 21/01/2025 12:05, Alexander Korotkov wrote: On Tue, Jan 21, 2025 at 12:03 PM Alexander Korotkov wrote: On Sun, Dec 29, 2024 at 3:59 PM Heikki Linnakangas wrote: However, I think GetLatestSnapshot() is wrong here anyway. None of this matters for heapam which just ignores the 'snapshot' argu

Re: table_tuple_lock's snapshot argument

2025-01-21 Thread Alexander Korotkov
On Tue, Jan 21, 2025 at 12:03 PM Alexander Korotkov wrote: > On Sun, Dec 29, 2024 at 3:59 PM Heikki Linnakangas wrote: > > > > > /* > > > * Lock a tuple in the specified mode. > > > * > > > * Input parameters: > > > *relation: relation containing tuple (caller must hold suitable lock) > >

Re: table_tuple_lock's snapshot argument

2025-01-21 Thread Alexander Korotkov
Hi! On Sun, Dec 29, 2024 at 3:59 PM Heikki Linnakangas wrote: > > > /* > > * Lock a tuple in the specified mode. > > * > > * Input parameters: > > *relation: relation containing tuple (caller must hold suitable lock) > > *tid: TID of tuple to lock > > *snapshot: snapshot to use

table_tuple_lock's snapshot argument

2024-12-29 Thread Heikki Linnakangas
/* * Lock a tuple in the specified mode. * * Input parameters: * relation: relation containing tuple (caller must hold suitable lock) * tid: TID of tuple to lock * snapshot: snapshot to use for visibility determinations * cid: current command ID (used for visibility test