Re: table partitioning and access privileges

2020-02-17 Thread Fujii Masao
On 2020/02/17 17:13, Amit Langote wrote: On Mon, Feb 17, 2020 at 4:59 PM Fujii Masao wrote: On 2020/02/14 10:28, Amit Langote wrote: On Thu, Feb 13, 2020 at 8:39 PM Fujii Masao wrote: We can verify that even "LOCK TABLE ONLY" command works expectedly on the inherited tables by keeping t

Re: table partitioning and access privileges

2020-02-17 Thread Amit Langote
On Mon, Feb 17, 2020 at 4:59 PM Fujii Masao wrote: > On 2020/02/14 10:28, Amit Langote wrote: > > On Thu, Feb 13, 2020 at 8:39 PM Fujii Masao > > wrote: > >> We can verify that even "LOCK TABLE ONLY" command works > >> expectedly on the inherited tables by keeping those SQLs in the > >> regress

Re: table partitioning and access privileges

2020-02-17 Thread Fujii Masao
On 2020/02/14 10:28, Amit Langote wrote: On Thu, Feb 13, 2020 at 8:39 PM Fujii Masao wrote: On 2020/02/07 10:39, Amit Langote wrote: On Fri, Feb 7, 2020 at 1:16 AM Fujii Masao wrote: Yes, so I will review your patch getting rid of LOCK TABLE exception. Attached updated patch. Thanks!

Re: table partitioning and access privileges

2020-02-13 Thread Amit Langote
On Thu, Feb 13, 2020 at 8:39 PM Fujii Masao wrote: > On 2020/02/07 10:39, Amit Langote wrote: > > On Fri, Feb 7, 2020 at 1:16 AM Fujii Masao > > wrote: > >> Yes, so I will review your patch getting rid of > >> LOCK TABLE exception. > > > > Attached updated patch. > > Thanks! This patch basically

Re: table partitioning and access privileges

2020-02-13 Thread Fujii Masao
On 2020/02/07 10:39, Amit Langote wrote: On Fri, Feb 7, 2020 at 1:16 AM Fujii Masao wrote: On 2020/02/03 14:26, Amit Langote wrote: On Mon, Feb 3, 2020 at 2:07 PM Fujii Masao wrote: On 2020/02/03 11:05, Amit Langote wrote: Okay. How about the attached? Thanks for the patches! You adde

Re: table partitioning and access privileges

2020-02-06 Thread Amit Langote
On Fri, Feb 7, 2020 at 1:16 AM Fujii Masao wrote: > On 2020/02/03 14:26, Amit Langote wrote: > > On Mon, Feb 3, 2020 at 2:07 PM Fujii Masao > > wrote: > >> On 2020/02/03 11:05, Amit Langote wrote: > >>> Okay. How about the attached? > >> > >> Thanks for the patches! You added the note just afte

Re: table partitioning and access privileges

2020-02-06 Thread Fujii Masao
On 2020/02/03 14:26, Amit Langote wrote: On Mon, Feb 3, 2020 at 2:07 PM Fujii Masao wrote: On 2020/02/03 11:05, Amit Langote wrote: Okay. How about the attached? Thanks for the patches! You added the note just after the description about row level security on inherited table, but isn't i

Re: table partitioning and access privileges

2020-02-02 Thread Amit Langote
On Mon, Feb 3, 2020 at 2:07 PM Fujii Masao wrote: > On 2020/02/03 11:05, Amit Langote wrote: > > Okay. How about the attached? > > Thanks for the patches! You added the note just after the description > about row level security on inherited table, but isn't it better to > add it before that? Atta

Re: table partitioning and access privileges

2020-02-02 Thread Fujii Masao
On 2020/02/03 11:05, Amit Langote wrote: On Fri, Jan 31, 2020 at 9:39 PM Fujii Masao wrote: On 2020/01/31 13:38, Amit Langote wrote: On Fri, Jan 31, 2020 at 1:28 AM Fujii Masao wrote: Fair enough. I finally did back-patch because the behavior is clearly documented and I failed to hear the

Re: table partitioning and access privileges

2020-02-02 Thread Amit Langote
On Fri, Jan 31, 2020 at 9:39 PM Fujii Masao wrote: > On 2020/01/31 13:38, Amit Langote wrote: > > On Fri, Jan 31, 2020 at 1:28 AM Fujii Masao > > wrote: > >> Fair enough. I finally did back-patch because the behavior is clearly > >> documented and I failed to hear the opinions to object the back

Re: table partitioning and access privileges

2020-01-31 Thread Fujii Masao
On 2020/01/31 13:38, Amit Langote wrote: On Fri, Jan 31, 2020 at 1:28 AM Fujii Masao wrote: On 2020/01/31 1:02, Tom Lane wrote: Fujii Masao writes: Thanks for updating the patch! Barring any objection, I will commit this fix and backport it to all supported versions. Sorry for not havin

Re: table partitioning and access privileges

2020-01-30 Thread Amit Langote
On Fri, Jan 31, 2020 at 1:28 AM Fujii Masao wrote: > On 2020/01/31 1:02, Tom Lane wrote: > > Fujii Masao writes: > >> Thanks for updating the patch! Barring any objection, > >> I will commit this fix and backport it to all supported versions. > > > > Sorry for not having paid closer attention to

Re: table partitioning and access privileges

2020-01-30 Thread Tom Lane
Fujii Masao writes: > On 2020/01/31 1:28, Fujii Masao wrote: >> On 2020/01/31 1:02, Tom Lane wrote: >>> Sorry for not having paid closer attention to this thread, but ... >>> is back-patching this behavioral change really a good idea? > I'm thinking to wait at least half a day before reverting >

Re: table partitioning and access privileges

2020-01-30 Thread Fujii Masao
On 2020/01/31 1:28, Fujii Masao wrote: On 2020/01/31 1:02, Tom Lane wrote: Fujii Masao writes: Thanks for updating the patch! Barring any objection, I will commit this fix and backport it to all supported versions. Sorry for not having paid closer attention to this thread, but ... is ba

Re: table partitioning and access privileges

2020-01-30 Thread Fujii Masao
On 2020/01/31 1:02, Tom Lane wrote: Fujii Masao writes: Thanks for updating the patch! Barring any objection, I will commit this fix and backport it to all supported versions. Sorry for not having paid closer attention to this thread, but ... is back-patching this behavioral change really

Re: table partitioning and access privileges

2020-01-30 Thread Tom Lane
Fujii Masao writes: > Thanks for updating the patch! Barring any objection, > I will commit this fix and backport it to all supported versions. Sorry for not having paid closer attention to this thread, but ... is back-patching this behavioral change really a good idea? It's not that hard to ima

Re: table partitioning and access privileges

2020-01-30 Thread Fujii Masao
On 2020/01/27 14:02, Amit Langote wrote: Fujii-san, On Mon, Jan 27, 2020 at 11:19 AM Fujii Masao wrote: On 2020/01/23 22:14, Fujii Masao wrote: Thanks for updating the patch! Barring any objection, I will commit this fix and backport it to all supported versions. Attached are the back-po

Re: table partitioning and access privileges

2020-01-26 Thread Amit Langote
Fujii-san, On Mon, Jan 27, 2020 at 11:19 AM Fujii Masao wrote: > On 2020/01/23 22:14, Fujii Masao wrote: > > Thanks for updating the patch! Barring any objection, > > I will commit this fix and backport it to all supported versions. > > Attached are the back-port versions of the patches. > > > Th

Re: table partitioning and access privileges

2020-01-26 Thread Fujii Masao
On 2020/01/23 22:14, Fujii Masao wrote: On 2020/01/22 16:54, Amit Langote wrote: Fujii-san, Thanks for taking a look. On Fri, Jan 10, 2020 at 10:29 AM Fujii Masao wrote: On Tue, Jan 7, 2020 at 5:15 PM Amit Langote wrote: I tend to agree that TRUNCATE's permission model for inheritance

Re: table partitioning and access privileges

2020-01-23 Thread Fujii Masao
On 2020/01/22 16:54, Amit Langote wrote: Fujii-san, Thanks for taking a look. On Fri, Jan 10, 2020 at 10:29 AM Fujii Masao wrote: On Tue, Jan 7, 2020 at 5:15 PM Amit Langote wrote: I tend to agree that TRUNCATE's permission model for inheritance should be consistent with that for the oth

Re: table partitioning and access privileges

2020-01-21 Thread Amit Langote
Fujii-san, Thanks for taking a look. On Fri, Jan 10, 2020 at 10:29 AM Fujii Masao wrote: > On Tue, Jan 7, 2020 at 5:15 PM Amit Langote wrote: > > I tend to agree that TRUNCATE's permission model for inheritance > > should be consistent with that for the other commands. How about the > > attach

Re: table partitioning and access privileges

2020-01-09 Thread Fujii Masao
On Tue, Jan 7, 2020 at 5:15 PM Amit Langote wrote: > > On Fri, Dec 27, 2019 at 4:26 AM Tom Lane wrote: > > Fujii Masao writes: > > > My customer reported me that the queries through a partitioned table > > > ignore each partition's SELECT, INSERT, UPDATE, and DELETE privileges, > > > on the othe

Re: table partitioning and access privileges

2020-01-07 Thread Amit Langote
On Fri, Dec 27, 2019 at 4:26 AM Tom Lane wrote: > Fujii Masao writes: > > My customer reported me that the queries through a partitioned table > > ignore each partition's SELECT, INSERT, UPDATE, and DELETE privileges, > > on the other hand, only TRUNCATE privilege specified for each partition > >

Re: table partitioning and access privileges

2019-12-26 Thread Tom Lane
Fujii Masao writes: > My customer reported me that the queries through a partitioned table > ignore each partition's SELECT, INSERT, UPDATE, and DELETE privileges, > on the other hand, only TRUNCATE privilege specified for each partition > is applied. I'm not sure if this behavior is expected or n

table partitioning and access privileges

2019-12-25 Thread Fujii Masao
Hi, My customer reported me that the queries through a partitioned table ignore each partition's SELECT, INSERT, UPDATE, and DELETE privileges, on the other hand, only TRUNCATE privilege specified for each partition is applied. I'm not sure if this behavior is expected or not. But anyway is it bet