On Thu, Mar 21, 2024 at 3:19 PM Peter Eisentraut
wrote:
> On 07.03.24 17:54, Ashutosh Bapat wrote:
> > The pg_dump problems arise because we throw an error when parents have
> > conflicting compression and storage properties. The patch that got
> > reverted, changed this slightly by allowing a ch
On 07.03.24 17:54, Ashutosh Bapat wrote:
The pg_dump problems arise because we throw an error when parents have
conflicting compression and storage properties. The patch that got
reverted, changed this slightly by allowing a child to override parent's
properties even when they conflict. It stil
Hi Peter and Tom,
> On Tue, Feb 20, 2024 at 3:51 PM Peter Eisentraut
> wrote:
> > >
> > > I have reverted the patch for now (and re-opened the commitfest entry).
> > > We should continue to work on this and see if we can at least try to
> get
> > > the pg_dump test coverage suitable.
> > >
> >
>
On Fri, Feb 23, 2024 at 6:05 PM Ashutosh Bapat
wrote:
>
> On Tue, Feb 20, 2024 at 3:51 PM Peter Eisentraut wrote:
> >
> > I have reverted the patch for now (and re-opened the commitfest entry).
> > We should continue to work on this and see if we can at least try to get
> > the pg_dump test cover
On Tue, Feb 20, 2024 at 3:51 PM Peter Eisentraut wrote:
>
> I have reverted the patch for now (and re-opened the commitfest entry).
> We should continue to work on this and see if we can at least try to get
> the pg_dump test coverage suitable.
>
I have started a separate thread for dump/restore
I have reverted the patch for now (and re-opened the commitfest entry).
We should continue to work on this and see if we can at least try to get
the pg_dump test coverage suitable.
On 19.02.24 12:34, Ashutosh Bapat wrote:
On Fri, Feb 16, 2024 at 11:54 PM Tom Lane wrote:
I wrote:
I find it
On Fri, Feb 16, 2024 at 11:54 PM Tom Lane wrote:
>
> I wrote:
> > I find it surprising that the committed patch does not touch
> > pg_dump. Is it really true that pg_dump dumps situations with
> > differing compression/storage settings accurately already?
>
> It's worse than I thought. Run "make
I wrote:
> I find it surprising that the committed patch does not touch
> pg_dump. Is it really true that pg_dump dumps situations with
> differing compression/storage settings accurately already?
It's worse than I thought. Run "make installcheck" with
today's HEAD, then:
$ pg_dump -Fc regressi
Peter Eisentraut writes:
> I have committed this. It is great to get this behavior fixed and also
> to get the internals more consistent. Thanks.
I find it surprising that the committed patch does not touch
pg_dump. Is it really true that pg_dump dumps situations with
differing compression/st
I have committed this. It is great to get this behavior fixed and also
to get the internals more consistent. Thanks.
On Mon, Feb 12, 2024 at 8:48 PM Peter Eisentraut wrote:
>
> On 08.02.24 08:20, Ashutosh Bapat wrote:
> > On Wed, Feb 7, 2024 at 12:47 PM Ashutosh Bapat
> > wrote:
> >
> >> 0001 fixes compression inheritance
> >> 0002 fixes storage inheritance
> >>
> >
> > The first patch does not update compressi
On 08.02.24 08:20, Ashutosh Bapat wrote:
On Wed, Feb 7, 2024 at 12:47 PM Ashutosh Bapat
wrote:
0001 fixes compression inheritance
0002 fixes storage inheritance
The first patch does not update compression_1.out which makes CI
unhappy. Here's patchset fixing that.
The changed behavior look
On Wed, Feb 7, 2024 at 12:47 PM Ashutosh Bapat
wrote:
> 0001 fixes compression inheritance
> 0002 fixes storage inheritance
>
The first patch does not update compression_1.out which makes CI
unhappy. Here's patchset fixing that.
--
Best Wishes,
Ashutosh Bapat
From 629db9289371d3e72dc6b0d43811
On Wed, Jan 31, 2024 at 1:29 PM Ashutosh Bapat
wrote:
>
> On Tue, Dec 5, 2023 at 6:28 PM Peter Eisentraut wrote:
> >
> > On 05.12.23 05:26, Ashutosh Bapat wrote:
> > >> - When inheriting from multiple parents with different settings, an
> > >> explicit setting in the child is required.
> > > When
On Tue, Dec 5, 2023 at 6:28 PM Peter Eisentraut wrote:
>
> On 05.12.23 05:26, Ashutosh Bapat wrote:
> >> - When inheriting from multiple parents with different settings, an
> >> explicit setting in the child is required.
> > When no explicit setting for child is specified, it will throw an
> > err
On 05.12.23 05:26, Ashutosh Bapat wrote:
- When inheriting from multiple parents with different settings, an
explicit setting in the child is required.
When no explicit setting for child is specified, it will throw an
error as it does today. Right?
Yes, it would throw an error, but a different
On Mon, Dec 4, 2023 at 4:23 PM Peter Eisentraut wrote:
>
> Looking at the code, I suspect these rules were just sort of
> copy-and-pasted from the nearby rules for types and collations. The
> latter are needed so that a table with inheritance children can present
> a logically consistent view of
I found the way that MergeAttributes() handles column compression and
storage settings very weird.
For example, I don't understand the purpose of this error:
create table t1 (a int, b text compression pglz);
create table t1a (b text compression lz4) inherits (t1);
...
ERROR: 42804: column "b"
18 matches
Mail list logo
