Re: strange valgrind reports about wrapper_handler on 64-bit arm

2025-03-09 Thread Tomas Vondra
On 3/9/25 03:16, Nathan Bossart wrote: > On Sat, Mar 08, 2025 at 11:48:22PM +0100, Tomas Vondra wrote: >> Shortly after restarting this I got three more reports - all of them are >> related to strcoll_l. This is on c472a18296e4, i.e. with the asserts >> added in this thread etc. But none of those s

Re: strange valgrind reports about wrapper_handler on 64-bit arm

2025-03-08 Thread Nathan Bossart
On Sat, Mar 08, 2025 at 11:48:22PM +0100, Tomas Vondra wrote: > Shortly after restarting this I got three more reports - all of them are > related to strcoll_l. This is on c472a18296e4, i.e. with the asserts > added in this thread etc. But none of those seem to fail. > ==189168==at 0xA683CC: w

Re: strange valgrind reports about wrapper_handler on 64-bit arm

2025-03-08 Thread Tomas Vondra
On 3/7/25 17:32, Andres Freund wrote: > Hi, > > On 2025-03-07 00:03:47 +0100, Tomas Vondra wrote: >> while running check-world on 64-bit arm (rpi5 with Debian 12.9), I got a >> couple reports like this: >> >> ==64550== Use of uninitialised value of size 8 >> ==64550==at 0xA62FE0: wrapper_ha

Re: strange valgrind reports about wrapper_handler on 64-bit arm

2025-03-08 Thread Tomas Vondra
On 3/8/25 21:38, Tomas Vondra wrote: > > I've restarted check-world with valgrind on my rpi5 machines, with > current master. I can try running other stuff once that finishes in a > couple hours. > Shortly after restarting this I got three more reports - all of them are related to strcoll_l. Thi

Re: strange valgrind reports about wrapper_handler on 64-bit arm

2025-03-07 Thread Nathan Bossart
On Fri, Mar 07, 2025 at 02:38:47PM -0600, Nathan Bossart wrote: > If that looks good, I'm planning to commit it. And committed. -- nathan

Re: strange valgrind reports about wrapper_handler on 64-bit arm

2025-03-07 Thread Nathan Bossart
On Fri, Mar 07, 2025 at 10:52:10AM -0600, Nathan Bossart wrote: > Good enough for me. I'll commit/back-patch to v17 the attached soon. On second thought, since the signal number is a signed integer, I think we also ought to check that it's > 0. I'm running the attached patch through the CI tests

Re: strange valgrind reports about wrapper_handler on 64-bit arm

2025-03-07 Thread Andres Freund
Hi, On 2025-03-07 00:03:47 +0100, Tomas Vondra wrote: > while running check-world on 64-bit arm (rpi5 with Debian 12.9), I got a > couple reports like this: > > ==64550== Use of uninitialised value of size 8 > ==64550==at 0xA62FE0: wrapper_handler (pqsignal.c:107) > ==64550==by 0x580BB9E7

Re: strange valgrind reports about wrapper_handler on 64-bit arm

2025-03-07 Thread Nathan Bossart
On Fri, Mar 07, 2025 at 11:41:38AM -0500, Andres Freund wrote: > On 2025-03-07 10:36:35 -0600, Nathan Bossart wrote: >> On Fri, Mar 07, 2025 at 11:32:28AM -0500, Andres Freund wrote: >> > Is it possible that the signal number we're getting called for is above >> > PG_NSIG? That'd explain why the so

Re: strange valgrind reports about wrapper_handler on 64-bit arm

2025-03-07 Thread Andres Freund
Hi, On 2025-03-07 10:36:35 -0600, Nathan Bossart wrote: > On Fri, Mar 07, 2025 at 11:32:28AM -0500, Andres Freund wrote: > > Is it possible that the signal number we're getting called for is above > > PG_NSIG? That'd explain why the source value is something fairly random? > > > > ISTM that we sh

Re: strange valgrind reports about wrapper_handler on 64-bit arm

2025-03-07 Thread Nathan Bossart
On Fri, Mar 07, 2025 at 11:32:28AM -0500, Andres Freund wrote: > Is it possible that the signal number we're getting called for is above > PG_NSIG? That'd explain why the source value is something fairly random? > > ISTM that we should add an Assert() to wrapper_handler() that ensures that the > s

Re: strange valgrind reports about wrapper_handler on 64-bit arm

2025-03-07 Thread Nathan Bossart
On Fri, Mar 07, 2025 at 12:03:47AM +0100, Tomas Vondra wrote: > while running check-world on 64-bit arm (rpi5 with Debian 12.9), I got a > couple reports like this: > > ==64550== Use of uninitialised value of size 8 > ==64550==at 0xA62FE0: wrapper_handler (pqsignal.c:107) > ==64550==by 0x5

strange valgrind reports about wrapper_handler on 64-bit arm

2025-03-06 Thread Tomas Vondra
Hi, while running check-world on 64-bit arm (rpi5 with Debian 12.9), I got a couple reports like this: ==64550== Use of uninitialised value of size 8 ==64550==at 0xA62FE0: wrapper_handler (pqsignal.c:107) ==64550==by 0x580BB9E7: ??? (in /usr/libexec/valgrind/memcheck-arm64-linux) ==64550=