Re: spin.c includes pg_sema.h even if unnecessary

2018-02-15 Thread Kyotaro HORIGUCHI
At Thu, 15 Feb 2018 10:01:57 -0800, Andres Freund wrote in <20180215180157.7q55aytrhif7v...@alap3.anarazel.de> > On 2018-02-15 20:11:07 +0900, Kyotaro HORIGUCHI wrote: > > As in another mail just before, spin.c seems a bit strange > > (without acutual harm). > > > > spin.h doesn't include pg_sem

Re: spin.c includes pg_sema.h even if unnecessary

2018-02-15 Thread Andres Freund
On 2018-02-15 20:11:07 +0900, Kyotaro HORIGUCHI wrote: > As in another mail just before, spin.c seems a bit strange > (without acutual harm). > > spin.h doesn't include pg_sema.h when HAVE_SPINLOCKS is defined, > but spin.c always includes it even in the case. The file is > included only to use si

spin.c includes pg_sema.h even if unnecessary

2018-02-15 Thread Kyotaro HORIGUCHI
Ouch! Sorry for the bogus subject of just-submitted mail. I'll make another thread with the fixed subject. Hello. As in another mail just before, spin.c seems a bit strange (without acutual harm). spin.h doesn't include pg_sema.h when HAVE_SPINLOCKS is defined, but spin.c always includes it