On Thu, 23 Feb 2023 at 16:38, Peter Eisentraut
wrote:
>
> On 20.02.23 15:03, Peter Eisentraut wrote:
> > On 15.02.23 19:04, Alvaro Herrera wrote:
> >> That said, I think most of this code is invoked for DDL, where
> >> performance is not so critical; probably just fixing
> >> get_object_property_d
On 20.02.23 15:03, Peter Eisentraut wrote:
On 15.02.23 19:04, Alvaro Herrera wrote:
That said, I think most of this code is invoked for DDL, where
performance is not so critical; probably just fixing
get_object_property_data to not be so naïve would suffice.
Ok, I'll look into that.
I did a
On 15.02.23 06:04, Tom Lane wrote:
I have
very serious concerns first about whether it even preserves the
existing semantics, and second about whether there is a performance
penalty.
We can work out the performance issues, but what are your concerns about
semantics?
On 15.02.23 19:04, Alvaro Herrera wrote:
That said, I think most of this code is invoked for DDL, where
performance is not so critical; probably just fixing
get_object_property_data to not be so naïve would suffice.
Ok, I'll look into that.
Queries are another matter. I can't think of a way
On Tue, Feb 14, 2023 at 02:32:04PM +0100, Peter Eisentraut wrote:
> Notes on 0001-Refactor-is-visible-functions.patch:
>
> Among the functions that are being unified, some check temp schemas and some
> skip them. I suppose that this is because some (most) object types cannot
> normally be in temp
On 2023-Feb-15, Tom Lane wrote:
> Peter Eisentraut writes:
> > Here are two patches that refactor the mostly repetitive "${object} is
> > visible" and get_${object}_oid() functions in namespace.c. This uses
> > the functions in objectaddress.c to look up the appropriate per-catalog
> > system
Peter Eisentraut writes:
> Here are two patches that refactor the mostly repetitive "${object} is
> visible" and get_${object}_oid() functions in namespace.c. This uses
> the functions in objectaddress.c to look up the appropriate per-catalog
> system caches and attribute numbers, similar to o
Here are two patches that refactor the mostly repetitive "${object} is
visible" and get_${object}_oid() functions in namespace.c. This uses
the functions in objectaddress.c to look up the appropriate per-catalog
system caches and attribute numbers, similar to other refactoring
patches I have p
