Re: small fix for pg_overexplain docs

2025-07-16 Thread Dean Rasheed
On Wed, 16 Jul 2025 at 22:22, Nathan Bossart wrote: > > Okay, here is a new version of the patch. > LGTM. Regards, Dean

Re: small fix for pg_overexplain docs

2025-07-16 Thread Nathan Bossart
On Wed, Jul 16, 2025 at 07:45:05PM +0100, Dean Rasheed wrote: > Maybe. It's kind-of annoying that all the modules that aren't > extensions use different text. Maybe there are genuine differences -- > I didn't look too closely. It would be nice if we just had one > standard description that they all

Re: small fix for pg_overexplain docs

2025-07-16 Thread Dean Rasheed
On Wed, 16 Jul 2025 at 18:26, Nathan Bossart wrote: > > On Tue, Jul 15, 2025 at 04:14:44PM +0100, Dean Rasheed wrote: > > On Tue, 15 Jul 2025 at 04:17, Robert Treat wrote: > >> On Mon, Jul 14, 2025 at 3:22 PM David G. Johnston > >> > The pg_overexplain extends EXPLAIN with new options that provid

Re: small fix for pg_overexplain docs

2025-07-16 Thread Nathan Bossart
On Tue, Jul 15, 2025 at 04:14:44PM +0100, Dean Rasheed wrote: > On Tue, 15 Jul 2025 at 04:17, Robert Treat wrote: >> On Mon, Jul 14, 2025 at 3:22 PM David G. Johnston >> > The pg_overexplain extends EXPLAIN with new options that provide... >> > Suggest instead: >> > The pg_overexplain module provi

Re: small fix for pg_overexplain docs

2025-07-15 Thread Dean Rasheed
On Tue, 15 Jul 2025 at 04:17, Robert Treat wrote: > > On Mon, Jul 14, 2025 at 3:22 PM David G. Johnston > > The pg_overexplain extends EXPLAIN with new options that provide... > > Suggest instead: > > The pg_overexplain module provides EXPLAIN with new options intended to > > assist with debuggin

Re: small fix for pg_overexplain docs

2025-07-14 Thread Robert Treat
On Mon, Jul 14, 2025 at 3:22 PM David G. Johnston wrote: > On Mon, Jul 14, 2025 at 12:10 PM Nathan Bossart > wrote: >> >> I noticed that pg_overexplain's documentation leads off with this sentence: >> >> The pg_overexplain extends EXPLAIN with... >> >> Presumably that's meant to be somet

Re: small fix for pg_overexplain docs

2025-07-14 Thread David G. Johnston
On Mon, Jul 14, 2025 at 12:10 PM Nathan Bossart wrote: > I noticed that pg_overexplain's documentation leads off with this sentence: > > The pg_overexplain extends EXPLAIN with... > > Presumably that's meant to be something like: > > The pg_overexplain MODULE extends EXPLAIN with.

Re: small fix for pg_overexplain docs

2025-07-14 Thread Nathan Bossart
On Mon, Jul 14, 2025 at 03:14:35PM -0400, Tom Lane wrote: > Nathan Bossart writes: >> The attached patch removes the "The". If there are no objections, I will >> commit this shortly. > > When is "shortly"? I plan to wrap beta2 in about an hour. Ah, shoot, I forgot v18 was frozen. I'll wait fo

Re: small fix for pg_overexplain docs

2025-07-14 Thread Tom Lane
Nathan Bossart writes: > The attached patch removes the "The". If there are no objections, I will > commit this shortly. When is "shortly"? I plan to wrap beta2 in about an hour. regards, tom lane

small fix for pg_overexplain docs

2025-07-14 Thread Nathan Bossart
I noticed that pg_overexplain's documentation leads off with this sentence: The pg_overexplain extends EXPLAIN with... Presumably that's meant to be something like: The pg_overexplain MODULE extends EXPLAIN with... Another pattern in adjacent pages is to leave out the "The":