Re: slight tweaks to documentation about runtime pruning

2018-12-31 Thread David Rowley
On Tue, 18 Dec 2018 at 03:49, Alvaro Herrera wrote: > Pushed, thanks. I just noticed that this is still open on the CF app. Marking as committed... -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services

Re: slight tweaks to documentation about runtime pruning

2018-12-17 Thread Amit Langote
On Mon, Dec 17, 2018 at 11:49 PM Alvaro Herrera wrote: > On 2018-Dec-14, Amit Langote wrote: > > > I updated the patch. Regarding whether we should mention "(never > > executed)", it wouldn't hurt to mention it imho, exactly because it's > > shown in the place of showing loops=0. How about the a

Re: slight tweaks to documentation about runtime pruning

2018-12-17 Thread Alvaro Herrera
On 2018-Dec-14, Amit Langote wrote: > I updated the patch. Regarding whether we should mention "(never > executed)", it wouldn't hurt to mention it imho, exactly because it's > shown in the place of showing loops=0. How about the attached? Pushed, thanks. -- Álvaro Herrerahttp

Re: slight tweaks to documentation about runtime pruning

2018-12-16 Thread Alvaro Herrera
On 2018-Dec-10, David Rowley wrote: > On Wed, 5 Dec 2018 at 20:24, Amit Langote > wrote: > > However, for pruned partitions' subplans, what's actually shown is the > > string "(never executed)", not loops. So, wouldn't it be better to tell > > the readers to look for that instead of "loops"? >

Re: slight tweaks to documentation about runtime pruning

2018-12-13 Thread Amit Langote
On 2018/12/10 0:57, Amit Langote wrote: > On Sun, Dec 9, 2018 at 8:13 PM David Rowley > wrote: >> listp1 was scanned twice (loops=2), listp2 was scanned just once. >> >> Now it is true that if the subplan was executed 0 times that it will >> appear as "(never executed)", but do we really need to e

Re: slight tweaks to documentation about runtime pruning

2018-12-09 Thread Amit Langote
On Sun, Dec 9, 2018 at 8:13 PM David Rowley wrote: > listp1 was scanned twice (loops=2), listp2 was scanned just once. > > Now it is true that if the subplan was executed 0 times that it will > appear as "(never executed)", but do we really need to explain in this > area that "(never executed)" me

Re: slight tweaks to documentation about runtime pruning

2018-12-09 Thread David Rowley
On Wed, 5 Dec 2018 at 20:24, Amit Langote wrote: > Documentation of run-time pruning tells readers to inspect "nloops" > property of the EXPLAIN ANALYZE output, but I think that's a typo of > "loops" which is actually output ("internal variable to track that > property is indeed nloops). I agree.

Re: slight tweaks to documentation about runtime pruning

2018-12-05 Thread Amit Langote
On 2018/12/05 16:23, Amit Langote wrote: > Hi, > > Documentation of run-time pruning tells readers to inspect "nloops" > property of the EXPLAIN ANALYZE output, but I think that's a typo of > "loops" which is actually output ("internal variable to track that > property is indeed nloops). > > Howe

slight tweaks to documentation about runtime pruning

2018-12-04 Thread Amit Langote
Hi, Documentation of run-time pruning tells readers to inspect "nloops" property of the EXPLAIN ANALYZE output, but I think that's a typo of "loops" which is actually output ("internal variable to track that property is indeed nloops). However, for pruned partitions' subplans, what's actually sho