Re: simplify index tuple descriptor initialization

2018-09-12 Thread Peter Eisentraut
On 12/09/2018 15:18, Arthur Zakirov wrote: > On Mon, Aug 27, 2018 at 04:25:28PM +0200, Peter Eisentraut wrote: >> Whenever some pg_attribute field is added or changed, a lot of >> repetitive changes all over the code are necessary. Here is a small >> change to remove one such place. > > It looks

Re: simplify index tuple descriptor initialization

2018-09-12 Thread Arthur Zakirov
On Mon, Aug 27, 2018 at 04:25:28PM +0200, Peter Eisentraut wrote: > Whenever some pg_attribute field is added or changed, a lot of > repetitive changes all over the code are necessary. Here is a small > change to remove one such place. It looks like a reasonable change to me. The code is good an

simplify index tuple descriptor initialization

2018-08-27 Thread Peter Eisentraut
15:50:50 +0200 Subject: [PATCH] Simplify index tuple descriptor initialization We have two code paths for initializing the tuple descriptor for a new index: For a normal index, we copy the tuple descriptor from the table and reset a number of fields that are not applicable to indexes. For an express