Re: simplehash.h comment

2018-08-27 Thread Thomas Munro
On Tue, Aug 28, 2018 at 1:40 AM Tom Lane wrote: > Thomas Munro writes: > > ... and a patch. Thoughts? > > It's not real obvious why you're adding inclusion guards over just a > subset of the header. A short comment about that would be worthwhile. Right, thanks. I added a comment and committed

Re: simplehash.h comment

2018-08-27 Thread Tom Lane
Thomas Munro writes: > ... and a patch. Thoughts? It's not real obvious why you're adding inclusion guards over just a subset of the header. A short comment about that would be worthwhile. regards, tom lane

Re: simplehash.h comment

2018-08-26 Thread Thomas Munro
On Sun, Aug 26, 2018 at 2:41 PM Thomas Munro wrote: > Some more comments on simplehash.h: ... and a patch. Thoughts? -- Thomas Munro http://www.enterprisedb.com 0001-Code-review-for-simplehash.h.patch Description: Binary data

Re: simplehash.h comment

2018-08-25 Thread Thomas Munro
On Mon, Aug 20, 2018 at 4:57 PM Michael Paquier wrote: > > On Mon, Aug 20, 2018 at 04:38:20PM +1200, Thomas Munro wrote: > > "For examples of usage look at simplehash.c ..." > > > > There is no such file in the tree. Maybe this should say tidbitmap.c? > > And execGrouping.c... Some more comments

Re: simplehash.h comment

2018-08-19 Thread Michael Paquier
On Mon, Aug 20, 2018 at 04:38:20PM +1200, Thomas Munro wrote: > "For examples of usage look at simplehash.c ..." > > There is no such file in the tree. Maybe this should say tidbitmap.c? And execGrouping.c.. -- Michael signature.asc Description: PGP signature

simplehash.h comment

2018-08-19 Thread Thomas Munro
Hi, "For examples of usage look at simplehash.c ..." There is no such file in the tree. Maybe this should say tidbitmap.c? -- Thomas Munro http://www.enterprisedb.com