Re: simplehash: tb->sizemask = 0

2017-12-05 Thread Todd A. Cook
On 11/29/17 13:49, Andres Freund wrote: On 2017-11-27 22:53:41 -0500, Tom Lane wrote: Tomas Vondra writes: I'm a bit puzzled by this code in SH_COMPUTE_PARAMETERS: if (tb->size == SH_MAX_SIZE) tb->sizemask = 0; else tb->sizemask = tb->size - 1; Doesn't that me

Re: simplehash: tb->sizemask = 0

2017-11-29 Thread Andres Freund
On 2017-11-27 22:53:41 -0500, Tom Lane wrote: > Tomas Vondra writes: > > I'm a bit puzzled by this code in SH_COMPUTE_PARAMETERS: > > > if (tb->size == SH_MAX_SIZE) > > tb->sizemask = 0; > > else > > tb->sizemask = tb->size - 1; > > > Doesn't that mean that with SH_MAX_SI

Re: simplehash: tb->sizemask = 0

2017-11-27 Thread Tom Lane
Tomas Vondra writes: > I'm a bit puzzled by this code in SH_COMPUTE_PARAMETERS: > if (tb->size == SH_MAX_SIZE) > tb->sizemask = 0; > else > tb->sizemask = tb->size - 1; > Doesn't that mean that with SH_MAX_SIZE we end up with sizemask being 0 > (i.e. no bits set)? Yeah,

simplehash: tb->sizemask = 0

2017-11-27 Thread Tomas Vondra
Hi, I'm a bit puzzled by this code in SH_COMPUTE_PARAMETERS: if (tb->size == SH_MAX_SIZE) tb->sizemask = 0; else tb->sizemask = tb->size - 1; Doesn't that mean that with SH_MAX_SIZE we end up with sizemask being 0 (i.e. no bits set)? At least that's what I get from p