Re: sendFileWithContent() does not advance the source pointer

2022-12-12 Thread Robert Haas
On Thu, Dec 8, 2022 at 2:43 PM Antonin Houska wrote: > When checking something else in the base backup code, I've noticed that > sendFileWithContent() does not advance the 'content' pointer. The sink buffer > is large enough (32kB) so that the first iteration usually processes the whole > file (on

Re: sendFileWithContent() does not advance the source pointer

2022-12-08 Thread Andres Freund
Hi, On 2022-12-08 20:44:05 +0100, Antonin Houska wrote: > When checking something else in the base backup code, I've noticed that > sendFileWithContent() does not advance the 'content' pointer. Oof. Luckily it looks like that is a relatively recent issue, introduced in bef47ff85df, which is only

sendFileWithContent() does not advance the source pointer

2022-12-08 Thread Antonin Houska
When checking something else in the base backup code, I've noticed that sendFileWithContent() does not advance the 'content' pointer. The sink buffer is large enough (32kB) so that the first iteration usually processes the whole file (only special files are processed by this function), and thus tha