Re: review printing ecpg program version

2018-09-12 Thread Michael Paquier
On Wed, Sep 12, 2018 at 02:41:11PM +0200, Peter Eisentraut wrote: > On 12/09/2018 10:32, Ioseph Kim wrote: >> ok, in case pg_config, ignore this, but It should be review in case ecpg. > > fixed Thanks Peter for jumping in the ship. What you did looks correct to me. -- Michael signature.asc Des

Re: review printing ecpg program version

2018-09-12 Thread Peter Eisentraut
On 12/09/2018 10:32, Ioseph Kim wrote: > ok, in case pg_config, ignore this, but It should be review in case ecpg. fixed > 2018년 09월 12일 16:03에 Michael Paquier 이(가) 쓴 글: >> On Wed, Sep 12, 2018 at 03:55:56PM +0900, Ioseph Kim wrote: >>> check please pg_config --version too. >> Well, one problem w

Re: review printing ecpg program version

2018-09-12 Thread Ioseph Kim
ok, in case pg_config, ignore this, but It should be review in case ecpg. 2018년 09월 12일 16:03에 Michael Paquier 이(가) 쓴 글: On Wed, Sep 12, 2018 at 03:55:56PM +0900, Ioseph Kim wrote: check please pg_config --version too. Well, one problem with that is that you would break a ton of stuff which p

Re: review printing ecpg program version

2018-09-12 Thread Michael Paquier
On Wed, Sep 12, 2018 at 03:55:56PM +0900, Ioseph Kim wrote: > check please pg_config --version too. Well, one problem with that is that you would break a ton of stuff which parse this version string automatically. pg_config --version is used by many extensions to guess which version of Postgres i

Re: review printing ecpg program version

2018-09-11 Thread Ioseph Kim
check please pg_config --version too. 2018년 09월 12일 15:52에 Ioseph Kim 이(가) 쓴 글: hi, I found a little problem about printing ecpg version. unlike PostgreSQL ver.11 other programs, ecpg version string has only version number. $ ./ecpg --version ecpg 11beta3 $ ./psql --version psql (Postgre

review printing ecpg program version

2018-09-11 Thread Ioseph Kim
hi, I found a little problem about printing ecpg version. unlike PostgreSQL ver.11 other programs, ecpg version string has only version number. $ ./ecpg --version ecpg 11beta3 $ ./psql --version psql (PostgreSQL) 11beta3 $ ./pg_dump --version pg_dump (PostgreSQL) 11beta3 I hope PostgreSQL