Re: replace magic num in struct cachedesc with CATCACHE_MAXKEYS

2024-08-23 Thread Junwang Zhao
On Fri, Aug 23, 2024 at 9:02 PM Peter Eisentraut wrote: > > On 15.08.24 12:25, Junwang Zhao wrote: > > I noticed that there is a magic number which can be replaced by > > CATCACHE_MAXKEYS > > in struct cachedesc, I checked some other struct like CatCache, CatCTup, > > they > > all use CATCACHE_M

Re: replace magic num in struct cachedesc with CATCACHE_MAXKEYS

2024-08-23 Thread Peter Eisentraut
On 15.08.24 12:25, Junwang Zhao wrote: I noticed that there is a magic number which can be replaced by CATCACHE_MAXKEYS in struct cachedesc, I checked some other struct like CatCache, CatCTup, they all use CATCACHE_MAXKEYS. The "syscache" is the only user of the "catcache" right now. But I th

replace magic num in struct cachedesc with CATCACHE_MAXKEYS

2024-08-15 Thread Junwang Zhao
Hi hackers, I noticed that there is a magic number which can be replaced by CATCACHE_MAXKEYS in struct cachedesc, I checked some other struct like CatCache, CatCTup, they all use CATCACHE_MAXKEYS. I did some search on pg-hackers, and found an old thread[0] that Robert proposed to change the maxim