Re: remove useless comments

2023-10-28 Thread Bruce Momjian
On Wed, Aug 10, 2022 at 12:24:02AM +0800, Junwang Zhao wrote: > Fair enough, the rephased version of the comments is in the attachment, > please take a look. > > --- a/src/backend/postmaster/postmaster.c > +++ b/src/backend/postmaster/postmaster.c > @@ -1583,8 +1583,8 @@ getInstallationPaths(const

Re: remove useless comments

2022-08-09 Thread Junwang Zhao
Fair enough, the rephased version of the comments is in the attachment, please take a look. --- a/src/backend/postmaster/postmaster.c +++ b/src/backend/postmaster/postmaster.c @@ -1583,8 +1583,8 @@ getInstallationPaths(const char *argv0) FreeDir(pdir); /* - * XXX is it worth similarly checkin

Re: remove useless comments

2022-08-09 Thread Tom Lane
Junwang Zhao writes: > The comments considering checking share/ directory was there for > almost 13 years, yet nobody ever trying to add the checking, and > there seems never any trouble for not checking it, then I think > we should remove those comments. I think that comment is valuable. It sho

remove useless comments

2022-08-09 Thread Junwang Zhao
The comments considering checking share/ directory was there for almost 13 years, yet nobody ever trying to add the checking, and there seems never any trouble for not checking it, then I think we should remove those comments. diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmast