On Sat, Apr 18, 2020 at 8:12 PM Michael Paquier wrote:
> I would suggest to
> still use BackupManifest instead of Manifest in those functions and
> structures though, ...
Done in the attached, which also adds "backup_" to the type names.
After further examination, I think the Copyright header is
On Sat, Apr 18, 2020 at 10:43:52AM -0400, Robert Haas wrote:
> I'm not in favor of this renaming. Different people have different
> preferences, of course, but my impression is that the general project
> style is to choose names that follow English word ordering, i.e.
> appendStringInfo rather than
On Sat, Apr 18, 2020 at 5:43 PM Tom Lane wrote:
> Robert Haas writes:
> > Despite the fact that we are after feature freeze, I think it would be
> > a good idea to commit this to PG 13. It could be saved for PG 14, but
> > that will make future back-patching substantially harder. Also, a
> > pat
Robert Haas writes:
> Despite the fact that we are after feature freeze, I think it would be
> a good idea to commit this to PG 13. It could be saved for PG 14, but
> that will make future back-patching substantially harder. Also, a
> patch that's just moving code is pretty low-risk.
+1 in princi
On Sat, Apr 18, 2020 at 8:57 AM Michael Paquier wrote:
> +static inline bool
> +IsManifestEnabled(manifest_info *manifest)
> +{
> + return (manifest->buffile != NULL);
> +}
> I would keep this one static and located within backup_manifest.c as
> it is only used there.
Oh, OK.
> +extern void In
On Sat, Apr 18, 2020 at 08:37:58AM -0400, Robert Haas wrote:
> Despite the fact that we are after feature freeze, I think it would be
> a good idea to commit this to PG 13. It could be saved for PG 14, but
> that will make future back-patching substantially harder. Also, a
> patch that's just movin
Hi,
The backup manifest patch added a bunch of new code to
src/backend/replication/basebackup.c, and while lamenting the
complexity of that source file yesterday, I suddenly realized that I'd
unwittingly contributed to making that problem worse, and that it
would be quite easy to move the code add
