Re: relhassubclass and partitioned indexes

2018-10-22 Thread Amit Langote
On 2018/10/23 0:45, Alvaro Herrera wrote: > On 2018-Oct-22, Amit Langote wrote: > >> Hi, >> >> On 2018/10/22 11:09, Michael Paquier wrote: >>> On Fri, Oct 19, 2018 at 06:46:15PM +0900, Amit Langote wrote: Thanks. Attached a patch to set relhassubclass when an index partition is added to

Re: relhassubclass and partitioned indexes

2018-10-22 Thread Alvaro Herrera
On 2018-Oct-22, Amit Langote wrote: > Hi, > > On 2018/10/22 11:09, Michael Paquier wrote: > > On Fri, Oct 19, 2018 at 06:46:15PM +0900, Amit Langote wrote: > >> Thanks. Attached a patch to set relhassubclass when an index partition is > >> added to a partitioned index. > > > > Thanks, committed

Re: relhassubclass and partitioned indexes

2018-10-21 Thread Amit Langote
Hi, On 2018/10/22 11:09, Michael Paquier wrote: > On Fri, Oct 19, 2018 at 06:46:15PM +0900, Amit Langote wrote: >> Thanks. Attached a patch to set relhassubclass when an index partition is >> added to a partitioned index. > > Thanks, committed after adding a test with ALTER TABLE ONLY, and > che

Re: relhassubclass and partitioned indexes

2018-10-21 Thread Michael Paquier
On Fri, Oct 19, 2018 at 06:46:15PM +0900, Amit Langote wrote: > Thanks. Attached a patch to set relhassubclass when an index partition is > added to a partitioned index. Thanks, committed after adding a test with ALTER TABLE ONLY, and checking upgrades as well as ATTACH partition for ALTER INDEX

Re: relhassubclass and partitioned indexes

2018-10-19 Thread Amit Langote
Thanks for commenting. On 2018/10/19 15:17, Michael Paquier wrote: > On Fri, Oct 19, 2018 at 01:45:03AM -0400, Tom Lane wrote: >> Amit Langote writes: >>> Should relhassubclass be set/reset for partitioned indexes? >> >> Seems like a reasonable idea to me, at least the "set" end of it. >> We don'

Re: relhassubclass and partitioned indexes

2018-10-18 Thread Michael Paquier
On Fri, Oct 19, 2018 at 01:45:03AM -0400, Tom Lane wrote: > Amit Langote writes: >> Should relhassubclass be set/reset for partitioned indexes? > > Seems like a reasonable idea to me, at least the "set" end of it. > We don't ever clear relhassubclass for tables, so maybe that's > not necessary fo

Re: relhassubclass and partitioned indexes

2018-10-18 Thread Tom Lane
Amit Langote writes: > Should relhassubclass be set/reset for partitioned indexes? Seems like a reasonable idea to me, at least the "set" end of it. We don't ever clear relhassubclass for tables, so maybe that's not necessary for indexes either. > Michael suggested on the linked thread to get ri

relhassubclass and partitioned indexes

2018-10-18 Thread Amit Langote
Hi, $subject came up in [1]. Should relhassubclass be set/reset for partitioned indexes? The only use case being sought here is to use find_inheritance_children() for getting an index's partitions, but it uses relhassublcass test to short-circuit scanning pg_inherits. That means it cannot be u