Andrew Dunstan writes:
> Note, too that the psql and safe_psql methods also pass the query via stdin.
Yeah. We need all of these to act the same, IMO. Recall that
the previous patches that introduced the undef hack were changing
callers of those routines, not poll_query_until.
On 6/12/21 5:28 PM, Tom Lane wrote:
> Andrew Dunstan writes:
>> I'm a bit dubious about this. It doesn't seem more robust to insist that
>> we pass undef in certain cases.
> True, it'd be nicer if that didn't matter; mainly because people
> will get it wrong in future.
Right, that's what I'm w
Andrew Dunstan writes:
> I'm a bit dubious about this. It doesn't seem more robust to insist that
> we pass undef in certain cases.
True, it'd be nicer if that didn't matter; mainly because people
will get it wrong in future.
> If passing the SQL via stdin is fragile,
> as we also found to be th
On 6/12/21 3:15 PM, Tom Lane wrote:
>>> Michael Paquier writes:
This is the same problem as c757a3da and 6d41dd0, where we write a
query to a pipe but the kill, causing a failure, makes the test fail
with a SIGPIPE in IPC::Run as a query is sent down to a pipe.
> After checking th
>> Michael Paquier writes:
>>> This is the same problem as c757a3da and 6d41dd0, where we write a
>>> query to a pipe but the kill, causing a failure, makes the test fail
>>> with a SIGPIPE in IPC::Run as a query is sent down to a pipe.
After checking the git logs, I realized that this failure is
I wrote:
> Michael Paquier writes:
>> This is the same problem as c757a3da and 6d41dd0, where we write a
>> query to a pipe but the kill, causing a failure, makes the test fail
>> with a SIGPIPE in IPC::Run as a query is sent down to a pipe.
> The precedent of the previous fixes would seem to sug
Michael Paquier writes:
> On Fri, Jun 11, 2021 at 05:38:34PM +0530, Amit Kapila wrote:
>> It seems the error happens in both the tests when after issuing a
>> KILL, we are trying to reconnect. Can we do anything for this?
> This is the same problem as c757a3da and 6d41dd0, where we write a
> quer
On Fri, Jun 11, 2021 at 05:38:34PM +0530, Amit Kapila wrote:
> It seems the error happens in both the tests when after issuing a
> KILL, we are trying to reconnect. Can we do anything for this?
This is the same problem as c757a3da and 6d41dd0, where we write a
query to a pipe but the kill, causing
I noticed that we are getting random failures [1][2][3] in the
recovery test on hoverfly. The failures are in 022_crash_temp_files
and 013_crash_restart. Both the tests failed due to same reason:
ack Broken pipe: write( 13, 'SELECT 1' ) at
/home/nm/src/build/IPC-Run-0.94/lib/IPC/Run/IO.pm line 558
