pá 12. 5. 2023 v 21:08 odesílatel Tom Lane napsal:
> I wrote:
> > Pavel Stehule writes:
> >> Except for testing, using pager in non-interactive mode makes no sense.
>
> > Agreed. Let's solve this by inserting isatty tests in psql, rather
> > than hacking the test environment.
>
> Here's a propo
I wrote:
> Pavel Stehule writes:
>> Except for testing, using pager in non-interactive mode makes no sense.
> Agreed. Let's solve this by inserting isatty tests in psql, rather
> than hacking the test environment.
Here's a proposed patch for this. I noticed that another memo the
PSQL_WATCH_PAG
Pavel Stehule writes:
> pá 12. 5. 2023 v 17:50 odesílatel Tom Lane napsal:
>> OK. So after looking at this a bit, the reason PAGER and PSQL_PAGER
>> don't cause us any problems in the test environment is that they are
>> not honored unless isatty(fileno(stdin)) && isatty(fileno(stdout)).
>> It s
pá 12. 5. 2023 v 17:50 odesílatel Tom Lane napsal:
> Pavel Stehule writes:
> > pá 12. 5. 2023 v 15:26 odesílatel Tom Lane napsal:
> >> Oh! AFAICS, we don't do any of those things, but I agree it seems like
> >> a good idea. Can you confirm that if you unset PSQL_WATCH_PAGER then
> >> the test
Pavel Stehule writes:
> pá 12. 5. 2023 v 15:26 odesílatel Tom Lane napsal:
>> Oh! AFAICS, we don't do any of those things, but I agree it seems like
>> a good idea. Can you confirm that if you unset PSQL_WATCH_PAGER then
>> the test passes for you?
> yes, I tested it now, and unset PSQL_WATCH
pá 12. 5. 2023 v 15:26 odesílatel Tom Lane napsal:
> Pavel Stehule writes:
> > And generally, the root perl should to reset PSQL_WATCH_PAGER env
> variable
> > before executing psql. Probably it does with PSQL_PAGER, and maybe with
> > PAGER.
>
> Oh! AFAICS, we don't do any of those things, but
Pavel Stehule writes:
> And generally, the root perl should to reset PSQL_WATCH_PAGER env variable
> before executing psql. Probably it does with PSQL_PAGER, and maybe with
> PAGER.
Oh! AFAICS, we don't do any of those things, but I agree it seems like
a good idea. Can you confirm that if you u
pá 12. 5. 2023 v 10:31 odesílatel Pavel Stehule
napsal:
>
>
> pá 12. 5. 2023 v 9:46 odesílatel Alvaro Herrera
> napsal:
>
>> On 2023-May-12, Pavel Stehule wrote:
>>
>> > It hangs in perl
>>
>> I wonder if "hanging" actually means that it interpreted the sleep time
>> as a very large integer, so
pá 12. 5. 2023 v 9:46 odesílatel Alvaro Herrera
napsal:
> On 2023-May-12, Pavel Stehule wrote:
>
> > It hangs in perl
>
> I wonder if "hanging" actually means that it interpreted the sleep time
> as a very large integer, so it's just sleeping for a long time.
>
There is some interaction with psp
On 2023-May-12, Pavel Stehule wrote:
> It hangs in perl
I wonder if "hanging" actually means that it interpreted the sleep time
as a very large integer, so it's just sleeping for a long time.
About the server locale, note that the ->new() call explicitly requests
the C locale -- it's only psql t
On Fri, May 12, 2023 at 2:40 AM Pavel Stehule
wrote:
> pá 12. 5. 2023 v 8:20 odesílatel Kirk Wolak napsal:
>
>> On Fri, May 12, 2023 at 1:46 AM Pavel Stehule
>> wrote:
>>
>>> pá 12. 5. 2023 v 6:50 odesílatel Kirk Wolak napsal:
>>>
On Fri, May 12, 2023 at 12:14 AM Tom Lane wrote:
>>>
pá 12. 5. 2023 v 8:20 odesílatel Kirk Wolak napsal:
> On Fri, May 12, 2023 at 1:46 AM Pavel Stehule
> wrote:
>
>> pá 12. 5. 2023 v 6:50 odesílatel Kirk Wolak napsal:
>>
>>> On Fri, May 12, 2023 at 12:14 AM Tom Lane wrote:
>>>
Kirk Wolak writes:
> Did you try the print statement that
On Fri, May 12, 2023 at 1:46 AM Pavel Stehule
wrote:
> pá 12. 5. 2023 v 6:50 odesílatel Kirk Wolak napsal:
>
>> On Fri, May 12, 2023 at 12:14 AM Tom Lane wrote:
>>
>>> Kirk Wolak writes:
>>> > Did you try the print statement that Andrey asked Pavel to try?
>>> ...
>>
>>
> The strange thing is
pá 12. 5. 2023 v 6:50 odesílatel Kirk Wolak napsal:
> On Fri, May 12, 2023 at 12:14 AM Tom Lane wrote:
>
>> Kirk Wolak writes:
>> > Did you try the print statement that Andrey asked Pavel to try?
>>
>> Yeah, and I get exactly the results I expect:
>>
>> Your results MATCHED Pavels (Hmm). Pipi
On Fri, May 12, 2023 at 12:14 AM Tom Lane wrote:
> Kirk Wolak writes:
> > Did you try the print statement that Andrey asked Pavel to try?
>
> Yeah, and I get exactly the results I expect:
>
> Your results MATCHED Pavels (Hmm). Piping ONE of those into psql should
fail, and the other one should
Kirk Wolak writes:
> Did you try the print statement that Andrey asked Pavel to try?
Yeah, and I get exactly the results I expect:
$ cat test.pl
use locale;
my $result = sprintf('SELECT 1 \watch c=3 i=%g', 0.01);
print ">>$result<<\n";
$ LANG=cs_CZ.utf8 perl test.pl
>>SELECT 1 \watch c=3 i=0,01<
On Thu, May 11, 2023 at 8:08 PM Tom Lane wrote:
> Kirk Wolak writes:
> > Can you change the 0.01 to just 1 or 0?
> > I assume it will work then! (and better than a full removal)?
>
> IMO the point of that test is largely to exercise this locale-dependent
> behavior, so I'm very unwilling to dumb
Kirk Wolak writes:
> Can you change the 0.01 to just 1 or 0?
> I assume it will work then! (and better than a full removal)?
IMO the point of that test is largely to exercise this locale-dependent
behavior, so I'm very unwilling to dumb it down to that extent.
What seems to be happening is that
On Wed, May 10, 2023 at 12:59 AM Pavel Stehule
wrote:
> Hi
>
> When I remove this test, then all tests passed
>
> diff --git a/src/bin/psql/t/001_basic.pl b/src/bin/psql/t/001_basic.pl
> index 596746de17..631a1a7335 100644
> --- a/src/bin/psql/t/001_basic.pl
> +++ b/src/bin/psql/t/001_basic.pl
>
Pavel Stehule writes:
>> Stranger things, but is LANG case sensitive, or formatted differently?
> I don't think so encoding is case sensitive - I am not sure, but minimally
> ncurses applications works without any problems, and ncurses is very locale
> sensitive
> $ LANG=cs_CZ.utf8 make check
> d
Hi
>
>
> Stranger things, but is LANG case sensitive, or formatted differently?
>
> tom> $ LANG=cs_CZ.utf8 make installcheck
> you> LANG=cs_CZ.*UTF-8*
>
>
I don't think so encoding is case sensitive - I am not sure, but minimally
ncurses applications works without any problems, and ncurses is ver
On Thu, May 11, 2023 at 3:06 PM Pavel Stehule
wrote:
>
>
> čt 11. 5. 2023 v 20:44 odesílatel Tom Lane napsal:
>
>> Pavel Stehule writes:
>> > When I remove this test, then all tests passed
>>
>> This works fine for me on Fedora 37:
>>
>
> I have Fedora 38
>
>>
>> $ cd src/bin/psql
>> $ LANG=cs_
čt 11. 5. 2023 v 20:44 odesílatel Tom Lane napsal:
> Pavel Stehule writes:
> > When I remove this test, then all tests passed
>
> This works fine for me on Fedora 37:
>
I have Fedora 38
>
> $ cd src/bin/psql
> $ LANG=cs_CZ.utf8 make installcheck
> make -C ../../../src/backend generated-headers
Pavel Stehule writes:
> When I remove this test, then all tests passed
This works fine for me on Fedora 37:
$ cd src/bin/psql
$ LANG=cs_CZ.utf8 make installcheck
make -C ../../../src/backend generated-headers
make[1]: Vstupuje se do adresáře „/home/tgl/pgsql/src/backend“
...
# +++ tap install-ch
Hi
čt 11. 5. 2023 v 11:36 odesílatel Andrey M. Borodin
napsal:
>
>
> > On 10 May 2023, at 09:58, Pavel Stehule wrote:
> >
> > When I remove this test, then all tests passed
>
> Hi Pavel!
>
> Can you plz share how sprintf('SELECT 1 \watch c=3 i=%g', 0.01) is
> formatting 0.01 on your system?
>
> On 10 May 2023, at 09:58, Pavel Stehule wrote:
>
> When I remove this test, then all tests passed
Hi Pavel!
Can you plz share how sprintf('SELECT 1 \watch c=3 i=%g', 0.01) is formatting
0.01 on your system?
And try to run that string against psql.
As an alternative I propose to use "i=0”
Hi
When I remove this test, then all tests passed
diff --git a/src/bin/psql/t/001_basic.pl b/src/bin/psql/t/001_basic.pl
index 596746de17..631a1a7335 100644
--- a/src/bin/psql/t/001_basic.pl
+++ b/src/bin/psql/t/001_basic.pl
@@ -353,11 +353,6 @@ psql_like(
# Check \watch
# Note: the interval v
Hi
út 9. 5. 2023 v 13:53 odesílatel Pavel Stehule
napsal:
>
>
> út 9. 5. 2023 v 11:07 odesílatel Pavel Stehule
> napsal:
>
>>
>>
>> út 9. 5. 2023 v 10:48 odesílatel Daniel Gustafsson
>> napsal:
>>
>>> > On 9 May 2023, at 08:52, Pavel Stehule
>>> wrote:
>>> >
>>> > Hi
>>> >
>>> > I try run ma
út 9. 5. 2023 v 11:07 odesílatel Pavel Stehule
napsal:
>
>
> út 9. 5. 2023 v 10:48 odesílatel Daniel Gustafsson
> napsal:
>
>> > On 9 May 2023, at 08:52, Pavel Stehule wrote:
>> >
>> > Hi
>> >
>> > I try run make check-world. Now I have problems with tests of psql
>> >
>> > I had to cancel test
út 9. 5. 2023 v 10:48 odesílatel Daniel Gustafsson napsal:
> > On 9 May 2023, at 08:52, Pavel Stehule wrote:
> >
> > Hi
> >
> > I try run make check-world. Now I have problems with tests of psql
> >
> > I had to cancel tests
> >
> > log:
> >
> > [08:46:49.828](0.038s) ok 63 - no ON_ERROR_STOP, -
> On 9 May 2023, at 08:52, Pavel Stehule wrote:
>
> Hi
>
> I try run make check-world. Now I have problems with tests of psql
>
> I had to cancel tests
>
> log:
>
> [08:46:49.828](0.038s) ok 63 - no ON_ERROR_STOP, --single-transaction and
> multiple -c switches
> [08:46:49.860](0.033s) ok 64
Hi
I try run make check-world. Now I have problems with tests of psql
I had to cancel tests
log:
[08:46:49.828](0.038s) ok 63 - no ON_ERROR_STOP, --single-transaction and
multiple -c switches
[08:46:49.860](0.033s) ok 64 - client-side error commits transaction, no
ON_ERROR_STOP and multiple -c
32 matches
Mail list logo
