Re: proposal - plpgsql unique statement id

2019-01-25 Thread Pavel Stehule
čt 24. 1. 2019 v 23:08 odesílatel Tom Lane napsal: > Peter Eisentraut writes: > > committed > > Why didn't this patch modify the dumping logic in pl_funcs.c to print > the IDs? I'm not aware of other cases where we intentionally omit > fields from debug-support printouts. > Currently we don't

Re: proposal - plpgsql unique statement id

2019-01-24 Thread Pavel Stehule
čt 24. 1. 2019 v 23:08 odesílatel Tom Lane napsal: > Peter Eisentraut writes: > > committed > > Why didn't this patch modify the dumping logic in pl_funcs.c to print > the IDs? I'm not aware of other cases where we intentionally omit > fields from debug-support printouts. > I had not a idea, s

Re: proposal - plpgsql unique statement id

2019-01-24 Thread Tom Lane
Peter Eisentraut writes: > committed Why didn't this patch modify the dumping logic in pl_funcs.c to print the IDs? I'm not aware of other cases where we intentionally omit fields from debug-support printouts. regards, tom lane

Re: proposal - plpgsql unique statement id

2019-01-24 Thread Peter Eisentraut
On 22/01/2019 19:04, Pavel Stehule wrote: > It was missing, fixed, thank you for check committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: proposal - plpgsql unique statement id

2019-01-22 Thread Pavel Stehule
út 22. 1. 2019 v 14:55 odesílatel Peter Eisentraut < peter.eisentr...@2ndquadrant.com> napsal: > There are still a handful of places where a statement is created but no > stmtid is assigned. Can you check those? > > src/pl/plpgsql/src/pl_exec.c:2815 > src/pl/plpgsql/src/pl_exec.c:4580 > These st

Re: proposal - plpgsql unique statement id

2019-01-22 Thread Peter Eisentraut
There are still a handful of places where a statement is created but no stmtid is assigned. Can you check those? src/pl/plpgsql/src/pl_exec.c:2815 src/pl/plpgsql/src/pl_exec.c:4580 src/pl/plpgsql/src/pl_gram.y:907 -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Developme

Re: proposal - plpgsql unique statement id

2019-01-18 Thread Pavel Stehule
pá 18. 1. 2019 v 8:56 odesílatel Peter Eisentraut < peter.eisentr...@2ndquadrant.com> napsal: > On 04/01/2019 15:07, Pavel Stehule wrote: > > pá 4. 1. 2019 v 13:58 odesílatel Peter Eisentraut > > > > napsal: > > > > On 13/11/2018 14:35, Pavel Stehule w

Re: proposal - plpgsql unique statement id

2019-01-17 Thread Peter Eisentraut
On 04/01/2019 15:07, Pavel Stehule wrote: > pá 4. 1. 2019 v 13:58 odesílatel Peter Eisentraut > > napsal: > > On 13/11/2018 14:35, Pavel Stehule wrote: > > I am try to enhance plpgsql_check about profiler functionality and I > > have to solve h

Re: proposal - plpgsql unique statement id

2019-01-04 Thread Pavel Stehule
pá 4. 1. 2019 v 13:58 odesílatel Peter Eisentraut < peter.eisentr...@2ndquadrant.com> napsal: > On 13/11/2018 14:35, Pavel Stehule wrote: > > I am try to enhance plpgsql_check about profiler functionality and I > > have to solve how to identify every plpgsql statement across different > > sessions

Re: proposal - plpgsql unique statement id

2019-01-04 Thread Peter Eisentraut
On 13/11/2018 14:35, Pavel Stehule wrote: > I am try to enhance plpgsql_check about profiler functionality and I > have to solve how to identify every plpgsql statement across different > sessions. There is lineno, but surely it should not be unique. I propose > introduce stmtid to every statement

proposal - plpgsql unique statement id

2018-11-13 Thread Pavel Stehule
Hi I am try to enhance plpgsql_check about profiler functionality and I have to solve how to identify every plpgsql statement across different sessions. There is lineno, but surely it should not be unique. I propose introduce stmtid to every statement structure. This number will be unique inside f