On Wed, Oct 6, 2021 at 8:39 PM Bharath Rupireddy
wrote:
> On Wed, Oct 6, 2021 at 4:55 PM Etsuro Fujita wrote:
> > On Wed, Oct 6, 2021 at 6:37 PM Bharath Rupireddy
> > wrote:
> > > +1 for rewording the comments. Here are my thoughts on the patch:
> > >
> > > 1) Just to be consistent(we are using
On Wed, Oct 6, 2021 at 4:55 PM Etsuro Fujita wrote:
>
> Hi Bharath,
>
> On Wed, Oct 6, 2021 at 6:37 PM Bharath Rupireddy
> wrote:
> > +1 for rewording the comments. Here are my thoughts on the patch:
> >
> > 1) Just to be consistent(we are using this word in the error message,
> > and in other co
Hi Bharath,
On Wed, Oct 6, 2021 at 6:37 PM Bharath Rupireddy
wrote:
> +1 for rewording the comments. Here are my thoughts on the patch:
>
> 1) Just to be consistent(we are using this word in the error message,
> and in other comments around there), how about
> + * Determine whether to try to rees
On Wed, Oct 6, 2021 at 2:35 PM Etsuro Fujita wrote:
>
> While working on something else, I noticed $SUBJECT, which I should
> have updated in commit 27e1f1456. :-( There are two places that need
> to be updated, but in the first place the second one seemed a bit
> redundant to me, because it say
While working on something else, I noticed $SUBJECT, which I should
have updated in commit 27e1f1456. :-( There are two places that need
to be updated, but in the first place the second one seemed a bit
redundant to me, because it says the same thing as the first one, and
is placed pretty close t
