Re: portal pinning

2018-01-10 Thread Peter Eisentraut
On 1/10/18 13:53, Vladimir Sitnikov wrote: >> committed > > I'm afraid it causes regressions for pgjdbc. > Here's CI log: https://travis-ci.org/pgjdbc/pgjdbc/jobs/327327402 > > The errors are: > testMetaData[typeName = REF_CURSOR, cursorType = > 2,012](org.postgresql.test.jdbc2.RefCursorTest)  Ti

Re: portal pinning

2018-01-10 Thread Vladimir Sitnikov
> committed I'm afraid it causes regressions for pgjdbc. Here's CI log: https://travis-ci.org/pgjdbc/pgjdbc/jobs/327327402 The errors are: testMetaData[typeName = REF_CURSOR, cursorType = 2,012](org.postgresql.test.jdbc2.RefCursorTest) Time elapsed: 0.032 sec <<< ERROR! org.postgresql.util.PSQL

Re: portal pinning

2018-01-10 Thread Peter Eisentraut
On 1/8/18 20:28, Peter Eisentraut wrote: > On 1/8/18 15:27, Andrew Dunstan wrote: >> This seems like a good idea, and the code change is tiny and clean. I >> don't know of any third party PLs or other libraries might be pinning >> the portals already on their own. How would they be affected if they

Re: portal pinning

2018-01-08 Thread Peter Eisentraut
On 1/8/18 15:27, Andrew Dunstan wrote: > This seems like a good idea, and the code change is tiny and clean. I > don't know of any third party PLs or other libraries might be pinning > the portals already on their own. How would they be affected if they did? They would get an error if they tried t

Re: portal pinning

2018-01-08 Thread Andrew Dunstan
On 12/15/2017 03:36 PM, Peter Eisentraut wrote: > On 12/12/17 10:34, Peter Eisentraut wrote: >> But I also wonder whether we shouldn't automatically pin/unpin portals >> in SPI_cursor_open() and SPI_cursor_close(). This makes sense if you >> consider "pinned" to mean "internally generated". I d

Re: portal pinning

2017-12-15 Thread Peter Eisentraut
refcursors for example. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services From f9aaa47cf4e46aac973e532a790ac2099d017523 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Fri, 15 Dec 2017 15:24:10 -0500 Subject: [PA

portal pinning

2017-12-12 Thread Peter Eisentraut
While working on transaction control in procedures, I noticed some inconsistencies in how portal pinning is used. This mechanism was introduced in eb81b6509f4c9109ecf8839d8c482cc597270687 to prevent user code from closing cursors that PL/pgSQL has created internally, mainly for FOR loops