On 11/01/2019 22:05, Tom Lane wrote:
>> 2. If there's no pandoc, this coding silently produces a zero-size
>> INSTALL file. I do not find that acceptable.
>
> Seems like it might be sufficient for the rule to be
>
> $(PANDOC) $< -t plain > $@.tmp
> $(ICONV) -f utf8 -t us-ascii//TRANS
Hi!
On Fri, Jan 11, 2019 at 1:05 PM Tom Lane wrote:
> Failure would leave a .tmp file behind, but I doubt we care enough
> about that to work harder than this.
Maybe just make sure that "make clean" removes it?
Mitar
--
http://mitar.tnode.com/
https://twitter.com/mitar_m
I wrote:
> 1. No pandoc on borka, where we build tarballs:
> pgsql@borka:~$ which pandoc
> pgsql@borka:~$
That part's sorted, anyway.
pgsql@borka:~$ pandoc --version
pandoc 1.17.2
Compiled with texmath 0.8.6.7, highlighting-kate 0.6.3.
Syntax highlighting is supported for the following languages
Peter Eisentraut writes:
> On 09/01/2019 10:05, Mi Tar wrote:
>> I tested this. Patch applied cleanly and INSTALL file was produced.
>> Formatting looks differently from before, but I think that it looks better.
>> We lost central alignment of some headings, but many code/command snippets
>> ar
On 09/01/2019 10:05, Mi Tar wrote:
> I tested this. Patch applied cleanly and INSTALL file was produced.
> Formatting looks differently from before, but I think that it looks better.
> We lost central alignment of some headings, but many code/command snippets
> are now better/correctly indented.
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation:tested, failed
Hi!
I tested this. Patch applied cleanly and INSTALL file was produced.
On 2/27/17 10:55, Peter Eisentraut wrote:
> It appears we need pandoc 1.13 to get the good output. This won't be
> available until Debian stretch.
I understand that borka is updated to stretch now. So we could give
this another try. Updated patch attached.
--
Peter Eisentraut htt
