Re: port conflicts when running tests concurrently on windows.

2021-12-15 Thread Peter Eisentraut
On 13.12.21 20:33, Andres Freund wrote: pg_regress.c at remove_temp() is still there. These things should probably be addressed before we can consider making this the default. Hm, not immediately obvious what to do about this. Do you know if windows has restrictions around the length of unix d

Re: port conflicts when running tests concurrently on windows.

2021-12-13 Thread Andres Freund
Hi, On 2021-12-10 10:22:13 +0100, Peter Eisentraut wrote: > On 09.12.21 19:41, Andres Freund wrote: > > Withhttps://github.com/anarazel/postgres/commit/046203741803da863f6129739fd215f8a32ec357 > > all tests pass. pg_regress requires PG_REGRESS_SOCK_DIR because it checks > > for > > TMPDIR, but wi

Re: port conflicts when running tests concurrently on windows.

2021-12-10 Thread Peter Eisentraut
On 09.12.21 19:41, Andres Freund wrote: Withhttps://github.com/anarazel/postgres/commit/046203741803da863f6129739fd215f8a32ec357 all tests pass. pg_regress requires PG_REGRESS_SOCK_DIR because it checks for TMPDIR, but windows only has TMP and TEMP. This looks reasonable so far. The commit mes

Re: port conflicts when running tests concurrently on windows.

2021-12-09 Thread Andres Freund
Hi, On 2021-12-09 14:35:37 +0100, Peter Eisentraut wrote: > On 09.12.21 03:44, Thomas Munro wrote: > > On Thu, Dec 9, 2021 at 11:46 AM Andres Freund wrote: > > > Is it perhaps time to to use unix sockets on windows by default > > > (i.e. PG_TEST_USE_UNIX_SOCKETS), at least when on a new enough wi

Re: port conflicts when running tests concurrently on windows.

2021-12-09 Thread Andrew Dunstan
On 12/8/21 20:03, Andres Freund wrote: > > I wonder if we need a host2unix() helper accompanying perl2host()? Seems nicer > than sprinkling s!\\!/!g if $PostgreSQL::Test::Utils::windows_os in a growing > number of places... > Probably a good idea. I would call it canonical_path or something like

Re: port conflicts when running tests concurrently on windows.

2021-12-09 Thread Andrew Dunstan
On 12/9/21 08:35, Peter Eisentraut wrote: > On 09.12.21 03:44, Thomas Munro wrote: >> On Thu, Dec 9, 2021 at 11:46 AM Andres Freund  >> wrote: >>> Is it perhaps time to to use unix sockets on windows by default >>> (i.e. PG_TEST_USE_UNIX_SOCKETS), at least when on a new enough windows? > > Makes

Re: port conflicts when running tests concurrently on windows.

2021-12-09 Thread Peter Eisentraut
On 09.12.21 03:44, Thomas Munro wrote: On Thu, Dec 9, 2021 at 11:46 AM Andres Freund wrote: Is it perhaps time to to use unix sockets on windows by default (i.e. PG_TEST_USE_UNIX_SOCKETS), at least when on a new enough windows? Makes sense to get this to work, at least as an option. Makes s

Re: port conflicts when running tests concurrently on windows.

2021-12-08 Thread Thomas Munro
On Thu, Dec 9, 2021 at 11:46 AM Andres Freund wrote: > Is it perhaps time to to use unix sockets on windows by default > (i.e. PG_TEST_USE_UNIX_SOCKETS), at least when on a new enough windows? Makes sense. As a data point, it looks like this feature is in all supported releases of Windows. It a

Re: port conflicts when running tests concurrently on windows.

2021-12-08 Thread Andres Freund
Hi, On 2021-12-08 17:03:07 -0800, Andres Freund wrote: > On 2021-12-08 16:36:14 -0800, Andres Freund wrote: > > On 2021-12-08 14:45:50 -0800, Andres Freund wrote: > > > Is it perhaps time to to use unix sockets on windows by default > > > (i.e. PG_TEST_USE_UNIX_SOCKETS), at least when on a new eno

Re: port conflicts when running tests concurrently on windows.

2021-12-08 Thread Andres Freund
Hi, On 2021-12-08 16:36:14 -0800, Andres Freund wrote: > On 2021-12-08 14:45:50 -0800, Andres Freund wrote: > > Is it perhaps time to to use unix sockets on windows by default > > (i.e. PG_TEST_USE_UNIX_SOCKETS), at least when on a new enough windows? > > On its own PG_TEST_USE_UNIX_SOCKETS doesn

Re: port conflicts when running tests concurrently on windows.

2021-12-08 Thread Andres Freund
Hi, On 2021-12-08 14:45:50 -0800, Andres Freund wrote: > Is it perhaps time to to use unix sockets on windows by default > (i.e. PG_TEST_USE_UNIX_SOCKETS), at least when on a new enough windows? On its own PG_TEST_USE_UNIX_SOCKETS doesn't work at all on windows - it fails trying to use /tmp/ as a

port conflicts when running tests concurrently on windows.

2021-12-08 Thread Andres Freund
Hi, With the meson patch applied the tests on windows run concurrently by default. Unfortunately that fails semi-regularly. The reason for this basically is that windows defaults to using TCP in tests, and that the tap-test port determination is very racy: > # When selecting a port, we look