Re: plan_cache_mode and postgresql.conf.sample

2018-08-22 Thread Michael Paquier
On Wed, Aug 22, 2018 at 03:41:26PM +0900, Michael Paquier wrote: > This line now spawns at 87 characters for me, so that's not quite it. I > think that you should just have put the list into two lines. Thanks Thomas for af63926, this addresses the issue. -- Michael signature.asc Description: PG

Re: plan_cache_mode and postgresql.conf.sample

2018-08-22 Thread David Rowley
On 22 August 2018 at 18:41, Michael Paquier wrote: > On Wed, Aug 22, 2018 at 06:26:52PM +1200, Thomas Munro wrote: >> Thanks, pushed. I removed one tab because it looks like the comments >> in that file are supposed to line up with tabstop=8 (unlike our source >> files which use 4), and this one

Re: plan_cache_mode and postgresql.conf.sample

2018-08-21 Thread Michael Paquier
On Wed, Aug 22, 2018 at 06:26:52PM +1200, Thomas Munro wrote: > Thanks, pushed. I removed one tab because it looks like the comments > in that file are supposed to line up with tabstop=8 (unlike our source > files which use 4), and this one didn't. I hope I got that right! This line now spawns a

Re: plan_cache_mode and postgresql.conf.sample

2018-08-21 Thread Thomas Munro
On Wed, Aug 22, 2018 at 5:45 PM, David Rowley wrote: > While testing something that I needed to ensure a generic plan was > being used, during editing postgresql.conf I couldn't quite remember > the exact spelling of the option to do that. I think the valid > options for the setting should be lis

plan_cache_mode and postgresql.conf.sample

2018-08-21 Thread David Rowley
Hi, While testing something that I needed to ensure a generic plan was being used, during editing postgresql.conf I couldn't quite remember the exact spelling of the option to do that. I think the valid options for the setting should be listed in the sample config file. Patch attached. -- Dav