Re: pipelining in psql, commit 41625ab

2025-04-20 Thread Michael Paquier
On Wed, Apr 16, 2025 at 04:13:10PM -0700, Noah Misch wrote: > Works for me. I have fixed the three defects you have reported with 5ee7bd944ee8, 5743d122fcf3 and 78231baaf967 for respectively the error code of \getresults, the description of \flush[request] and the output of --help=commands with th

Re: pipelining in psql, commit 41625ab

2025-04-16 Thread Noah Misch
On Wed, Apr 16, 2025 at 09:46:42AM -0700, Michael Paquier wrote: > On Tue, Apr 15, 2025 at 02:34:50PM -0700, Noah Misch wrote: > > On Fri, Feb 21, 2025 at 11:33:41AM +0900, Michael Paquier wrote: > > commit 41625ab wrote: > >> --- a/src/bin/psql/help.c > >> +++ b/src/bin/psql/help.c > >> @@ -167,15

Re: pipelining in psql, commit 41625ab

2025-04-16 Thread Michael Paquier
On Tue, Apr 15, 2025 at 02:34:50PM -0700, Noah Misch wrote: > On Fri, Feb 21, 2025 at 11:33:41AM +0900, Michael Paquier wrote: > commit 41625ab wrote: >> * \syncpipeline queues a synchronisation request, without flushing the >> commands to the server, equivalent of PQsendPipelineSync(). >>

Re: pipelining in psql, commit 41625ab

2025-04-15 Thread Jelte Fennema-Nio
On Tue, 15 Apr 2025 at 23:34, Noah Misch wrote: > That said, maybe having > PQpipelineSync() was a mistake, since I think it's just PQsendPipelineSync() + > PQflush(). Yes, IMO that's pretty much the case. But we cannot remove that function because of backwards compatibility. Note that for all t

pipelining in psql, commit 41625ab

2025-04-15 Thread Noah Misch
On Fri, Feb 21, 2025 at 11:33:41AM +0900, Michael Paquier wrote: > So let's take one step here, I have applied the main patch. commit 41625ab wrote: > * \syncpipeline queues a synchronisation request, without flushing the > commands to the server, equivalent of PQsendPipelineSync(). libpq