Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*

2023-12-01 Thread Andres Freund
Hi, On 2023-12-01 15:55:29 -0600, Tristan Partin wrote: > Commits look fine to me, but I hate the new target names... You shouldn't ever need to use them anywhere - that's what the alias is for... Happy to go another route if you have a suggestion. > > +for name, v in targets_info_byname.

Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*

2023-12-01 Thread Tristan Partin
Commits look fine to me, but I hate the new target names... Luckily, I just use plain ninja, so I don't interact with that. +for name, v in targets_info_byname.items(): +if len(targets_info_byname[name]) > 1: My only comment is that you could reverse the logic and save yourself

Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*

2023-11-29 Thread Andres Freund
Hi, This started at https://www.postgresql.org/message-id/746ba786-85bb-d1f7-b613-57bec35c642a%40dunslane.net but seems worth discussing on -hackers. On 2023-11-29 07:20:59 -0500, Andrew Dunstan wrote: > On 2023-11-28 Tu 21:28, Andres Freund wrote: > > On 2023-11-23 08:32:21 -0500, Andrew Dunsta